BzrTools

bzrtools testsuite has python 2.7 incompatibility

Bug #708268 reported by Max Bowsher
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
BzrTools
Fix Released
Undecided
Unassigned
bzrtools (Ubuntu)
Fix Released
Undecided
Jelmer Vernooij

Bug Description

I've not yet had a chance to look into this, but the bzrtools testsuite fails under Python 2.7 on natty, apparently for some tarfile related reason:

https://launchpad.net/~bzr/+archive/beta/+buildjob/2225407

Jelmer Vernooij (jelmer)
Changed in bzrtools:
status: New → Confirmed
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

The attached branch fixes this particular issue, but I suspect I'm overlooking the reason why this code is present in the first place.

Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

Any follow up on this? These test failures lead to bzrtools not building in Ubuntu natty (Bug #708139).

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

I talked to Aaron last week, and would be interested to hear from him whether this is a sensible change.

Revision history for this message
Aaron Bentley (abentley) wrote : Re: [Bug 708268] Re: bzrtools testsuite has python 2.7 incompatibility

I will be looking into this. It took a while to remember the purpose of that test.
--
Sent from my phone. Please excuse my brevity.

Aaron Bentley (abentley)
Changed in bzrtools:
status: Confirmed → Fix Released
Revision history for this message
Aaron Bentley (abentley) wrote :

The purpose of the test was to check that tarfiles with multiple entries for the same file were handled correctly. Such tarfiles are valid and can be manually produced using the 'r' flag.

TarFile.open(result, 'a') seems like it ought to have the same effect as 'tar -r', but apparently it doesn't, and didn't on Python2.6 either.

However, it turns out we can just do TarFile.add twice to get the desired effect.

Jelmer Vernooij (jelmer)
Changed in bzrtools (Ubuntu):
status: New → Confirmed
Jelmer Vernooij (jelmer)
Changed in bzrtools (Ubuntu):
assignee: nobody → Jelmer Vernooij (jelmer)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package bzrtools - 2.3.1-1

---------------
bzrtools (2.3.1-1) unstable; urgency=low

  * Update watch file to use new location on Launchpad.
   + Fixes compatibility with Python 2.7. LP: #708268
  * New upstream release.

bzrtools (2.3.0-1) unstable; urgency=low

  * New upstream release.
 -- Jelmer Vernooij <email address hidden> Fri, 04 Feb 2011 12:05:36 +0000

Changed in bzrtools (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.