[armel] QFloat / double / float confusion

https://launchpad.net/ubuntu/+source/musescore/0.9.6+dfsg-1/+build/1846856

pencil:

g++ -c -pipe -O2 -D_REENTRANT -Wall -W -DQT_NO_DEBUG -DQT_XML_LIB -DQT_OPENGL_LIB -DQT_GUI_LIB -DQT_CORE_LIB -DQT_SHARED -I/usr/share/qt4/mkspecs/linux-g++ -I. -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtGui -I/usr/include/qt4/QtOpenGL -I/usr/include/qt4/QtXml -I/usr/include/qt4 -I. -Isrc -Isrc/external/flash -Isrc/external/linux -Isrc/external/macosx -Isrc/external/win32 -Isrc/graphics -Isrc/graphics/bitmap -Isrc/graphics/vector -Isrc/interface -Isrc/structure -I. -Iliblinux -I/usr/X11R6/include -I. -o vectorimage.o src/graphics/vector/vectorimage.cpp
src/graphics/vector/vectorimage.cpp: In member function 'bool VectorImage::read(QString)':
src/graphics/vector/vectorimage.cpp:48: warning: unused variable 'layerNumber'
src/graphics/vector/vectorimage.cpp: In member function 'void VectorImage::addCurve(BezierCurve&, qreal)':
src/graphics/vector/vectorimage.cpp:178: error: no matching function for call to 'qMax(qreal, double)'
src/graphics/vector/vectorimage.cpp: In member function 'void VectorImage::paintImage(QPainter&, bool, bool, qreal, bool, int)':
src/graphics/vector/vectorimage.cpp:696: warning: unused variable 'scale'
src/graphics/vector/vectorimage.cpp: At global scope:
src/graphics/vector/vectorimage.cpp:768: warning: unused parameter 'size'
src/graphics/vector/vectorimage.cpp:830: warning: unused parameter 'opacity'
make[1]: *** [vectorimage.o] Error 1
make[1]: Leaving directory `/build/buildd/pencil-0.4.4b'

kamoso:

/usr/bin/cmake -E cmake_progress_report /build/buildd/kamoso-1.0.5/obj-arm-linux-gnueabi/CMakeFiles 18
[ 32%] Building CXX object src/CMakeFiles/kamoso.dir/kamoso.o
cd /build/buildd/kamoso-1.0.5/obj-arm-linux-gnueabi/src && /usr/bin/c++ -D_BSD_SOURCE -g -O2 -Wnon-virtual-dtor -Wno-long-long -ansi -Wundef -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -Wformat-security -fno-exceptions -DQT_NO_EXCEPTIONS -fno-check-new -fno-common -Woverloaded-virtual -fno-threadsafe-statics -fvisibility=hidden -fvisibility-inlines-hidden -DNDEBUG -DQT_NO_DEBUG -I/build/buildd/kamoso-1.0.5/obj-arm-linux-gnueabi -I/usr/include/KDE -I/usr/include/qt4/phonon -I/usr/include/qt4/QtXmlPatterns -I/usr/include/qt4/QtXml -I/usr/include/qt4/QtWebKit -I/usr/include/qt4/QtUiTools -I/usr/include/qt4/QtTest -I/usr/include/qt4/QtSvg -I/usr/include/qt4/QtSql -I/usr/include/qt4/QtScriptTools -I/usr/include/qt4/QtScript -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtHelp -I/usr/include/qt4/QtDesigner -I/usr/include/qt4/QtDeclarative -I/usr/include/qt4/QtDBus -I/usr/include/qt4/Qt3Support -I/usr/include/qt4/QtGui -I/usr/include/qt4/QtCore -I/usr/include/qt4/Qt -I/usr/share/qt4/mkspecs/default -I/usr/include/qt4 -I/build/buildd/kamoso-1.0.5/src -I/build/buildd/kamoso-1.0.5/obj-arm-linux-gnueabi/src -o CMakeFiles/kamoso.dir/kamoso.o -c /build/buildd/kamoso-1.0.5/src/kamoso.cpp
/build/buildd/kamoso-1.0.5/src/kamoso.cpp:445: warning: #warning make it possible to deal with many url at the same time
In file included from /usr/include/qt4/QtCore/qobject.h:48,
                 from /usr/include/qt4/QtGui/qwidget.h:46,
                 from /usr/include/qt4/QtGui/qmainwindow.h:45,
                 from /usr/include/qt4/QtGui/QMainWindow:1,
                 from /usr/include/KDE/../kmainwindow.h:35,
                 from /usr/include/KDE/KMainWindow:1,
                 from /build/buildd/kamoso-1.0.5/src/kamoso.h:23,
                 from /build/buildd/kamoso-1.0.5/src/kamoso.cpp:20:
/usr/include/qt4/QtCore/qstring.h:187: note: the mangling of 'va_list' has changed in GCC 4.4
/build/buildd/kamoso-1.0.5/src/kamoso.cpp: In member function 'void Kamoso::startCountdown(qreal)':
/build/buildd/kamoso-1.0.5/src/kamoso.cpp:335: error: no matching function for call to 'qMax(qreal&, double)'

kde-style-bespin:

cd "/build/buildd/kde-style-bespin-0.1~svn100126/obj-arm-linux-gnueabi/kwin" && /usr/bin/c++ -DMAKE_KWIN3_BESPIN_LIB -DQT3_SUPPORT -D_BSD_SOURCE -DBESPIN_ARGB_WINDOWS=0 -DBESPIN_HACK_AMAROK=0 -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -DQT_NO_STL -DQT_NO_CAST_TO_ASCII -D_REENTRANT -DKDE_DEPRECATED_WARNINGS -DBLIB_EXPORT=Q_DECL_IMPORT -g -O2 -Wnon-virtual-dtor -Wno-long-long -ansi -Wundef -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -Wformat-security -fno-exceptions -DQT_NO_EXCEPTIONS -fno-check-new -fno-common -Woverloaded-virtual -fno-threadsafe-statics -fvisibility=hidden -fvisibility-inlines-hidden -DNDEBUG -DQT_NO_DEBUG -fPIC -I"/build/buildd/kde-style-bespin-0.1~svn100126/obj-arm-linux-gnueabi/kwin" -I"/build/buildd/kde-style-bespin-0.1~svn100126/kwin" -I/usr/include/KDE -I/usr/include/qt4/phonon -I/usr/include/qt4/QtXmlPatterns -I/usr/include/qt4/QtXml -I/usr/include/qt4/QtWebKit -I/usr/include/qt4/QtUiTools -I/usr/include/qt4/QtTest -I/usr/include/qt4/QtSvg -I/usr/include/qt4/QtSql -I/usr/include/qt4/QtScriptTools -I/usr/include/qt4/QtScript -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtHelp -I/usr/include/qt4/QtDesigner -I/usr/include/qt4/QtDeclarative -I/usr/include/qt4/QtDBus -I/usr/include/qt4/Qt3Support -I/usr/include/qt4/QtGui -I/usr/include/qt4/QtCore -I/usr/include/qt4/Qt -I/usr/share/qt4/mkspecs/default -I/usr/include/qt4 -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -o CMakeFiles/kwin3_bespin.dir/client.o -c "/build/buildd/kde-style-bespin-0.1~svn100126/kwin/client.cpp"
In file included from /usr/include/qt4/QtGui/qkeysequence.h:46,
                 from /usr/include/qt4/QtGui/qaction.h:45,
                 from /usr/include/qt4/QtGui/QAction:1,
                 from /build/buildd/kde-style-bespin-0.1~svn100126/kwin/client.cpp:28:
/usr/include/qt4/QtCore/qstring.h:187: note: the mangling of 'va_list' has changed in GCC 4.4
/build/buildd/kde-style-bespin-0.1~svn100126/kwin/client.cpp: In member function 'void Bespin::Client::repaint(QPainter&, bool)':
/build/buildd/kde-style-bespin-0.1~svn100126/kwin/client.cpp:792: error: no matching function for call to 'qMax(qreal&, double)'
make[3]: *** [kwin/CMakeFiles/kwin3_bespin.dir/client.o] Error 1
make[3]: Leaving directory `/build/buildd/kde-style-bespin-0.1~svn100126/obj-arm-linux-gnueabi'
make[2]: *** [kwin/CMakeFiles/kwin3_bespin.dir/all] Error 2

kradio:

/usr/bin/cmake -E cmake_progress_report /build/buildd/kradio-4.0.0/obj-arm-linux-gnueabi/CMakeFiles 55
[ 86%] Building CXX object plugins/gui-standard-display/CMakeFiles/kradio4_plugin_gui_standard_display.dir/radioview_frequencyradio.o
cd /build/buildd/kradio-4.0.0/obj-arm-linux-gnueabi/plugins/gui-standard-display && /usr/bin/g++ -DMAKE_KRADIO4_PLUGIN_GUI_STANDARD_DISPLAY_LIB -D_BSD_SOURCE -DHAVE_LIRC -DHAVE_FFMPEG -DHAVE_MMS -g -O2 -g -Wall -O2 -Wnon-virtual-dtor -Wno-long-long -ansi -Wundef -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -Wformat-security -fno-exceptions -DQT_NO_EXCEPTIONS -fno-check-new -fno-common -Woverloaded-virtual -fno-threadsafe-statics -fvisibility=hidden -fvisibility-inlines-hidden -DNDEBUG -DQT_NO_DEBUG -fPIC -I/build/buildd/kradio-4.0.0/obj-arm-linux-gnueabi/plugins/gui-standard-display -I/build/buildd/kradio-4.0.0/plugins/gui-standard-display -I/build/buildd/kradio-4.0.0/obj-arm-linux-gnueabi/src -I/build/buildd/kradio-4.0.0/src -I/build/buildd/kradio-4.0.0/interfaces -I/build/buildd/kradio-4.0.0/radiostations -I/usr/include/qt4 -DKRADIO_VERSION="\"4.0.0\"" -DPROJECT_NAME="\"kradio4_plugin_gui_standard_display\"" -o CMakeFiles/kradio4_plugin_gui_standard_display.dir/radioview_frequencyradio.o -c /build/buildd/kradio-4.0.0/plugins/gui-standard-display/radioview_frequencyradio.cpp
/build/buildd/kradio-4.0.0/plugins/gui-standard-display/radioview_frequencyradio.cpp: In member function 'virtual void RadioViewFrequencyRadio::paintEvent(QPaintEvent*)':
/build/buildd/kradio-4.0.0/plugins/gui-standard-display/radioview_frequencyradio.cpp:411: error: no matching function for call to 'qMin(qreal&, double)'
make[3]: *** [plugins/gui-standard-display/CMakeFiles/kradio4_plugin_gui_standard_display.dir/radioview_frequencyradio.o] Error 1
make[3]: Leaving directory `/build/buildd/kradio-4.0.0/obj-arm-linux-gnueabi'

kamoso patch hopefully, no armel test environment but should be good

Description: Fixes non existent call to qMax(qreal, double) on armel bug
 by casting double arg to qreal

thanks for the update, kamoso now fails to build with:

[ 44%] Building CXX object src/CMakeFiles/kamoso.dir/webcamwidget.o
cd /home/doko/tmp/kamoso-1.0.5/obj-arm-linux-gnueabi/src && /usr/bin/c++ -D_BSD_SOURCE -g -O2 -Wnon
-virtual-dtor -Wno-long-long -ansi -Wundef -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -Wf
ormat-security -fno-exceptions -DQT_NO_EXCEPTIONS -fno-check-new -fno-common -Woverloaded-virtual -fno
-threadsafe-statics -fvisibility=hidden -fvisibility-inlines-hidden -DNDEBUG -DQT_NO_DEBUG -I/home/dok
o/tmp/kamoso-1.0.5/obj-arm-linux-gnueabi -I/usr/include/KDE -I/usr/include/qt4/phonon -I/usr/include/q
t4/QtXmlPatterns -I/usr/include/qt4/QtXml -I/usr/include/qt4/QtWebKit -I/usr/include/qt4/QtUiTools -I/
usr/include/qt4/QtTest -I/usr/include/qt4/QtSvg -I/usr/include/qt4/QtSql -I/usr/include/qt4/QtScriptTo
ols -I/usr/include/qt4/QtScript -I/usr/include/qt4/QtOpenGL -I/usr/include/qt4/QtNetwork -I/usr/includ
e/qt4/QtHelp -I/usr/include/qt4/QtDesigner -I/usr/include/qt4/QtDeclarative -I/usr/include/qt4/QtDBus -I/usr/include/qt4/Qt3Support -I/usr/include/qt4/QtGui -I/usr/include/qt4/QtCore -I/usr/include/qt4/Qt -I/usr/share/qt4/mkspecs/default -I/usr/include/qt4 -I/home/doko/tmp/kamoso-1.0.5/src -I/home/doko/tmp/kamoso-1.0.5/obj-arm-linux-gnueabi/src -o CMakeFiles/kamoso.dir/webcamwidget.o -c /home/doko/tmp/kamoso-1.0.5/src/webcamwidget.cpp
/home/doko/tmp/kamoso-1.0.5/src/webcamwidget.cpp:151: warning: #warning replace /tmp/ by api
/home/doko/tmp/kamoso-1.0.5/src/webcamwidget.cpp:161: warning: #warning shouldnt we raise all these exceptions?
In file included from /usr/include/qt4/QtCore/qobject.h:48,
                 from /usr/include/qt4/QtGui/qwidget.h:46,
                 from /usr/include/qt4/QtGui/QWidget:1,
                 from /home/doko/tmp/kamoso-1.0.5/src/webcamwidget.h:23,
                 from /home/doko/tmp/kamoso-1.0.5/src/webcamwidget.cpp:24:
/usr/include/qt4/QtCore/qstring.h:187: note: the mangling of 'va_list' has changed in GCC 4.4
/home/doko/tmp/kamoso-1.0.5/src/webcamwidget.cpp:47: error: 'libvlc_exception_t' has not been declared
/home/doko/tmp/kamoso-1.0.5/src/webcamwidget.cpp:50: error: 'libvlc_exception_t' does not name a type
/home/doko/tmp/kamoso-1.0.5/src/webcamwidget.cpp: In constructor 'WebcamWidget::WebcamWidget(QWidget*)':
/home/doko/tmp/kamoso-1.0.5/src/webcamwidget.cpp:70: error: 'struct WebcamWidget::Private' has no member named '_vlcexcep'
/home/doko/tmp/kamoso-1.0.5/src/webcamwidget.cpp:70: error: 'libvlc_exception_init' was not declared in this scope
/home/doko/tmp/kamoso-1.0.5/src/webcamwidget.cpp:73: error: 'struct WebcamWidget::Private' has no member named '_vlcexcep'
/home/doko/tmp/kamoso-1.0.5/src/webcamwidget.cpp:74: error: 'struct WebcamWidget::Private' has no member named '_vlcexcep'
/home/doko/tmp/kamoso-1.0.5/src/webcamwidget.cpp:77: error: 'struct WebcamWidget::Private' has no member named '_vlcexcep'
/home/doko/tmp/kamoso-1.0.5/src/webcamwidget.cpp:78: error: 'struct WebcamWidget::Private' has no member named '_vlcexcep'

Sorry mathias, i should have mentioned that it also needed additional build fixes included in

https://bugs.edge.launchpad.net/ubuntu/+source/kamoso/+bug/642705

which at least allow build with newer vlc

Pencil:

kde-style-bespin:

kradio diff, no patch system:

I'll need to try and set up an armel qemubuilder thing to test these, there may be more qreal errors to come.

This bug was fixed in the package kamoso - 1.0.5-0ubuntu4

---------------
kamoso (1.0.5-0ubuntu4) maverick; urgency=low

  * armel-qmax-fix:
    - Fixes non existent call to qMax(qreal, double) on armel bug
    by casting double arg to qreal (LP: #642117)
  * vlc11-build-fix:
    - Replace libvlc_exception and lib_media_player_set_drawable
    related code and to build against vlc 1.1 (LP: #642705)
 -- Niall Creech <email address hidden> Tue, 21 Sep 2010 11:20:44 +0100

kde-style-bespin (0.1~svn100126-0ubuntu4) maverick; urgency=low

  * armel-qmax-fix:
    - Fixes non existent call to qMax(qreal, double) on armel bug
    by casting double arg to qreali (LP: #642117)

 pencil (0.4.4b-0ubuntu3) maverick; urgency=low

  * armel-qmax-fix:
    - Fixes non existent call to qMax(qreal, double) on armel bug
      by casting double arg to qreal (LP: #642117)

kradio (4.0.0-0ubuntu5) maverick; urgency=low

  * armel-qreal-fix:
    - Fixes non existent call to qMin(qreal, double) on armel bug
    by casting double arg to qreali (LP: #642117)

Possible musescore fix

musescore (0.9.6+dfsg-1ubuntu1) maverick; urgency=low

  * armel-float-cast-fix.dpatch:
    - Fixes armel build by explicit creation of double return type
    from float (LP: #642117)

Ignore the musescore one, that was just silly

musescore (0.9.6+dfsg-1ubuntu1) maverick; urgency=low

  * armel-float-cast-fix.dpatch:
    - Fixes armel build by explicit cast of qreal reference to
    double return type(LP: #642117)

Ii'll try and get an armel build of these tomorrow to test them out, they shouldnt affect the i386/amd64 builds adversely though

Actually add patch to 00list :(

kradio now fails to build with:

/usr/bin/cmake -E cmake_progress_report /home/doko/tmp/kradio-4.0.0/obj-arm-linux-gnueabi/CMakeFiles 63
[ 94%] Building CXX object plugins/internetradio/CMakeFiles/kradio4_plugin_internetradio.dir/decoder_thread.o
cd /home/doko/tmp/kradio-4.0.0/obj-arm-linux-gnueabi/plugins/internetradio && /usr/bin/g++ -DMAKE_KRADIO4_PLUGIN_INTERNETRADIO_LIB -D_BSD_SOURCE -DHAVE_ALS
A -DHAVE_LIRC -DHAVE_FFMPEG -DHAVE_MMS -g -O2 -g -Wall -O2 -Wnon-virtual-dtor -Wno-long-long -ansi -Wundef -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-
arith -Wformat-security -fno-exceptions -DQT_NO_EXCEPTIONS -fno-check-new -fno-common -Woverloaded-virtual -fno-threadsafe-statics -fvisibility=hidden -fvisi
bility-inlines-hidden -DNDEBUG -DQT_NO_DEBUG -fPIC -I/home/doko/tmp/kradio-4.0.0/obj-arm-linux-gnueabi/plugins/internetradio -I/home/doko/tmp/kradio-4.0.0/pl
ugins/internetradio -I/home/doko/tmp/kradio-4.0.0/obj-arm-linux-gnueabi/src -I/home/doko/tmp/kradio-4.0.0/src -I/home/doko/tmp/kradio-4.0.0/interfaces -I/hom
e/doko/tmp/kradio-4.0.0/radiostations -I/usr/include/qt4 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -DKRADIO_VERSION="\"4.0.0\"" -DPROJECT_NAME="\
"kradio4_plugin_internetradio\"" -o CMakeFiles/kradio4_plugin_internetradio.dir/decoder_thread.o -c /home/doko/tmp/kradio-4.0.0/plugins/internetradio/decoder
_thread.cpp
In file included from /usr/include/qt4/QtCore/qobject.h:48,
                 from /usr/include/qt4/QtCore/qcoreapplication.h:45,
                 from /usr/include/qt4/QtGui/qapplication.h:45,
                 from /usr/include/qt4/QtGui/QApplication:1,
                 from /home/doko/tmp/kradio-4.0.0/plugins/internetradio/decoder_thread.cpp:24:
/usr/include/qt4/QtCore/qstring.h:187: note: the mangling of 'va_list' has changed in GCC 4.4
In file included from //usr/include/libavutil/avutil.h:81,
                 from //usr/include/libavcodec/avcodec.h:30,
                 from //usr/include/libavformat/avformat.h:56,
                 from /home/doko/tmp/kradio-4.0.0/plugins/internetradio/decoder_thread.h:41,
                 from /home/doko/tmp/kradio-4.0.0/plugins/internetradio/decoder_thread.cpp:35:
//usr/include/libavutil/common.h: In function 'int32_t av_clipl_int32(int64_t)':
//usr/include/libavutil/common.h:154: error: 'UINT64_C' was not declared in this scope

I'll look into it, I'm just working through them now on an armel pbuilder environment, pencil will fail too

pencil: Added two more chunks, please update your diff, when forwarding the patch

This bug was fixed in the package pencil - 0.4.4b-0ubuntu3

---------------
pencil (0.4.4b-0ubuntu3) maverick; urgency=low

  * armel-qmax-fix:
    - Fixes non existent call to qMax(qreal, double) on armel bug
      by casting double arg to qreal (LP: #642117)
 -- Niall Creech <email address hidden> Sun, 19 Sep 2010 13:50:10 +0100

Great, thanks mathias, i'll start on a kde-style-bespin build

Dhould get rid of the avutils/common.h problem, not tested build yet though

kradio (4.0.0-0ubuntu5) maverick; urgency=low

  * armel-qreal-fix:
    - Fixes non existent call to qMin(qreal, double) on armel bug
    by casting double arg to qreali (LP: #642117)
  * debian/rules:
    - Make sure __STDC_CONSTANT_MACROS is defined in cxxflags to
    ensure build catches missing <stdint.h> in avutils common.h

This bug was fixed in the package kde-style-bespin - 0.1~svn100126-0ubuntu4

---------------
kde-style-bespin (0.1~svn100126-0ubuntu4) maverick; urgency=low

  * armel-qmax-fix:
    - Fixes non existent call to qMax(qreal, double) on armel bug
    by casting double arg to qreali (LP: #642117)
 -- Niall Creech <email address hidden> Tue, 21 Sep 2010 13:18:37 +0100

This bug was fixed in the package kradio - 4.0.0-0ubuntu5

---------------
kradio (4.0.0-0ubuntu5) maverick; urgency=low

  * armel-qreal-fix:
    - Fixes non existent call to qMin(qreal, double) on armel bug
    by casting double arg to qreali (LP: #642117)
  * debian/rules:
    - Make sure __STDC_CONSTANT_MACROS is defined in cxxflags to
    ensure build catches missing <stdint.h> in avutils common.h
 -- Niall Creech <email address hidden> Tue, 21 Sep 2010 17:37:24 +0100

musescore will need a different approach i think. Arm builds are taking an age here so it takes a while to check

This takes a couple of hours to build here so it might be tomorrow before i can check it

if you're tired of waiting, there are more build failures of KDE related packages on armel ;)
see http://qa.ubuntuwire.com/ftbfs/

:) Will do. Might have a look at why the builds taking so long first. dual quad xeon, probably havent set it up right yet. i'll try musescore tomorrow when theres enough time

musescore:

[ 44%] Building CXX object mscore/CMakeFiles/mscore.dir/scoreview.cpp.o
In file included from /usr/include/qt4/QtCore/qobject.h:48,
                 from /usr/include/qt4/QtGui/qabstractitemdelegate.h:45,
                 from /usr/include/qt4/QtGui/qitemdelegate.h:45,
                 from /usr/include/qt4/QtGui/QItemDelegate:1,
                 from /home/doko/tmp/musescore-0.9.6+dfsg/build/all.h:32,
                 from <command-line>:0:
/usr/include/qt4/QtCore/qstring.h:187: note: the mangling of 'va_list' has changed in GCC 4.4
/home/doko/tmp/musescore-0.9.6+dfsg/mscore/mscore/scoreview.cpp:2259: error: prototype for 'void ScoreView::setMag(double)' does not match any in class 'ScoreView'
/home/doko/tmp/musescore-0.9.6+dfsg/mscore/mscore/scoreview.h:269: error: candidates are: void ScoreView::setMag(int, double)
/home/doko/tmp/musescore-0.9.6+dfsg/mscore/mscore/scoreview.h:225: error: void ScoreView::setMag(qreal)
make[4]: *** [mscore/CMakeFiles/mscore.dir/scoreview.cpp.o] Error 1

Currently at 50% and still going with the attached debdiff, another couple of hours to go :)

Looks like that last musescore debdiff compiles ok

Hey SevenMachines,
I looked at your patch, and it looks good, and should resolve the qreal/float issues on armel although there is a "neater" way to solve this issue. From your kradio diff, you have the following code patch:

--- kradio-4.0.0.orig/plugins/gui-standard-display/radioview_frequencyradio.cpp
+++ kradio-4.0.0/plugins/gui-standard-display/radioview_frequencyradio.cpp
@@ -408,7 +408,7 @@

     // auxiliary variables
     qreal margin = qMax(4.0, qMin(width / 50.0, height / 50.0));
- qreal tmp = qMin(height, (width - 2 * margin) / 6.0);
+ qreal tmp = qMin(height, (width - 2 * margin) / qreal(6.0));
     qreal xd_st = qMin((height - margin * 2) / 3.0, tmp / 3.0);
     qreal xw = qMin(tmp / 2.0, xd_st * 1.5);
     qreal penw = qMax(1.0, xw / 25.0);

The following also works, and is what I use for sake of code neatness/sanity

--- kradio-4.0.0.orig/plugins/gui-standard-display/radioview_frequencyradio.cpp
+++ kradio-4.0.0/plugins/gui-standard-display/radioview_frequencyradio.cpp
@@ -408,7 +408,7 @@

     // auxiliary variables
     qreal margin = qMax(4.0, qMin(width / 50.0, height / 50.0));
- qreal tmp = qMin(height, (width - 2 * margin) / 6.0);
+ qreal tmp = qMin<double>(height, (width - 2 * margin) / 6.0);
     qreal xd_st = qMin((height - margin * 2) / 3.0, tmp / 3.0);
     qreal xw = qMin(tmp / 2.0, xd_st * 1.5);
     qreal penw = qMax(1.0, xw / 25.0);

This isn't a criticism, just a handy tip, as very few people seem to be aware of the ability to force casting on a template by using <>.

As for the musescore patch, it looks a little odd to me since it seems it could be fixed just by casting, and not changing the actual variable times (less invasive patch). Was there a specific reason to implement this chnage like this?

Anyway, thanks for all your work in this matter, and keep the patches coming, its great to see someone putting so much work into this :-)

Thanks Michael, i'm sure i tried casting in one of the builds and this gave me errors when building on armel but that would have been my preferred way. If that does indeed work then thats the better way, i'd test it again to make sure but its a 3-4 hour build here so it would need to wait until at least tomorrow!

This bug was fixed in the package musescore - 0.9.6.2+dfsg-1ubuntu1

---------------
musescore (0.9.6.2+dfsg-1ubuntu1) maverick; urgency=low

  * 20_armel-float-cast-fix.dpatch:
    - Define alternative rxpos and rypos calls for armel to handle
    its differenet QpointF rx() and ry() call return values. Ensure qMax
    and qMin calls have equivalent argument types(LP: #642117)
 -- Niall Creech <email address hidden> Tue, 21 Sep 2010 19:23:50 +0100

Indeed, using a cast to double in element.h:rxpos(), element.h:rypos() fails with the error

In file included from /tmp/buildd/musescore-0.9.6+dfsg/build/mscore/../../mscore/mscore/score.h:35,
                 from /tmp/buildd/musescore-0.9.6+dfsg/build/mscore/moc_score.cxx:10:
/tmp/buildd/musescore-0.9.6+dfsg/build/mscore/../../mscore/mscore/element.h: In member function 'double& Element::rxpos()':
/tmp/buildd/musescore-0.9.6+dfsg/build/mscore/../../mscore/mscore/element.h:192: error: invalid initialization of non-const reference of type 'double&' from a temporary of type 'double'
/tmp/buildd/musescore-0.9.6+dfsg/build/mscore/../../mscore/mscore/element.h: In member function 'double& Element::rypos()':
/tmp/buildd/musescore-0.9.6+dfsg/build/mscore/../../mscore/mscore/element.h:193: error: invalid initialization of non-const reference of type 'double&' from a temporary of type 'double'

I think i tried this before realising the reference return. In the end I thought it was better to use an __arm__ section than start to start possibly spreading the changes too wide. Theres probably a better way to do it but it was the first and simplest that sprung to my mind :)

skrooge:

[ 25%] Building CXX object skgbasegui/CMakeFiles/skgbasegui.dir/skgtablewithgraph.o
cd /build/buildd/skrooge-0.7.3.2/obj-arm-linux-gnueabi/skgbasegui && /usr/bin/c++ -DMAKE_SKGBASEGUI_LIB -D_BSD_SOURCE -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -DQT_NO_STL -DQT_NO_CAST_TO_ASCII -D_REENTRANT -DKDE_DEPRECATED_WARNINGS -DSKGVERSION=0.7.4 -Wall -g -O2 -Wnon-virtual-dtor -Wno-long-long -ansi -Wundef -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -Wformat-security -fno-exceptions -DQT_NO_EXCEPTIONS -fno-check-new -fno-common -Woverloaded-virtual -fno-threadsafe-statics -fvisibility=hidden -fvisibility-inlines-hidden -DNDEBUG -DQT_NO_DEBUG -fPIC -I/build/buildd/skrooge-0.7.3.2/obj-arm-linux-gnueabi/skgbasegui -I/build/buildd/skrooge-0.7.3.2/skgbasegui -I/build/buildd/skrooge-0.7.3.2 -I/build/buildd/skrooge-0.7.3.2/obj-arm-linux-gnueabi -I/build/buildd/skrooge-0.7.3.2/skgbasemodeler -I/build/buildd/skrooge-0.7.3.2/skgbasemodelertest -I/build/buildd/skrooge-0.7.3.2/skgbankmodeler -I/build/buildd/skrooge-0.7.3.2/skgbankgui -I/build/buildd/skrooge-0.7.3.2/obj-arm-linux-gnueabi/skgbankgui -I/usr/include/KDE -I/usr/include/qt4/phonon -I/usr/include/qt4/QtXmlPatterns -I/usr/include/qt4/QtXml -I/usr/include/qt4/QtWebKit -I/usr/include/qt4/QtUiTools -I/usr/include/qt4/QtTest -I/usr/include/qt4/QtSvg -I/usr/include/qt4/QtSql -I/usr/include/qt4/QtScriptTools -I/usr/include/qt4/QtScript -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtHelp -I/usr/include/qt4/QtDesigner -I/usr/include/qt4/QtDeclarative -I/usr/include/qt4/QtDBus -I/usr/include/qt4/Qt3Support -I/usr/include/qt4/QtGui -I/usr/include/qt4/QtCore -I/usr/include/qt4/Qt -I/usr/share/qt4/mkspecs/default -I/usr/include/qt4 -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -o CMakeFiles/skgbasegui.dir/skgtablewithgraph.o -c /build/buildd/skrooge-0.7.3.2/skgbasegui/skgtablewithgraph.cpp
/build/buildd/skrooge-0.7.3.2/skgbasegui/skgtablewithgraph.cpp: In member function 'void SKGTableWithGraph::redrawGraph()':
/build/buildd/skrooge-0.7.3.2/skgbasegui/skgtablewithgraph.cpp:1294: error: no matching function for call to 'qMax(double, qreal)'
make[3]: *** [skgbasegui/CMakeFiles/skgbasegui.dir/skgtablewithgraph.o] Error 1
make[3]: Leaving directory `/build/buildd/skrooge-0.7.3.2/obj-arm-linux-gnueabi'
make[2]: *** [skgbasegui/CMakeFiles/skgbasegui.dir/all] Error 2

ktoon:

g++ -c -pipe -O2 -Wall -W -D_REENTRANT -fPIC -DQT_NO_DEBUG -DQT_XML_LIB -DQT_GUI_LIB -DQT_CORE_LIB -DQT_SHARED -I/usr/share/qt4/mkspecs/linux-g++ -I. -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtGui -I/usr/include/qt4/QtXml -I/usr/include/qt4 -I../../src/ktoonlib -I../../src/core -I../../src/dialogs -I../../src/store -I../../src/dlib/dgui -I../../src/dlib/dcore -I.moc -o .obj/ktprojectparser.o ktprojectparser.cpp
ktprojectparser.cpp: In member function 'virtual bool KTProjectParser::startElement(const QString&, const QString&, const QString&, const QXmlAttributes&)':
ktprojectparser.cpp:215: error: no match for 'operator<<' in '((KTProjectParser*)this)->KTProjectParser::m_gradientStops << qMakePair(const T1&, const T2&) [with T1 = double, T2 = QColor](((const QColor&)((const QColor*)(& c))))'
/usr/include/qt4/QtCore/qvector.h:285: note: candidates are: QVector<T>& QVector<T>::operator<<(const T&) [with T = QPair<float, QColor>]
/usr/include/qt4/QtCore/qvector.h:287: note: QVector<T>& QVector<T>::operator<<(const QVector<T>&) [with T = QPair<float, QColor>]
/usr/include/qt4/QtCore/qchar.h:394: note: QDataStream& operator<<(QDataStream&, const QChar&)
/usr/include/qt4/QtCore/qbytearray.h:577: note: QDataStream& operator<<(QDataStream&, const QByteArray&)
/usr/include/qt4/QtCore/qstring.h:1082: note: QDataStream& operator<<(QDataStream&, const QString&)
/usr/include/qt4/QtCore/qobject.h:488: note: QDebug operator<<(QDebug, const QObject*)
/usr/include/qt4/QtCore/qiodevice.h:247: note: QDebug operator<<(QDebug, QFlags<QIODevice::OpenModeFlag>)
/usr/include/qt4/QtCore/qlocale.h:720: note: QDataStream& operator<<(QDataStream&, const QLocale&)
/usr/include/qt4/QtCore/qtextstream.h:290: note: QTextStream& operator<<(QTextStream&, QTextStream& (*)(QTextStream&))
/usr/include/qt4/QtCore/qtextstream.h:293: note: QTextStream& operator<<(QTextStream&, QTextStreamManipulator)
/usr/include/qt4/QtCore/qregexp.h:154: note: QDataStream& operator<<(QDataStream&, const QRegExp&)
/usr/include/qt4/QtCore/qstringlist.h:249: note: QDataStream& operator<<(QDataStream&, const QStringList&)
/usr/include/qt4/QtCore/qsize.h:102: note: QDataStream& operator<<(QDataStream&, const QSize&)
/usr/include/qt4/QtCore/qsize.h:198: note: QDebug operator<<(QDebug, const QSize&)
/usr/include/qt4/QtCore/qsize.h:255: note: QDataStream& operator<<(QDataStream&, const QSizeF&)
/usr/include/qt4/QtCore/qsize.h:361: note: QDebug operator<<(QDebug, const QSizeF&)
/usr/include/qt4/QtCore/qpoint.h:103: note: QDataStream& operator<<(QDataStream&, const QPoint&)
/usr/include/qt4/QtCore/qpoint.h:181: note: QDebug operator<<(QDebug, const QPoint&)
/usr/include/qt4/QtCore/qpoint.h:237: note: QDataStream& operator<<(QDataStream&, const QPointF&)
/usr/include/qt4/QtCore/qpoint.h:356: note: QDebug operator<<(QDebug, const QPointF&)
/usr/include/qt4/QtGui/qcolor.h:60: note: QDe...

Argh, sorry everyone; I had uploaded a new release with the patch applied upstream (or so it seemed - I did do a review of the delta..), but now we get a different-but-related FTBFS. Sorry about the regression; alas I don't know enough Qt or C++ or ARM architecture to know how to patch this.

http://launchpadlibrarian.net/56993923/buildlog_ubuntu-maverick-armel.musescore_0.9.6.3%2Bdfsg-0ubuntu1_FAILEDTOBUILD.txt.gz

This bug was fixed in the package musescore - 0.9.6.3+dfsg-0ubuntu2

---------------
musescore (0.9.6.3+dfsg-0ubuntu2) maverick; urgency=low

  * More armel qreal fixes. LP: #642117.
 -- Matthias Klose <email address hidden> Mon, 04 Oct 2010 14:10:54 +0200