does not work with firmware-tools

Bug #602496 reported by Anand Kumria
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
firmware-addon-dell (Ubuntu)
Fix Released
Undecided
Unassigned
Lucid
Fix Released
Medium
Unassigned

Bug Description

SRU
====

Impact:
The package is completely unusable on Lucid, as the default python version is 2.6, and this package only ships libaries in the 2.5 site-packages.

Solution:
The root cause is that dh_pysupport is never called. This patch calls it during the build, which results in a Python version-independant package.

Reproduction Instructions:
1. Install firmware-addon-dell and firmware-tools.
2. Run inventory_firmware
3. Note error: Config Error: Plugin "firmware_addon_dell.dellbios" cannot be loaded: No module named firmware_addon_dell.dellbios

Regression potential:
None I can see.

Original Report:
============

Binary package hint: firmware-addon-dell

The package contains a Python module with is, unfortunately, hardcoded -- not for any particular reason -- to use Python 2.5

kalki:[~]% dpkg -L firmware-addon-dell
/.
/etc
/etc/yum
/etc/yum/pluginconf.d
/etc/yum/pluginconf.d/dellsysidplugin.conf
/etc/firmware
/etc/firmware/firmware.d
/etc/firmware/firmware.d/firmware-addon-dell.conf
[...]
/usr/lib/python2.5
/usr/lib/python2.5/site-packages
/usr/lib/python2.5/site-packages/firmware_addon_dell
/usr/lib/python2.5/site-packages/firmware_addon_dell/__init__.py
/usr/lib/python2.5/site-packages/firmware_addon_dell/biosHdr.py
/usr/lib/python2.5/site-packages/firmware_addon_dell/dellbios.py
/usr/lib/python2.5/site-packages/firmware_addon_dell/extract_bios.py
/usr/lib/python2.5/site-packages/firmware_addon_dell/extract_bios_blacklist.py
/usr/lib/python2.5/site-packages/firmware_addon_dell/extract_common.py
/usr/lib/python2.5/site-packages/firmware_addon_dell/HelperXml.py
/usr/lib/python2.5/site-packages/firmware_addon_dell/__init__.pyc
/usr/lib/python2.5/site-packages/firmware_addon_dell/biosHdr.pyc
/usr/lib/python2.5/site-packages/firmware_addon_dell/dellbios.pyc
/usr/lib/python2.5/site-packages/firmware_addon_dell/extract_bios.pyc
/usr/lib/python2.5/site-packages/firmware_addon_dell/extract_bios_blacklist.pyc
/usr/lib/python2.5/site-packages/firmware_addon_dell/extract_common.pyc
/usr/lib/python2.5/site-packages/firmware_addon_dell/HelperXml.pyc
/usr/lib/python2.5/site-packages/firmware_addon_dell/__init__.pyo
/usr/lib/python2.5/site-packages/firmware_addon_dell/biosHdr.pyo
/usr/lib/python2.5/site-packages/firmware_addon_dell/dellbios.pyo
/usr/lib/python2.5/site-packages/firmware_addon_dell/extract_bios.pyo
/usr/lib/python2.5/site-packages/firmware_addon_dell/extract_bios_blacklist.pyo
/usr/lib/python2.5/site-packages/firmware_addon_dell/extract_common.pyo
/usr/lib/python2.5/site-packages/firmware_addon_dell/HelperXml.pyo
[...]

It should be using either pycentral or pyshared (or similiar) so that it can adapt to the system python version (which on Ubuntu 10.04 is Python 2.6).

ProblemType: Bug
DistroRelease: Ubuntu 10.04
Package: firmware-addon-dell 2.1.0-0ubuntu2
ProcVersionSignature: Ubuntu 2.6.32-22.36-generic 2.6.32.11+drm33.2
Uname: Linux 2.6.32-22-generic x86_64
NonfreeKernelModules: wl
Architecture: amd64
Date: Wed Jul 7 00:57:16 2010
InstallationMedia: Ubuntu 10.04 LTS "Lucid Lynx" - Release amd64 (20100429)
PackageArchitecture: all
ProcEnviron:
 PATH=(custom, user)
 LANG=en_AU.utf8
 SHELL=/bin/zsh
SourcePackage: firmware-addon-dell

Revision history for this message
Anand Kumria (wildfire) wrote :
Changed in firmware-addon-dell (Ubuntu):
assignee: nobody → Stefano Rivera (stefanor)
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package firmware-addon-dell - 2.2.9-0ubuntu1

---------------
firmware-addon-dell (2.2.9-0ubuntu1) maverick; urgency=low

  [ Bhavani Shankar ]
  * New upstream release LP: #414247
  * debian/control:
    - Bump up Standards-Version to 3.9.0
      + remove linda override file
    - Remove Homepage link from package description
    - Bump up debhelper dependency to >= 5.0.38 as per policy
    - Add ${misc:Depends} macro to Depends field
  * debian/rules:
    - No longer install the linda override file we removed.
    - Remove get-orig-source, we are using releases again.
  * Remove debian/install file and doc/debian.in directory as it
    is used for building firmware packages, not installing them.

  [ Artur Rona ]
  * Switch to dpkg-source 3.0 (quilt) format.

  [ Stefano Rivera ]
  * Remove debian/pycompat, unnecessary.
  * debian/rules:
    - Removed remaining get-orig-source support code.
    - Switched from autotools.mk to python-autotools.mk (LP: #602496)
  * debian/control:
    - Moved firmware-tools dependency from Python-Depends to Depends
      (LP: #200956)
    - Bumped cdbs build dependency to 0.4.72 for python-autotools.mk
  * Added README.Debian
 -- Bhavani Shankar <email address hidden> Thu, 08 Jul 2010 09:54:19 +0530

Changed in firmware-addon-dell (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Stefano Rivera (stefanor) wrote :

SRU Patch

Changed in firmware-addon-dell (Ubuntu Lucid):
importance: Undecided → Medium
status: New → Confirmed
description: updated
tags: added: verification-needed
Changed in firmware-addon-dell (Ubuntu):
assignee: Stefano Rivera (stefanor) → nobody
Revision history for this message
John Dong (jdong) wrote :

ACK for SRU

Revision history for this message
Jerry Ablan (lucifurious) wrote :

How does one download and/or install this patch (from the diff)?

Revision history for this message
Stefano Rivera (stefanor) wrote :

Jerry: You need to apply that patch to the current Lucid source package and bulid it (on lucid). I've uploaded it to my ppa if that's any help: https://launchpad.net/~stefanor/+archive/ppa

I've uploaded this to lucid-proposed, but it's still awaiting Archive Admin approval, so you can't get it via normal channels yet.

Revision history for this message
Jonathan Riddell (jr) wrote : Please test proposed package

Accepted into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in firmware-addon-dell (Ubuntu Lucid):
status: Confirmed → Fix Committed
Revision history for this message
Stefano Rivera (stefanor) wrote :

SRU package works for me.

Martin Pitt (pitti)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package firmware-addon-dell - 2.1.0-0ubuntu2.10.04.1

---------------
firmware-addon-dell (2.1.0-0ubuntu2.10.04.1) lucid-proposed; urgency=low

  * Call dh_pysupport to correctly install version-independent python
    code (LP: #602496) and generate python dependencies (LP: #200956)
 -- Stefano Rivera <email address hidden> Sat, 10 Jul 2010 19:52:09 +0200

Changed in firmware-addon-dell (Ubuntu Lucid):
status: Fix Committed → Fix Released
Revision history for this message
Martin (ub71-martin) wrote :

I am sorry but I don't see it as fixed, I still have this exact problem on my Lucid 10.04.3

# dpkg -l | grep firmware-addon
ii firmware-addon-dell 2.1.0-0ubuntu2 A firmware-tools plugin to handle BIOS/Firmw

is the new fixed package mentionned commited in the repository ?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.