Motion extension ignores 'z' segments

another example (Inkscape 0.47+devel r9210 on OS X 10.5.8)

difference win32 / osx of character 'A' (font: Arial) converted to path

Quick patch that causes simplepath.py to append the last 'L' segment when parsing paths.

Oops - this patch breaks the dots.py extension (Number Nodes).

Per IRC discussion, some quick fixes for the dots.py script:
 - fix division by zero
 - remove extra node at start/end
 - option to preserve path
 - starting circle slightly larger than the rest

This patch depends on the one above - without it, linear shapes will be missing the circle marker for the penultimate node.

Inkscape 0.47+devel r9456 including the three patches
- bug #202540: <http://launchpadlibrarian.net/49235570/csp_03.patch>
- bug #542260: <http://launchpadlibrarian.net/49237636/simplepath_z_fix_01.patch>
- bug #542260: <http://launchpadlibrarian.net/49242371/dots_01.patch>
(tested both with personal and default preferences file)

1) 'Motion' now honors a closing 'z' segment, but creates a 'null' face for the closing 'z' of a curved path (see 3).

2) 'Number Nodes…' works as expected with paths like
- rectangle/star/polygon converted to path
- path closing with a straight line segment (pen tool / node tool)

3) 'Number Nodes…' adds an extra point when numbering closed paths like
- ellipse/circle converted to path
- star/polygon with rounded corners converted to path
- closed curve drawn with pencil tool
- path closing with a curved segment (pen tool / node tool)

Because now coinciding start and end nodes are not longer rendered offset but on top of each other, it can be difficult to notice that 'Number Nodes…' counts one more node than is displayed in the status line message about the selected path.

I haven't tested other extensions which are importing cubicsuperpath.py and and simplepath.py.

further notes to my previous comment:

ad 2): this has changed since 0.47: revision 9076 and 9079 added 'prevent a redundant closing line segment' when converting a rectangle, star or polygon to path and when creating a path with the pen (bezier) tool.

ad 3): this is the same behavior of the 'Number Nodes…' extension as previously in 0.47: all paths listed in 2) have numbers for both (coinciding) first and last nodes.

Actually the number of nodes in a 'closed' path is ambiguous because the last redundant node is hidden from the user (e.g. in the node tool or in the status line messages) if it coincides with the first node and a 'z' command closes the path.

regression with sub-paths ('Motion' in Inkscape r9456+patches, Python 2.6.2)

On Fri, May 28, 2010 at 7:27 AM, ~suv <email address hidden> wrote:
> further notes to my previous comment:

Thanks for taking the time to comment on these.

> ad 2): this has changed since 0.47: revision 9076 and 9079 added
> 'prevent a redundant closing line segment' when converting a rectangle,
> star or polygon to path and when creating a path with the pen (bezier)
> tool.

Yes - I think that this change in Inkscape is the reason that some
extensions are having problems now. Most of what I've noticed
(fractalize, motion) stems from simplepath.py not being aware of the
closing 'Z'. You sent me that regression svg of sub-paths also - I'll
take a look into it.

> ad 3): this is the same behavior of the 'Number Nodes…' extension as
> previously in 0.47: all paths listed in 2) have numbers for both
> (coinciding) first and last nodes.

Interesting. I'll look into this as well.

Today is going to be a hectic one for me, but I will try and pin these
items down over the weekend.

Thanks,
Chris

This issue has been resolved in Inkscape 1.2 by MR https://gitlab.com/inkscape/extensions/-/merge_requests/317.

Closed by: https://gitlab.com/jhofinger