kubuntu ubiquity shows ${RELEASE} briefly at start

Bug #540202 reported by Jonathan Riddell
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubiquity (Ubuntu)
Fix Released
Undecided
Unassigned
Lucid
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: ubiquity

When starting Kubuntu Ubiquity ${RELEASE} is shown in the text on the first page for a couple of seconds before being replaced by the release number. This is ugly.

Tags: kubuntu

Related branches

Jonathan Riddell (jr)
Changed in ubiquity (Ubuntu):
milestone: none → ubuntu-10.04-beta-2
Changed in ubiquity (Ubuntu Lucid):
status: New → Confirmed
Revision history for this message
Jonathan Riddell (jr) wrote :

=== modified file 'ubiquity/components/ubi-language.py'
--- ubiquity/components/ubi-language.py 2010-03-30 16:15:19 +0000
+++ ubiquity/components/ubi-language.py 2010-04-01 01:06:42 +0000
@@ -320,6 +320,15 @@
                 self.page.try_text_label.hide()
                 self.page.begin_install_button.hide()

+ # We do not want to show the yet to be substituted strings
+ # (${MEDIUM}, etc), so don't show the core of the page until
+ # it's ready.
+ self.widgetHidden = {}
+ for w in self.page.children():
+ if isinstance(w, QWidget):
+ self.widgetHidden[w] = w.isHidden()
+ w.hide()
+
         except Exception, e:
             self.debug('Could not create language page: %s', e)
             self.page = None
@@ -338,6 +347,7 @@
     def set_alpha_warning(self, show):
         if not show and not self.only:
             self.page.alpha_warning_label.hide()
+ self.widgetHidden[self.page.alpha_warning_label] = True

     def on_release_notes_link(self, link):
         lang = self.selected_language()
@@ -411,6 +421,11 @@
                 text = text.replace('${RELEASE}', release_name)
                 text = text.replace('${MEDIUM}', install_medium)
                 widget.setText(text)
+ from PyQt4.QtGui import QWidget
+ for w in self.page.children():
+ if isinstance(w, QWidget):
+ if not self.widgetHidden[w]:
+ w.show()

     def set_oem_id(self, text):
         return self.page.oem_id_entry.setText(text)

Revision history for this message
Jonathan Riddell (jr) wrote :

The GTK side has a loop which hides all children then shows them after translation. I don't understand why this doen't show the widgets which aren't wanted (such as the alpha warning). Patch above saves the state of each widget and shows it if it was shown before, this assumes the state is correct at the time of saving which I'm not convinced about (it isn't for alpha_warning so an extra save added in there).

Changed in ubiquity (Ubuntu Lucid):
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubiquity - 2.2.13

---------------
ubiquity (2.2.13) lucid; urgency=low

  [ Evan Dandrea ]
  * In oem-config, support removing packages that were not part of the
    base install and are not needed in the final system by preseeding
    oem-config/remove_extras to true (LP: #315644, LP: #553184).

  [ Roman Shtylman ]
  * Kde_ui:
    - fixed (LP: #550466) (LP: #550472) using kmessage box for quit dialog
    - fixed (LP: #540202) hide widgets until translated
 -- Mario Limonciello <email address hidden> Thu, 01 Apr 2010 11:51:01 -0500

Changed in ubiquity (Ubuntu Lucid):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.