Disable Trash/Delete bindings when appropriate

Bug #490512 reported by Michael Terry
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Nautilus
Fix Released
Low
nautilus (Ubuntu)
Fix Released
Low
Sebastien Bacher

Bug Description

Binary package hint: nautilus

When the user cannot delete the selected files, the Trash/Delete menu items are disabled. But the corresponding key bindings are not. As a result, a user pressing Delete on a file will get a series of errors (trash attempt errors out, then delete attempt errors out). But we know in advance that these errors will occur and should disable the keybinding (like all other menu items do when they are disabled).

Note that <shift>Delete is already correctly handled for Edit->Delete. This bug is just about Delete, KP_Delete, and <shift>KP_Delete.

To reproduce, just try to trash a file in a directory where you don't have permissions to add/delete files.

Tags: oem-services

Related branches

Revision history for this message
Michael Terry (mterry) wrote :

The version in this debdiff is likely to change (I know karmic already has an ubuntu3 in -proposed -- aren't you supposed to use 1.2 for that sort of thing?). But the patch is sound and will likely apply to a future 2.29.x update. Patch is the same as the one I attached to upstream bug.

Changed in nautilus (Ubuntu):
assignee: nobody → Canonical Desktop Team (canonical-desktop-team)
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your work there

> (I know karmic already has an ubuntu3 in -proposed -- aren't you supposed to use 1.2 for that sort of thing?)

not really, we are supposed to use any number not used yet and lower than what will go in lucid

Changed in nautilus (Ubuntu):
importance: Undecided → Low
status: New → Triaged
assignee: Canonical Desktop Team (canonical-desktop-team) → Sebastien Bacher (seb128)
Revision history for this message
Sebastien Bacher (seb128) wrote :

I've pinged alex on IRC for patch review now

Changed in nautilus (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (5.0 KiB)

This bug was fixed in the package nautilus - 1:2.28.3-0ubuntu1

---------------
nautilus (1:2.28.3-0ubuntu1) lucid; urgency=low

  * New upstream version:
    - Fix memory leaks
    - Don't rewrite bookmars unnecessary on startup
    - Fix background "darkness" detection for font color (lp: #356289)
    - Disable trash/delete key shortcuts when menu items disabled
      (lp: #490512)
  * Sync on Debian
  * debian/control.in:
    - Build-Depends on liblaunchpad-integration-dev
    - change recommends on cd burners to a suggests
    - change gksu conflicts version to match the ubuntu transition
    - don't build using beagle and tracker
    - don't recommends desktop-base, don't suggests tracker
    - nautilus Suggests gnome-app-install rather than synaptic
    - set vcs url
  * debian/mount-archive.desktop,
    debian/mount-archive.desktop.in,
    debian/nautilus.install:
    - new nautilus context menu item to allow mounting zip, iso, etc
  * debian/nautilus-data.gconf-schemas:
    - change the default desktop configuration, default to browser,
      don't change autorun option to not ask what to do
  * debian/nautilus-data.install, debian/source_nautilus.py:
    - apport hook to list versions of files in /usr/lib/nautilus and reassign
      the crashes when there are not due to nautilus code directly
  * debian/patches/01_lpi.patch:
    - launchpad changes.
  * debian/patches/03_menu_entry.patch:
    - change the menu item category.
  * debian/patches/15_translations_list_update.patch:
    - list the new desktop as translatable
  * debian/patches/18_signal_curtain.patch:
    - signal the curtain when loaded
    - update by Erez Volk to fix a warning (lp: #454234)
  * debian/patches/20_open-with_install.patch:
    - don't use that debian change but rather gnome-app-install
  * debian/patches/80_suppress_umount_in_ltsp.patch:
    - don't list unmount and eject actions on ltsp clients
  * debian/patches/82_gnome-app-install.patch:
    - Invoke gnome-app-install when no application known for file.
  * debian/patches/95_no-initial-fade.patch: Patch to disable the initial
    fade-in of the background without disabling crossfades when the
    background is changed.
  * debian/rules:
    - don't use debian translation hack
    - update shlib version
  * debian/watch:
    - watch unstable serie

nautilus (2.28.1-1) unstable; urgency=low

  [ Josselin Mouette ]
  * Drop gnome-mount recommends, it’s already pulled by gvfs if needed
    (i.e. for gvfs builds that use HAL).

  [ Andrea Veri ]
  * New upstream release.
  * debian/control:
    - bumped standards-version to 3.8.3. No changes needed.
    - bumped libtrackerclient-dev to >= 0.6.6 (lenny version),
      to start up nautilus porting to tracker 0.7. Thanks mbiebl
      for the hint.
    - added missing ${misc:Depends} to both nautilus-dbg and
      libnautilus-extension-dev making lintian stop complaining.

  [ Josselin Mouette ]
  * nautilus-data.gconf-defaults: set exit_with_last_window to false so
    that nautilus doesn’t go in a loop when show_desktop = false.
  * 13_autostart.patch: removed, it is no longer necessary.
    + Automount works even when show_desktop = false. Closes: #538108.
...

Read more...

Changed in nautilus (Ubuntu):
status: Fix Committed → Fix Released
Changed in nautilus:
importance: Unknown → Low
status: Unknown → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.