port GNOME frontend to GtkAssistant

Bug #415038 reported by Jani Monoses
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Baltix
New
Undecided
Unassigned
debconf (Debian)
Fix Released
Unknown
debconf (Ubuntu)
Fix Released
Medium
Colin Watson

Bug Description

Binary package hint: debconf

switching from GnomeDruid to GtkAssistant would allow droppingl libgnome2-perl (and its deps libgnome2-vfs-perl and libgnome2-canvas-perl) from ubuntu-desktop and the CD.

Revision history for this message
Jani Monoses (jani) wrote :

With this patch against current Gnome.pm it works, but needs more testing and review.
Not sure how to test progress windows (what package uses those?), and how to deal with button sensitivity which was available in Druid but not quite the same in GA.
The goback(0/1) logic is also something I did not fully understand.

Revision history for this message
Jani Monoses (jani) wrote :

this applies cleanly to karmic

Changed in debconf (Debian):
status: Unknown → New
tags: added: patch
tags: added: patch-forwarded-debian
removed: patch
Revision history for this message
Mantas Kriaučiūnas (mantas) wrote :

Any chances to accept switching from GnomeDruid to GtkAssistant patch in Ubuntu 11.04 "Natty" release?
Btw, it would be wise if Debconf frontend would be set to Gnome in Ubuntu and to Kde in Kubuntu, see bug #372117 - maybe that bug could be fixed together with this bug?

When I install or just run dpkg-reconfigure some-package in Ubuntu 10.04 GNOME desktop I get questions asked in terminal instead of user-friendly graphical window :(

Revision history for this message
Jani Monoses (jani) wrote : Re: [Bug 415038] Re: port GNOME frontend to GtkAssistant

Mantas, the associated Debian bug may be a better place to ask.

On Mon, Oct 4, 2010 at 1:23 PM, Mantas Kriaučiūnas <email address hidden> wrote:

> Any chances to accept switching from GnomeDruid to GtkAssistant patch in
> Ubuntu 11.04 "Natty" release?
> Btw, it would be wise if Debconf frontend would be set to Gnome in Ubuntu
> and to Kde in Kubuntu, see bug #372117 - maybe that bug could be fixed
> together with this bug?
>
> When I install or just run dpkg-reconfigure some-package in Ubuntu 10.04
> GNOME desktop I get questions asked in terminal instead of user-friendly
> graphical window :(
>
> --
> port GNOME frontend to GtkAssistant
> https://bugs.launchpad.net/bugs/415038
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in “debconf” package in Ubuntu: New
> Status in Baltix GNU/Linux: New
> Status in “debconf” package in Debian: New
>
> Bug description:
> Binary package hint: debconf
>
> switching from GnomeDruid to GtkAssistant would allow droppingl
> libgnome2-perl (and its deps libgnome2-vfs-perl and libgnome2-canvas-perl)
> from ubuntu-desktop and the CD.
>
> To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/ubuntu/+source/debconf/+bug/415038/+subscribe
>

Revision history for this message
Colin Watson (cjwatson) wrote :

I'll try to find some time to have a look at this upstream.

Changed in debconf (Ubuntu):
assignee: nobody → Colin Watson (cjwatson)
importance: Undecided → Medium
status: New → Triaged
tags: added: gnome3-cleaning
Revision history for this message
Martin Pitt (pitti) wrote :

Thanks Jani for the original patch!

This broke on progress bars and cases where no question was shown (it just answered with "30 backup" there).

While I was at it, I also fixed the "hide cancel button" to actually work. That's something that is broken in the current gnome debconf as well.

I tested this with the included demo:

  DEBIAN_FRONTEND=gnome DEBCONF_DEBUG=developer PERL5LIB=. samples/demo

and with a noninteractive dialog

  sudo DEBIAN_FRONTEND=gnome DEBCONF_DEBUG=developer PERL5LIB=`pwd` dpkg-reconfigure -phigh man-db

and with an intearctive dialog

  sudo DEBIAN_FRONTEND=gnome DEBCONF_DEBUG=developer PERL5LIB=`pwd` apt-get install xdm

both from the local build tree (thus using PERL5LIB) as well as with built .debs. All cases now work for me and behave identical to the current Gnome2 version (except that the Cancel button is now hidden).

Revision history for this message
Martin Pitt (pitti) wrote :

For the record, I also tested this with synaptics, works fine. I can't get either the old nor the new version to work with software-center, so I think that's a bug in the aptdaemon debconf integration.

Revision history for this message
Colin Watson (cjwatson) wrote :

This is doing something very weird on backup. I need to investigate further before applying this.

Revision history for this message
Colin Watson (cjwatson) wrote :

In particular, the sequence Forward Back Forward Forward in samples/demo displays entirely the wrong question.

Revision history for this message
Colin Watson (cjwatson) wrote :

Oh, and why is backup permitted while running samples/demo at all? That doesn't run db_capb backup!

Revision history for this message
Colin Watson (cjwatson) wrote :

I've fixed the problem with backup being permitted. Other bugs I'm currently working on:

  * The sequencing bug identified in comment #9, which I think is because the frontend creates a *new* page when backing up.
  * Progress bars don't seem to be working right.

I'll upload when I'm happy with it. :-)

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package debconf - 1.5.36ubuntu3

---------------
debconf (1.5.36ubuntu3) natty; urgency=low

  [ Martin Pitt ]
  * Debconf/FrontEnd/Gnome.pm: Port from Gnome2::Druid to Gtk2::Assistant.
    Original patch by Jani Monoses, thanks! (LP: #415038)
  * Debconf/Element/Gnome/Select.pm: Drop unused Gnome2 import.
  * debian/control: Change libgnome2-perl suggestion to libgtk2-perl
    accordingly.

  [ Colin Watson ]
  * Fix Gnome frontend to honour backup capability again, and make backup
    page handling work properly.
  * Version libgtk2-perl Suggests to match the upstream version where
    Gtk2::Assistant was introduced.
  * Convert from deprecated Gtk2::Combo to Gtk2::ComboBox.
  * Make sure you can't press Forward on a progress bar in the Gnome
    frontend.
  * Backport from trunk:
    - Correctly handle disabling the backup capability in a confmodule after
      it was previously enabled.
 -- Colin Watson <email address hidden> Fri, 17 Dec 2010 13:47:36 +0000

Changed in debconf (Ubuntu):
status: Triaged → Fix Released
Changed in debconf (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.