Samsung Q210: Fn-Down and Fn-Up are not generating release keys events

Bug #385683 reported by Michał Kaczmarek
24
This bug affects 3 people
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Invalid
Medium
Unassigned
Karmic
Fix Released
Medium
Keng-Yu Lin

Bug Description

When my Samsung Q210 is started, pressing Fn-Down (brightness down) or Fn-Up (brightness up) generates key press event, but do not generate key release. As a result the only thing I can do is to switch to a text console and then switch back. Suprisingly after switching back, the Fn-Down and Fn-Up do work correctly! This problem is 100% reproducible after every reboot.

Note: Following hint in some similar bug description, I have enabled -proposed updates. Now the Down and Up keys (in Firefox, Gnome-Terminal, oowriter) no longer work, although they do work in the Gnome menu. I attach additional xev.log file in which I show that Left and Right are working correctly, while Down and Up are not.

ProblemType: Bug
Architecture: i386
DistroRelease: Ubuntu 9.04
HibernationDevice: RESUME=UUID=f3caa690-7b9e-4b5d-8c1b-f6dc951194aa
MachineType: SAMSUNG ELECTRONICS CO., LTD. Q210/P210
Package: linux-image-2.6.28-13-generic 2.6.28-13.44
ProcCmdLine: root=UUID=e7bc164c-bcd2-4706-8532-86126e6340d6 ro quiet splash
ProcEnviron:
 LANG=pl_PL.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.28-13.44-generic
SourcePackage: linux
UnreportableReason: To nie jest oryginalny pakiet Ubuntu

Revision history for this message
Michał Kaczmarek (ltdunbar) wrote :
Revision history for this message
Michał Kaczmarek (ltdunbar) wrote :
Revision history for this message
Michał Kaczmarek (ltdunbar) wrote :
Revision history for this message
zl0i (sancheolz) wrote :

I have the same problem on my samsung r60+. I`ve found a solution: you must patch a kernel to fix it. I`ve remade patch to your`s model (see attachement). Can you try it?

Revision history for this message
Michał Kaczmarek (ltdunbar) wrote :

It did not work directly for me, because my kernel sources (default Ubuntu kernel sources) do not have the following symbols defined:

atkbd_setup_forced_release,
atkbd_samsung_forced_release_keys,

However since I replaced these entries with the same entries which were used for Samsung NC10 (I do not have my Linux at hand now, so cannot write them here), it works fine now. Thanks!

Revision history for this message
AlfredNoble (a-nobel) wrote :

Hi, I have the same problem, but with model R510-FS0K. Kernel version is last. Can you help me?

Revision history for this message
zl0i (sancheolz) wrote :

Yes, I do. If your R510-FS0K has set of fn keys like this: f2 - battery, f3 - euro, f4 - toggle display, f5 - backlight on/off, f6 - mute, f7 - magic doctor, f8 - frequency scaling, f9 - on/off wifi, f10 - tachpad on/off, f11 - numlock, f12 - scroll lock; then you can apply q210 patch with small modification. You just need to replace model in:
DMI_MATCH(DMI_PRODUCT_NAME, "Q210/P210"),
by model from output after this command:
lshal |grep system.hardware.product.
And of cause apply patch to kernel.
if set of keys is not identical - I can explain how to make patch in this case, just ask.

Revision history for this message
AlfredNoble (a-nobel) wrote :

one

Revision history for this message
AlfredNoble (a-nobel) wrote :

so, ya ponyal) thanx. tell me about patching please. I realized that it is a C code. Where is ATKBD file and what i should do?f

Keng-Yu Lin (lexical)
Changed in linux (Ubuntu):
importance: Undecided → Medium
status: New → Confirmed
Keng-Yu Lin (lexical)
Changed in linux (Ubuntu):
assignee: nobody → Keng-Yü Lin (lexical)
Revision history for this message
Keng-Yu Lin (lexical) wrote :
Changed in linux (Ubuntu):
status: Confirmed → Incomplete
Revision history for this message
Michał Kaczmarek (ltdunbar) wrote :

I am sorry it took so long. I confirm: brightness controls work correctly with your linux-image.

Keng-Yu Lin (lexical)
Changed in linux (Ubuntu):
status: Incomplete → In Progress
Keng-Yu Lin (lexical)
Changed in linux (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Keng-Yu Lin (lexical) wrote :

I set the status to "triaged" as this patch will be pulled into karmic soon but not yet committed.

Changed in linux (Ubuntu):
status: Fix Committed → Triaged
status: Triaged → Incomplete
Keng-Yu Lin (lexical)
Changed in linux (Ubuntu):
status: Incomplete → Invalid
Revision history for this message
kieron_a_m (kieron-a-m) wrote :

I am having the exact same problem as Michał Kaczmarek (above) on my Samsung R60+ laptop. Whenever I change the monitor brightness using the Fn key + up or down, there is no key release generated, which causes most of the OS functions to hang as it thinks there is a key being held down. However as I am new to Ubuntu I am not fully aware of how to apply the above patch - could someone help? Thanks

Revision history for this message
Jeremy Foshee (jeremyfoshee) wrote :

Changed to Fix Committed, but then set to In Progress until the fix from Keng-Yü Lin can be verified as Committed.

-JFo

Changed in linux (Ubuntu):
status: Invalid → Fix Committed
status: Fix Committed → In Progress
Revision history for this message
Stefan Bader (smb) wrote :

Accepted linux into karmic-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in linux (Ubuntu Karmic):
assignee: nobody → Keng-Yü Lin (lexical)
importance: Undecided → Medium
status: New → Fix Committed
Changed in linux (Ubuntu):
assignee: Keng-Yü Lin (lexical) → nobody
status: In Progress → Invalid
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (24.5 KiB)

This bug was fixed in the package linux - 2.6.31-20.57

---------------
linux (2.6.31-20.57) karmic-proposed; urgency=low

  [ Kees Cook ]

  * SAUCE: x86: brk away from exec rand area
    - LP: #452175

  [ Keng-Yu Lin ]

  * SAUCE: (drop after 2.6.31) input: Add hotkey quirk for Samsung
    Q210/P210 laptops
    - LP: #385683

  [ Pascal Bach ]

  * SAUCE: (drop after 2.6.31) input: Add hotkey quirk for Fujitsu Amilo
    1848+u
    - LP: #458503

  [ Stefan Bader ]

  * Revert "[Upstream] (drop after 2.6.31) acerhdf: fix fan control for
    AOA150 model"
    - LP: #494633
  * [Config] Disable CONFIG_USB_DEVICEFS
    - LP: #488274

  [ Upstream Kernel Changes ]

  * Revert "ext4: Don't update superblock write time when filesystem is
    read-only"
    - LP: #496816
  * Revert "ide: try to use PIO Mode 0 during probe if possible"
    - LP: #503430
  * Revert "isdn: isdn_ppp: Use SKB list facilities instead of home-grown
    implementation."
    - LP: #503430
  * nilfs2: fix kernel oops in error case of nilfs_ioctl_move_blocks
    - LP: #494633
  * cifs: don't use CIFSGetSrvInodeNumber in is_path_accessible
    - LP: #494633
  * cifs: clean up handling when server doesn't consistently support inode
    numbers
    - LP: #494633
  * cifs: clear server inode number flag while autodisabling
    - LP: #494633
  * CIFS: fix oops in cifs_lookup during net boot
    - LP: #494633
  * CIFS: Duplicate data on appending to some Samba servers
    - LP: #494633
  * rtl8187: Fix kernel oops when device is removed when LEDS enabled
    - LP: #494633
  * md: don't clear endpoint for resync when resync is interrupted.
    - LP: #494633
  * md/raid5: make sure curr_sync_completes is uptodate when reshape starts
    - LP: #494633
  * md/raid1/raid10: add a cond_resched
    - LP: #494633
  * ALSA: usb-audio: fix combine_word problem
    - LP: #494633
  * ALSA: hda - Dell Studio 1557 hd-audio quirk
    - LP: #494633
  * ALSA: AACI: fix AC97 multiple-open bug
    - LP: #494633
  * ALSA: AACI: fix recording bug
    - LP: #494633
  * jffs2: Fix memory corruption in jffs2_read_inode_range()
    - LP: #494633
  * sound: rawmidi: disable active-sensing-on-close by default
    - LP: #494633
  * sound: rawmidi: fix checking of O_APPEND when opening MIDI device
    - LP: #494633
  * sound: rawmidi: fix double init when opening MIDI device with O_APPEND
    - LP: #494633
  * sound: rawmidi: fix MIDI device O_APPEND error handling
    - LP: #494633
  * highmem: Fix race in debug_kmap_atomic() which could cause warn_count
    to underflow
    - LP: #494633
  * highmem: Fix debug_kmap_atomic() to also handle KM_IRQ_PTE, KM_NMI, and
    KM_NMI_PTE
    - LP: #494633
  * powerpc: Fix DEBUG_HIGHMEM build break from d4515646699
    - LP: #494633
  * kmap: fix build errors with DEBUG_HIGHMEM enabled
    - LP: #494633
  * V4L/DVB (13169): bttv: Fix potential out-of-order field processing
    - LP: #494633
  * V4L/DVB (13170): bttv: Fix reversed polarity error when switching video
    standard
    - LP: #494633
  * V4L/DVB (13109): tda18271: fix signedness issue in
    tda18271_rf_tracking_filters_init
    - LP: #494633
  * V4L/DVB (13107): tda18271: fix overflow in FM radio frequency...

Changed in linux (Ubuntu Karmic):
status: Fix Committed → Fix Released
Revision history for this message
Jeremy Foshee (jeremyfoshee) wrote :

Please test per the above from Stefan so that we can see that the patch solves this particular issue.

Thanks!

~JFo

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.