Branch mail not converting diff to unicode
Bug #371469 reported by
Jonathan Lange
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Aaron Bentley | ||
Bug Description
We regularly get OOPS reports saying:
UnicodeDecode
The reports themselves provide little in the way of information, save that the error is in:
Module canonical.
contents = "%s\\n%s" % (self.contents, self.diff)
See OOPS-1219BM1, OOPS-1219BM2, OOPS-1219BM3, OOPS-1219BM4, OOPS-1219BM5
Related branches
lp:~abentley/launchpad/diff-attachment
- Tim Penhey (community): Approve
- Canonical Launchpad Engineering: Pending requested
- Diff: None lines
Revision history for this message
| Aaron Bentley (abentley) wrote | #1 |
| summary: |
- Branch mail mishandling unicode + Branch mail not converting diff to unicode |
| Changed in launchpad-code: | |
| assignee: | nobody → Aaron Bentley (abentley) |
| status: | Triaged → In Progress |
| Changed in launchpad-code: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Savvas Radevic (medigeek) wrote | #2 |
Revision history for this message
| Aaron Bentley (abentley) wrote | #3 |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Since diffs are binary and text is unicode, diffs must be converted to unicode before being combined with the message body.
This problem could also be solved by providing diffs as attachments, which would fix bug 297716 . It would also avoid having to guess the encoding of the diff (if there even is a single encoding).