Attach the diff to branch revision notifications

Bug #297716 reported by Björn Tillenius
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Aaron Bentley

Bug Description

If I subscribe to branch revision notifications, I get a main including information about the commit and the diff. This is great. However, the diff is simply appended to the body, after the revision information, which can be fairly long.

Please add the diff as an attachment to the mail, so that it's easier to look at it, and also save it to a file if needed, or pipie it to 'bzr patch'.

Tags: email lp-code

Related branches

Jonathan Lange (jml)
Changed in launchpad-bazaar:
importance: Undecided → High
status: New → Triaged
Aaron Bentley (abentley)
Changed in launchpad-code:
assignee: nobody → Aaron Bentley (abentley)
status: Triaged → In Progress
Revision history for this message
Matt Nordhoff (mnordhoff) wrote :

As a lazy person with an unintelligent mail client, I never open attachments unless I really need to. I like inline diffs.

OK, so this is entirely my problem, but still.

Revision history for this message
Aaron Bentley (abentley) wrote : Re: [Bug 297716] Re: Attach the diff to branch revision notifications

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Matt Nordhoff wrote:
> As a lazy person with an unintelligent mail client, I never open
> attachments unless I really need to. I like inline diffs.
>
> OK, so this is entirely my problem, but still.

You don't need to open the attachments in most mail clients, because
they are attached with content-disposition inline, so they will show
below the main message.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpSp3gACgkQ0F+nu1YWqI3SxwCfZ/iRHsTc5lMPZk/EnkDqtIn7
pqQAoIT07PlI610mP4TNDsungiuSlQhw
=/rF9
-----END PGP SIGNATURE-----

Revision history for this message
Martin Albisetti (beuno) wrote :

On Mon, Jul 6, 2009 at 10:40 PM, Aaron Bentley<email address hidden> wrote:
> You don't need to open the attachments in most mail clients, because
> they are attached with content-disposition inline, so they will show
> below the main message.

Not on gmail with the way they're encoded.

Revision history for this message
Aaron Bentley (abentley) wrote :

I'm landing a branch that will avoid unnecessary encoding of attachments: https://code.edge.launchpad.net/~abentley/launchpad/mail_fixes

Aaron Bentley (abentley)
Changed in launchpad-code:
status: In Progress → Fix Committed
Revision history for this message
Aaron Bentley (abentley) wrote :

Unfortunately, the issue with gmail's diff handling has not been resolved. See bug #401772.

Aaron Bentley (abentley)
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.