Ubuntu
computer-janitor package

Please, use X-Ubuntu-Gettext-Domain=computerjanitor in computer-janitor-gtk.desktop

Bug #352770 reported by Ricardo Pérez López
4
Affects Status Importance Assigned to Milestone
Launchpad itself
Invalid
Undecided
Unassigned
computer-janitor (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: computer-janitor

Computer Janitor uses computerjanitor.mo file for translations. However, computer-janitor-gtk.desktop uses computerjanitorapp.mo:

$ grep Domain /usr/share/applications/computer-janitor-gtk.desktop
X-Ubuntu-Gettext-Domain=computerjanitorapp

Right now, the Computer Janitor menu entry shows untranslated in my Spanish desktop. In order to get the menu entry translated, I only need to change the gettext domain to:

X-Ubuntu-Gettext-Domain=computerjanitor

BTW, the computerjanitor Launchpad template is fully translated into Spanish:

https://translations.launchpad.net/ubuntu/jaunty/+source/computer-janitor/+pots/computerjanitor/es/+translate

See original description
Revision history for this message
Ricardo Pérez López (ricardo) wrote :

I confirm that I can fix the problem replacing the following line:

  X-Ubuntu-Gettext-Domain=computerjanitorapp

with this line:

  X-Ubuntu-Gettext-Domain=computerjanitor

in the computer-janitor-gtk.desktop file. After doing this, I can see the Computer Janitor menu entry correctly translated into Spanish.

Changed in rosetta:
status: New → Invalid
Revision history for this message
Ricardo Pérez López (ricardo) wrote :

Reopening Rosetta. Any Launchpad Translations admin could see if it's right to have two different .mo files from only one template?

Changed in rosetta:
status: Invalid → New
Revision history for this message
Adi Roiban (adiroiban) wrote :

This is not a Rosetta bug. Maybe a bug in lang-packs.

We still don't know what is the proper domain for "computer-janitor" . Right now we are using "computerjanitor"

Please see bug #344704

Changed in rosetta:
status: New → Invalid
Revision history for this message
Ricardo Pérez López (ricardo) wrote :

Thanks, Adi.

So, if we're using "computerjanitor" as domain, then the X-Ubuntu-Gettext-Domain in the .desktop file must be "computerjanitor" as well, and not "computerjanitorapp", right?

If so, the computer-janitor-gtk.desktop file must be changed.

Ricardo Pérez López (ricardo)
summary: - Computer Janitor uses computerjanitor.mo, but .desktop uses
- computerjanitorapp.mo
+ Please, use X-Ubuntu-Gettext-Domain=computerjanitor in computer-janitor-
+ gtk.desktop
Ricardo Pérez López (ricardo)
description: updated
summary: - Please, use X-Ubuntu-Gettext-Domain=computerjanitor in computer-janitor-
- gtk.desktop
+ Computer Janitor uses computerjanitor.mo, but .desktop uses
+ computerjanitorapp.mo
Ricardo Pérez López (ricardo)
summary: - Computer Janitor uses computerjanitor.mo, but .desktop uses
- computerjanitorapp.mo
+ Please, use X-Ubuntu-Gettext-Domain=computerjanitor in computer-janitor-
+ gtk.desktop
Revision history for this message
Martin Pitt (pitti) wrote :

I can't push into the computer-janitor branch. Lars, can you please fix this, it's simple. Thanks!

Changed in computer-janitor (Ubuntu):
assignee: nobody → liw
status: New → Triaged
to be removed (liw)
Changed in computer-janitor:
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package computer-janitor - 1.12.1-0ubuntu2

---------------
computer-janitor (1.12.1-0ubuntu2) jaunty; urgency=low

  * Fix gettext translation domain to be "computerjanitor" everywhere.
    (Closes: LP: #344704)
  * Fix NameError crash when closing an error dialog. Can't reproduce
    this, but I suspect it is some kind of weird race condition with
    threads and GTK+. (Closes: LP: #335828)
  * Fix typo on computerjanitorapp/app.py's help text for --no-act.
  * When a cruft is selected, scroll it into view after the label has
    been updated with the description. (Closes: LP: #349653)
  * plugins/unsupported_plugin.py: Don't mark as cruft stuff that has
    installed reverse dependencies. (Closes: LP: #345939)
  * data/computer-janitor.desktop.in: Use the right translation
    domain. (Closes: LP: #352770)

 -- Lars Wirzenius <email address hidden> Wed, 01 Apr 2009 17:20:45 +0300

Changed in computer-janitor (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.