packagekit-gnome .desktop files use not-existing icons

from packagekit-gnome package in ubuntu:
gpk-prefs,desktop missing icon gpk-prefs
gpk-repo.desktop missing icon gpk-repo

I think it's upstream, since the rest of the icons seem in place :)
It could also be gnome-icon-theme (?)

$ grep Icon /usr/share/applications/gpk*
/usr/share/applications/gpk-application.desktop:Icon=system-software-install
/usr/share/applications/gpk-install-catalog.desktop:Icon=system-software-install
/usr/share/applications/gpk-install-file.desktop:Icon=system-software-install
/usr/share/applications/gpk-log.desktop:Icon=gpk-log
/usr/share/applications/gpk-prefs.desktop:Icon=gpk-prefs
/usr/share/applications/gpk-repo.desktop:Icon=gpk-repo
/usr/share/applications/gpk-service-pack.desktop:Icon=gpk-service-pack
/usr/share/applications/gpk-update-viewer.desktop:Icon=system-software-update

Sorry, missing icons: gpk-service-pack, gpk-log, gpk-repo, gpk-prefs

This seems like upstream changed the icons in the lookup but didn't see to it that new icons were created as well.

as andreasn replied "packagekit specific icons should be installed by packagekit"
So this is a packagekit-specific bug that should be forwarded upstream :)

It's a package mistake the icons have make rules to be linked, but the package doesn't seem to include them:
install-data-hook:
 mkdir -p $(DESTDIR)$(DATADIR)/icons/hicolor/$(size)/apps;
 mkdir -p $(DESTDIR)$(DATADIR)/icons/hicolor/$(size)/mimetypes;
 ln -fs $(iconsdir)/pk-package-sources.png $(DESTDIR)$(DATADIR)/icons/hicolor/$(size)/apps/gpk-repo.png;
 ln -fs $(iconsdir)/pk-package-info.png $(DESTDIR)$(DATADIR)/icons/hicolor/$(size)/apps/gpk-log.png;
 ln -fs $(iconsdir)/pk-update-high.png $(DESTDIR)$(DATADIR)/icons/hicolor/$(size)/apps/gpk-prefs.png;
 ln -fs $(iconsdir)/pk-service-pack.png $(DESTDIR)$(DATADIR)/icons/hicolor/$(size)/apps/gpk-service-pack.png;
 ln -fs $(iconsdir)/pk-service-pack.png $(DESTDIR)$(DATADIR)/icons/hicolor/$(size)/mimetypes/application-x-servicepack.png;
 ln -fs $(iconsdir)/pk-package-info.png $(DESTDIR)$(DATADIR)/icons/hicolor/$(size)/mimetypes/application-x-package-list.png;
 ln -fs $(iconsdir)/pk-collection-installed.png $(DESTDIR)$(DATADIR)/icons/hicolor/$(size)/mimetypes/application-x-catalog.png;

blocked by bug #364443

I've sent a patch that covers this at bug #364443

Proper patch included for bug #249104, bug #364443 and bug #349572

The patch can be found at bug #249104:
https://bugs.edge.launchpad.net/ubuntu/+source/packagekit-gnome/+bug/249104/comments/3

accepted into jaunty-proposed, please test

tracking on bug 249104

Confirmed, menu Applications > System tools shows correct icons!

Could it be pushed for karmic too?

Thanks

karmic patch posted at bug #249104:
https://bugs.launchpad.net/ubuntu/+source/packagekit-gnome/+bug/249104/comments/12

  * debian/patches/configure.patch:
    + FTBFS on some archs: Disable -Wcast-align. (LP: #249104)
    + FTBFS: Disable GDK_MULTIHEAD_SAFE, as it breaks with new libcanberra-gtk.
      (LP: #419554)
  * debian/packagekit-gnome.install:
    - Use directories, there is no need to name files one by one:
      + debian/tmp/usr/bin/
      + debian/tmp/usr/share/man/
      + debian/tmp/usr/share/locale/
      + debian/tmp/usr/share/applications/
      + debian/tmp/usr/share/gnome-packagekit/
      + debian/tmp/usr/share/icons/hicolor/ (LP: #349572)
    - Sort list
  * debian/copyright: Now dep5-compatible, updated FSF address.
  * debian/control: Removed "edge" from XS-Vcs-Bzr.

This bug was fixed in the package packagekit-gnome - 2.27.2-0ubuntu3

---------------
packagekit-gnome (2.27.2-0ubuntu3) karmic; urgency=low

  * debian/patches/configure.patch:
    + FTBFS on some archs: Disable -Wcast-align. (LP: #249104)
    + FTBFS: Disable GDK_MULTIHEAD_SAFE, as it breaks with new libcanberra-gtk.
      (LP: #419554)
  * debian/packagekit-gnome.install:
    - Use directories, there is no need to name files one by one:
      + debian/tmp/usr/bin/
      + debian/tmp/usr/share/man/
      + debian/tmp/usr/share/locale/
      + debian/tmp/usr/share/applications/
      + debian/tmp/usr/share/gnome-packagekit/
      + debian/tmp/usr/share/icons/hicolor/ (LP: #349572)
    - Sort list
  * debian/copyright: Now dep5-compatible, updated FSF address.
  * debian/control: Removed "edge" from XS-Vcs-Bzr.

 -- Savvas Radevic <email address hidden> Wed, 26 Aug 2009 21:27:12 +0200

Baptiste, could you give it a "test spin" on karmic as well? :)

On Thu, Aug 27, 2009 at 11:18 AM, Savvas Radevic<email address hidden> wrote:
> Baptiste, could you give it a "test spin" on karmic as well? :)
>

Sure, I'll give a try this evening.

Thanks

--
Baptiste Mille-Mathias
Les gens heureux ne sont pas pressés

FYI, I'll ask for a new upstream release:
https://bugs.launchpad.net/bugs/414239

Anyone who can test the jaunty-proposed package? If not, the proposed update will be removed again. Thanks!

SRU Verification for Jaunty:
I have reproduced the problem with packagekit-gnome | 0.3.13-0ubuntu1 and have verified that the version of packagekit-gnome | 0.3.13-0ubuntu1.1 in -proposed fixes the issue.

Marking as verification-done

This bug was fixed in the package packagekit-gnome - 0.3.13-0ubuntu1.1

---------------
packagekit-gnome (0.3.13-0ubuntu1.1) jaunty-proposed; urgency=low

  * 05_fix_set_tooltip_text.patch: Fixes FTBFS on i386 and amd64
    Check GTK version, use gtk_status_icon_set_tooltip_text or
    gtk_status_icon_set_tooltip where applicable.
    Thanks to Michael Bienia (LP: #364443)
  * packagekit-gnome.install: Include usr/share/icons/hicolor (LP: #349572)
  * 10_configure_no_Wcast-align.patch: remove -Wcast-align from configure
    (LP: #249104)

 -- Savvas Radevic <email address hidden> Mon, 20 Apr 2009 19:28:06 +0000