Personal p3a subscription needs distroseries selector
Bug #349456 reported by
Michael Nelson
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Medium
|
Michael Nelson | ||
Bug Description
Currently when a person confirms a subscription to a private ppa, they are shown their personal sources.list entries with the default distroseries.
A selector is needed (similar to the PPA page) that works without JS but is enhanced with JS also, so that users can select from the available distroseries for that PPA.
The default distroseries displayed should use the browsers user agent data, if it matches one of the options.
| Changed in soyuz: | |
| assignee: | nobody → michael.nelson |
| Changed in soyuz: | |
| importance: | Undecided → Medium |
| milestone: | none → 2.2.4 |
| status: | New → Triaged |
| Changed in soyuz: | |
| milestone: | 2.2.4 → 2.2.5 |
| Changed in soyuz: | |
| milestone: | 2.2.5 → 2.2.6 |
| Changed in soyuz: | |
| status: | Triaged → In Progress |
Revision history for this message
| Michael Nelson (michael.nelson) wrote | #1 |
Revision history for this message
| Michael Nelson (michael.nelson) wrote | #2 |
Revision history for this message
| Michael Nelson (michael.nelson) wrote | #3 |
Revision history for this message
| Julian Edwards (julian-edwards) wrote Re: [Bug 349456] Re: Personal p3a subscription needs distroseries selector | #4 |
Revision history for this message
| Martin Albisetti (beuno) wrote | #5 |
Revision history for this message
| Diogo Matsubara (matsubara) wrote Bug fixed by a commit | #6 |
| Changed in soyuz: | |
| status: | In Progress → Fix Committed |
| Changed in soyuz: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
OK, I've implemented the distroseries selector (with auto-default from users reported distroseries), but during review Aaron noticed that we could be using the comments in the sources.list snippet in a way that Ubuntu's software sources '3rd party sources' tab displays them instead of the apt-url.
So, afaics, the 3rd party software tab will display a comment instead of the apt-url line if it appears directly *after* the apt-url - on the same line.
It also appends "(Source code)" to the display of deb-src urls automatically (see bug-349456-sources.png)
Also, it doesn't strip leading spaces from the comment.
For this reason, I've updated the template so that the same comment is displayed after both the binary and source lines, without the leading space.
Now, when this displays inside a pre-element (as it does currently), it forces the browser width to the size of the apt-url lines - which is not optimal. On the other hand, we can a pre-element with the .wrap class - it copy-n-pastes fine - but may also look awkward in the browser window (as it won't necessarily break right where the comment starts).
I also tried continuing an apt-url line over two lines, using '\' and putting the comment on the second line, but software sources does not then pick the comment up.
So, for the moment, I've left the sources.list in a pre (without wrapping). I've attach some screenshots for input.