Right-clicking on a tag shouldn't switch view

Pushed a branch that fixes this. I'm not totally sure I'm happy with it, though, since it doesn't give any indication (other than the location of the context menu) for which tag is going to be modified...

I've tried and, indeed, I find it a bit strange because you don't have the feedback about where you clicked.

I'm wondering if the solution isn't worst than the problem itself. I would like to have more feedback about it.

(Matthew, this is not a critic of your patch which is great. I had to test your patch to realize that it, in fact, the solution to this bug is maybe not trivial)

How is it done in other applications?

We could still move the cursor but only trigger update of the task
list when it is activated by a left click (or the keyboard) (filtering
could be done in on_Select_tag method in browser.py). Thunderbird,
thunar, nautilus, ... do that for instance. I think it's the right way
to do it.

On Wed, Dec 23, 2009 at 7:44 PM, Lionel Dricot <email address hidden> wrote:
> I've tried and, indeed, I find it a bit strange because you don't have
> the feedback about where you clicked.
>
> I'm wondering if the solution isn't worst than the problem itself. I
> would like to have more feedback about it.
>
> (Matthew, this is not a critic of your patch which is great. I had to
> test your patch to realize that it, in fact, the solution to this bug is
> maybe not trivial)
>
> How is it done in other applications?
>
> --
> Right-clicking on a tag shouldn't switch view
> https://bugs.launchpad.net/bugs/348907
> You received this bug notification because you are subscribed to Getting
> Things GNOME!.
>

--
Bertrand Rousseau

I just tested this in Thunderbird--the right clicked folder gets selected, the main view remains unchanged, and then the cursor returns to the previous selection once the context window goes away. This is actually almost exactly what I've been working on implementing myself in GTG as an alternative to the other method I used, but I'm not quite done with it yet.

Pushed a new fix to this (but I think I might have overwritten my previous fix--oh well, still learning). I could've had this done a lot sooner but I've been busy. :) Hope this is good enough~

There's a problem with your branch : if you check/uncheck the "displayed in the workview" checkbox, the affected tag is not the right clicked one but the one who was selected before.

Lionel Dricot wrote:
> There's a problem with your branch : if you check/uncheck the "displayed
> in the workview" checkbox, the affected tag is not the right clicked one
> but the one who was selected before.
>

Fortunately that's an easy fix. When I was working on that, though I
found another bug that isn't quite as simple: when the color picker
dialog is open the taskview will act as if the tag that's being edited
is also the one that's selected. I'm not really sure how I missed this
before since I used the color picker a lot while testing (I guess I was
paying more attention to the cursor location?). Once I've worked that
out it should be ready, unless more bugs pop up.

Both those bugs should be fixed now. On to a new one: the fix doesn't seem to work on the first try when right clicking a tag that has "displayed in workview" unchecked, but DOES work on the second try. After that, the same thing happens in reverse: tags that have "displayed in workview" unchecked work fine, but it takes an extra right click to work on tags that are visible (and then the cycle repeats again). Hopefully I won't manage to break anything else while fixing that. :)

It _should_ be done now, although I'm convinced that there's a better way to do all this, but (probably due to my inexperience) I can't think of anything. If there's anything else in there that needs working on, let me know and I'll get on top of it ASAP!

Hi Matthew,
I found a little bug in your branch.
- Select one tag
- Double right click on either "All tasks" or "Tasks without tags"

The view switches.

Luca Invernizzi wrote:
> Hi Matthew,
> I found a little bug in your branch.
> - Select one tag
> - Double right click on either "All tasks" or "Tasks without tags"
>
> The view switches.
>

Thanks for spotting that. In hindsight I should've been able to spot
that just by looking at the code I had written, but oh well. It was easy
to fix.