Ubuntu
xorg-server package

xvfb-run incorrectly states that the return value is always that of the script run

Bug #328205 reported by Mark Painter
4
Affects Status Importance Assigned to Milestone
xorg-server (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

The comments in the start of xvfb-run state that the return code will be that of the command xvfb-run is wrapping, which isn't always the case, eg an error cleaning up the temp dir will exit with return value of 5 when the wrapped command exited successfully.

The comment should be cleaned up to reflect this -- the man page already makes it clear.

Related branches

lp:ubuntu/lucid/xorg-server
Revision history for this message
Bryce Harrington (bryce) wrote :

Hi mpainter,

Please attach the output of `lspci -vvnn`, and attach your /var/log/Xorg.0.log (and maybe Xorg.0.log.old) file from after reproducing this issue. If you've made any customizations to your /etc/X11/xorg.conf please attach that as well.

[This is an automated message. Apologies if it has reached you inappropriately; please just reply to this message indicating so.]

Changed in xorg-server:
status: New → Incomplete
Revision history for this message
Mark Painter (mpainter) wrote :

My setup is irrelevant, though it's probably likely that this is just something to be pushed upstream.

Revision history for this message
Bryce Harrington (bryce) wrote :

Care to propose a patch?

Changed in xorg-server:
importance: Undecided → Low
Bryce Harrington (bryce)
Changed in xorg-server:
importance: Low → Wishlist
status: Incomplete → Triaged
Revision history for this message
Mark Painter (mpainter) wrote :

Sure. On another look, I noticed the manpage was also slightly inaccurate, so I addressed that in this patch as well.

Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks Mark, I'll get this in Jaunty with my next xserver update.

Could you please also forward this fix upstream to Debian so they will incorporate the corrections into their copy of this tool as well. Thanks ahead of time.

Changed in xorg-server (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xorg-server - 2:1.6.0-0ubuntu9

---------------
xorg-server (2:1.6.0-0ubuntu9) jaunty; urgency=low

  * local/xvfb-run: Fixes race condition with concurrent invocations
    (LP: #348052)
  * local/xvfb-run, xvfb-run.1: Add correct docs about error codes
    (LP: #328205)
  * local/xserver-xephyr.1, rules, xserver-xephyr.install: Add man page
    for xephyr
    (LP: #134906)

 -- Bryce Harrington <email address hidden> Wed, 01 Apr 2009 20:37:22 -0700

Changed in xorg-server (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.