mozvoikko depends on iceweasel, should depend on firefox

Debdiff to fix this bug.

Confirming. This needs addressing as mozvoikko as an integral part of Finnish language support is posed for main inclusion later on.

Hi,

You have a branch at

  https://code.edge.launchpad.net/~heikki-mantysaari/firefox-extensions/mozvoikko.ubuntu

which indicates you would like to get sponsorship through the mozillateam, is that correct?

Thanks,

James

Subscribing mozillateam.

Hello,

As of intrepid, there is package abrowser, which provides unbranded Firefox. Please add an optional dependency for it. It should be like "abrowser (>= 3) | firefox (>= 3)".

Thank you for your contribution.

New debdiff attached.

And yes I also have a branch which I use to store my packaging. I'm happy if mozillateam can sponsor my patch, but I think Universe Sponsors can also do that. I haven't seen any document telling who should I request to sponsor this kind of patch (mozillateam or universe sponsors?)

On Mon, Nov 24, 2008 at 9:08 AM, Heikki Mäntysaari wrote:
> And yes I also have a branch which I use to store my packaging.

If you use a branch to maintain your packaging, you should mention it
in debian/control, like in the template [1]. If you're not familiar
with the branch naming, take a look at the extension packaging wiki
page [2]. This is not necessary for the current upload.

> I haven't seen any document telling who should I
> request to sponsor this kind of patch (mozillateam or universe
> sponsors?)

I think you should subscribe universe sponsors. AFAIK, there is no
rule that Mozilla team is sponsor for Mozilla-related uploads.

The debdiff has an ack from Mozilla team. If you can, please mention
in the changelog that it optionally depends on abrowser. Thanks.

[1] <http://bazaar.launchpad.net/~mozillateam/firefox-extensions/XPI.TEMPLATE/annotate/13?file_id=control-20080221120129-aifetlupiq8reqgv-4>
[2] <https://wiki.ubuntu.com/MozillaTeam/Extensions/Packaging#Packaging%20Procedure>

Thanks for your help!

I attach new debdiff. It now mentions abrowser in the changelog and my bzr branch in the control file. I also created mozvoikko.upstream branch according to the wiki page you gave.

A ready made package by Heikki is available in Ubuntu-fi's PPA at:
https://launchpad.net/~ubuntu-fi/+archive (http://ppa.launchpad.net/ubuntu-fi/ubuntu/pool/main/m/mozvoikko/mozvoikko_0.9.5-1ubuntu1.dsc). The package with the diff applied builds and runs fine. Please upload it to the archive so we can proceed with the plans to include it in the Finnish language support in jaunty.

Universe sponsors: ping! This would really need to go in, by universe sponsors, to universe, at this point.

the branch is not ready for use ... we need a clean initial upstream revision commit, so we can produce the orig.tar.gz from it. read https://wiki.ubuntu.com/MozillaTeam/Extensions/Bzr to get basics.

please resubscribe universe-sponsors when you have a new branch

also subscribe mozilla-extensions-dev team when done.

Thanks for your comments.

I think my branches are now fine.

On Thu, Dec 18, 2008 at 02:36:10PM -0000, Heikki Mäntysaari wrote:
> ** Changed in: mozvoikko (Ubuntu)
> Status: Incomplete => Confirmed
>

Didnt get any mail that you reattached a new patch. Once done, let us know.

 - Alexander

The patch I have already uploaded (mozvoikko_0.9.5-1ubuntu1.debdiff.3) is still valid. This bug was marked incomplete because my bzr branches were incomplete.

I'm ok with it but i think we should have kept iceweasel as a depends that way its able to be sent to Debian if we upgrade or such.
At least we try to keep inceweasel in deps for all browser extensions.

I added iceweasel to the dependencies in my branch.

I'm attaching a new debdiff.

On 12/23/2008 04:59 AM, Heikki Mäntysaari wrote:
> I added iceweasel to the dependencies in my branch.
>
> I'm attaching a new debdiff.
>
> ** Attachment added: "mozvoikko_0.9.5-1ubuntu1.debdiff.4"
> http://launchpadlibrarian.net/20682398/mozvoikko_0.9.5-1ubuntu1.debdiff.4
>
Thanks. Alexander im ok with this debdiff if it matters, its already got
an ack from Mozilla team.

--
Sincerely Yours,
    John Vivirito

https://launchpad.net/~gnomefreak
https://wiki.ubuntu.com/JohnVivirito
Linux User# 414246

"How can i get lost, if i have no where to go"
    -- Metallica from Unforgiven III

On Tue, Dec 23, 2008 at 10:09:47AM -0000, John Vivirito wrote:
> On 12/23/2008 04:59 AM, Heikki Mäntysaari wrote:
> > I added iceweasel to the dependencies in my branch.
> >
> > I'm attaching a new debdiff.
> >
> > ** Attachment added: "mozvoikko_0.9.5-1ubuntu1.debdiff.4"
> > http://launchpadlibrarian.net/20682398/mozvoikko_0.9.5-1ubuntu1.debdiff.4
> >
> Thanks. Alexander im ok with this debdiff if it matters, its already got
> an ack from Mozilla team.
>

I dont know if i said different in the past, but if so I was wrong. I
would suggest to depend on the versioned packages, so you get an
implicit upper bound.

For instance: Depends: firefox-3.0, abrowser-3.0, iceweasel-3.0 (do
they have that?) ... problem is that currently you only know that you
are compatible with 3.0.* ... but not what will happen in future (so
no 3.*) ... can you adjust the depends accordingly?

 - Alexander

Thanks for your comments.

Mozvoikko works with both firefox-3.0 and firefox-3.1, so I added both of these packages to dependencies.

However there is no abrowser-3.0 package in the repo (only abrowser-3.1) but the version of abrowser package is 3.0.x so I added conflict to abrowser (>= 3.2). Also there is no package like iceweasel-3.1 in Debian so I added conflict to iceweasel (>= 3.2).

Do you accept this?

I'm attaching a new debdiff. I also updated my branch.

Universe sponsors: ping! Patch should be ready to upload. Could you upload it?

On Sun, Jan 11, 2009 at 09:50:50AM -0000, Heikki Mäntysaari wrote:
> Universe sponsors: ping! Patch should be ready to upload. Could you
> upload it?
>

Thanks.

I repointed the Vcs-Bzr: entry to the ~ubuntu-dev release realm and
added .bzr-builddeb/default.conf to easy package plumbering using bzr
builddeb.

 status fixcommitted

From now on, please contribute by branching topic branches from
~ubuntu-dev branch and request merges to the "release branch". Thanks!

Upload will happen now.

 - Alexander

On Tue, Jan 13, 2009 at 10:45:53AM -0000, Alexander Sack wrote:
> On Sun, Jan 11, 2009 at 09:50:50AM -0000, Heikki Mäntysaari wrote:
> > Universe sponsors: ping! Patch should be ready to upload. Could you
> > upload it?
> >
>
> Thanks.
>
> I repointed the Vcs-Bzr: entry to the ~ubuntu-dev release realm and
> added .bzr-builddeb/default.conf to easy package plumbering using bzr
> builddeb.
>
> status fixcommitted
>
> >From now on, please contribute by branching topic branches from
> ~ubuntu-dev branch and request merges to the "release branch". Thanks!
>
> Upload will happen now.
>
> - Alexander

Sorry, oversaw how you link against xul. Please use pkg-config
--cflags libxul and pkg-config --libs libxul and dont try to do that
manually.

If you dont want to diverge that considerably from upstream, at least
drop the -rpath thing in src/Makefile.xulrunner ... which is evil and
wrong.

 status incomplete

Since i alreawdy uploaded ubuntu1, please prepare the fix in a feature
branch for ubuntu2. Thanks!

 - Alexander

 - Alexander

Thank you for sponsoring my patch and giving a valuable feedback!

I wrote a patch witch changes src/Makefile.xulrunner to use pkg-config --cflags libxul-unstable and pkg-config --libs libxul-unstable. I had to use unstable because there are some necessary files in /usr/include/xulrunner-1.9.0.5/unstable which are not in /usr/include/xulrunner-1.9.0.5/stable (e.g. mozilla-config.h).

I'll also merge these changes to the Debian package when I update it next time (when Thunderbird 3 is released) and send my patch to the upstream author (if this version is accepted).

Merge request: https://code.launchpad.net/~heikki-mantysaari/firefox-extensions/mozvoikko.ubuntu/+merge/2821

Universe sponsors: ping! Could someone upload my patch?

This bug was fixed in the package mozvoikko - 0.9.5-1ubuntu2

---------------
mozvoikko (0.9.5-1ubuntu2) jaunty; urgency=low

  * debian/patches/90_modify-makefile-to-use-pkg-config.patch:
    - Modify src/Makefile.xulrunner to use pkg-config for libxul
  * debian/rules:
    - Add patch system
  * Closes LP: #297169

 -- Heikki Maentysaari <email address hidden> Mon, 26 Jan 2009 14:06:40 +0100