Long dbus command displayed on dialog when trying to mount hard drive via dolphin

Bug #290589 reported by Sayak Banerjee
12
Affects Status Importance Assigned to Milestone
kde4libs (Ubuntu)
Fix Released
Undecided
Terence Simpson
Intrepid
Fix Released
Undecided
Unassigned

Bug Description

When mounting a drive in KDE (Eg: via dolphin) the whole dbus command line argument is displayed in kdesudo, this looks ugly and unfriendly to the user.
This should be changed to display a more useful and descriptive message.
Reproduction:
Try to mount a disk/device via dolphin by clicking on it in the "Places" panel;
If the user does not have permission to mount the device as themselves a kdesudo dialog opens asking for the users password.

Revision history for this message
Sayak Banerjee (sayakb-deactivatedaccount) wrote :
Revision history for this message
Tomasz 'Zen' Napierala (tzn) wrote :

Thank you for taking your time to make Ubuntu better, we really appreciate this.
I think this behavior is by design, to show what the system is actually attempting to do. I will mark his bug as confirmed, an we will wait for developer to provide more input on this.

Changed in kdesudo:
status: New → Confirmed
Revision history for this message
Terence Simpson (tsimpson) wrote :

The issue here is how kdelibs calls the command, not in kdesudo.

Changed in kdesudo:
assignee: nobody → tsimpson
Changed in kdelibs:
assignee: tsimpson → nobody
Revision history for this message
Sayak Banerjee (sayakb-deactivatedaccount) wrote :

@Tomasz Z. Napierala

Maybe this could be rather a "WIshlist" bug? :)
Can the displaying of the whole kdelibs command at the kdesudo dialog be masked or is it necessary to display it there?

Thanks
Sayak Banerjee

Revision history for this message
Terence Simpson (tsimpson) wrote :

This patch should hide the long dbus-send command with a user-friendly message

description: updated
Changed in kde4libs:
assignee: nobody → tsimpson
status: Confirmed → In Progress
Revision history for this message
Martin Pitt (pitti) wrote :

I agree that this is worth fixing.

However, the new string needs to be i18n'ed with gettext. I. e. it needs to be wrapped into _(), and po/POTFILES.in needs to have that file. Also, I'm not sure how that works together with KDE's slightly uncommon l10n package structure. So it would really be best to discuss/fix this upstream first, and then backport to intrepid, so that we don't introduce a different string than upstream.

Maybe there is an already existing error message which would fit there, which is already i18n'ed and avoids introducing a new user visible string?

Revision history for this message
Terence Simpson (tsimpson) wrote :

Updated patch

Revision history for this message
Terence Simpson (tsimpson) wrote :

wrong upload

Revision history for this message
Terence Simpson (tsimpson) wrote :

The strings in the patch should now be translatable and extracted during build

Revision history for this message
Martin Pitt (pitti) wrote :

Thanks! Why is the change to CMakeLists.txt necessary?

Revision history for this message
Terence Simpson (tsimpson) wrote :

This is necessary because the solid library needs to link against the kdecore library to use translation features.
I also added solid/solid/backends/hal/Messages.sh, this is used during building to extract translatable strings and add them to a .po
I have built the package in my PPA[1] and everything seems to work correctly here.
[1] http://launchpad.net/~tsimpson/+archive

Revision history for this message
Martin Pitt (pitti) wrote :

I sponsored the patch, uploaded. Waiting for SRU processing now.

Changed in kde4libs:
status: New → In Progress
Revision history for this message
Martin Pitt (pitti) wrote :

Accepted into intrepid-proposed, please test and give feedback here. Please see https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in kde4libs:
status: In Progress → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote :

intrepid-proposed package copied to jaunty.

Changed in kde4libs:
status: In Progress → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package kde4libs - 4:4.1.3-0ubuntu1~intrepid2

---------------
kde4libs (4:4.1.3-0ubuntu1~intrepid2) intrepid-backports; urgency=low

  [ Terence Simpson ]
  * Update kubuntu_06_user_disk_mounting.diff
    - Don't show the user long dbus commands (LP: #290589)

  [ Scott Kitterman ]
  * Fix http cache cleaner (Upstream patch that missed 4.1.3)
    - http://bugs.kde.org/show_bug.cgi?id=172182
    - Add kubuntu_12_http_cache_cleaner.diff

 -- Scott Kitterman <email address hidden> Fri, 07 Nov 2008 10:51:32 -0500

Changed in kde4libs:
status: Fix Committed → Fix Released
Revision history for this message
Jonathan Riddell (jr) wrote :

TEST CASE: open dolphin on a computer where a hard disk has a partition that is not mounted and is not in /etc/fstab. Click on the disk drive, it should prompt for a password then mount and show the drive. The prompt should not have a long dbus command.

Revision history for this message
Jonathan Riddell (jr) wrote :

Works for me.

Revision history for this message
Andreas Wenning (andreas-wenning) wrote :

Works for me in intrepid (with backports enabled).

Revision history for this message
Sayak Banerjee (sayakb-deactivatedaccount) wrote :

Works perfectly for me too!

Martin Pitt (pitti)
Changed in kde4libs:
status: Fix Released → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote :

Copied to intrepid-updates.

Changed in kde4libs:
status: Fix Committed → Fix Released
Revision history for this message
Sayak Banerjee (sayakb-deactivatedaccount) wrote :

Enabling "Set date and time automatically" in System Settings->Date and Time shows this dialog.

Revision history for this message
Terence Simpson (tsimpson) wrote :

That would be another bug. Probably more to do with how KDESudo and kdesu deal with the -d option.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.