the new session dialog should use other icon names

Also notice this issue, the dialog obviously uses icon names which do not follow the freedesktop's specification. Moreover, the icon gnome-session-hibernate and gnome-session-suspend are not even included in gnome-icon-theme and tango-icon-theme packages. See Bug #277309

do you have other icons suggestions?

don't assign bugs to other people it's not up to you do decide who is going to work on those

>do you have other icons suggestions?

The best thing would be, to have icons named system-hibernate, system-suspend and system-reboot. These unfortunately are not (yet?) part of freedesktop.org specification, at least as far as I can see.

While view-refresh and device-harddisk should be available in all icon themes, the "sleep" icon is not (at the moment it is only available in human-icon-theme). So at least for the sleep action should be considered a name, that is available in all themes (or a generic icon should be installed to hicolor-icon-theme).

I'm an icon theme maintainer so I'll throw in my 2 cents here. Using drive-harddisk and view refresh is totally wrong. It prevents an icon theme from having a different graphical metaphor for e.g. refreshing a web page and restarting the computer, which are completely different actions, while drive-harddisk is a device icon, not an action. They just by chance happen to look the same in Gnome icon theme. The "sleep" name is too generic, and inconsistent with the terminology used in the dialog (the dialog text calls this action Suspend, not Sleep).

I propose either to revert to gnome-session-suspend, gnome-session-hibernate and gnome-session-restart like it was in Hardy, or to use Gnome Power Manager icons: gpm-suspend and gpm-hibernate, which are available at least in the Hicolor theme. Another option would be to copy icon names from KDE4 which are likely to make it into the fd.o spec.

So we have three solutions.
Solution 1: revert to previous names

#define GSM_ICON_LOGOUT "system-log-out"
#define GSM_ICON_SWITCH "gnome-session-switch"
#define GSM_ICON_SHUTDOWN "gnome-session-shutdown"
#define GSM_ICON_REBOOT "gnome-session-restart"
#define GSM_ICON_HIBERNATE "gnome-session-hibernate"
#define GSM_ICON_SLEEP "gnome-session-suspend"

Solution 2: use GPM icons

#define GSM_ICON_LOGOUT "system-log-out"
#define GSM_ICON_SWITCH "system-users"
#define GSM_ICON_SHUTDOWN "system-shutdown"
#define GSM_ICON_REBOOT "system-restart"
#define GSM_ICON_HIBERNATE "gpm-hibernate"
#define GSM_ICON_SLEEP "gpm-suspend"

Solution 3: use KDE icon names (probalbe fututre fd.o names) and fix the Gnome theme

#define GSM_ICON_LOGOUT "system-log-out"
#define GSM_ICON_SWITCH "system-users"
#define GSM_ICON_SHUTDOWN "system-shutdown"
#define GSM_ICON_REBOOT "system-restart"
#define GSM_ICON_HIBERNATE "system-suspend-hibernate"
#define GSM_ICON_SLEEP "system-suspend"

Afterwards, create symlinks in the Gnome and Human themes:
gpm-hibernate -> system-suspend-hibernate
gpm-suspend -> system-suspend
view-refresh -> system-restart

I myself would prefer the third option since icon themes for Gnome would get an extra bit of compatibility with KDE, but all of those are acceptable. Please show some compassion for icon theme authors and fix this.

Sorry for no patch but I don't know how to produce it - the above lines are not present in gsm-logout-dialog.c when I do apt-get source gnome-session.

Sebastian, icons not includes in fd.o Icon Naming Spec can be added as themable application-specific icons. For details see http://live.gnome.org/ThemableAppSpecificIcons

About names, if you are going to implement app-specific icons, I think could be better use "system-shutdown-suspend" and "system-shutdown-hibernate" and activate the GTK+ generic icon fallback[1]. This is really helpful for a11y themes like HighContrast, and save the ugly mix of "normal" icons and HC icons.

[1] http://library.gnome.org/devel/gtk/2.14/GtkIconTheme.html#GtkIconLookupFlags

Vincent, you are using this dialog in opensuse and suggested it upstream what is your opinion on the icons naming?

Le lundi 06 octobre 2008, à 10:10 -0000, Sebastien Bacher a écrit :
> Vincent, you are using this dialog in opensuse and suggested it upstream
> what is your opinion on the icons naming?

I don't care about the icon names :-) It's obvious that some icons are
misused here, and if there are better alternatives, then we should use
the better alternatives.

Vincent

--
Les gens heureux ne sont pas pressés.

To fix this, we can use any good name for the icons and put the fallbacks in /data/icons directory of the source. I think we can recycle GPM icons for this, just under a different name.

Get the GPM icons from your current installation (/usr/share/gnome-power-manager/icons) and any good restart icon, e.g. view-refresh from the Gnome theme and place them in data/icons in the source tree under appropriate names in the actions context. I would opt for KDE-compatible names (system-suspend, system-suspend-hibernate, system-restart). After this is done, add the new icons to Makefile.am. This will install the icons in the hicolor theme when gnome-session is installed. The last remaining thing is to change the names in 80_new_upstream_session_dialog.patch to point to the new icons.

Icon themes can then add symlinks to old gnome-session-* names.

In Jaunty this interface does not seem to respect the gtk theme