Ubuntu
smc package

[patch] Secret Maryo Chronicles has no menu item

Bug #263269 reported by peterfrank on 2008-08-31

This bug report is a duplicate of: Bug #250887: smc icon is missing in GNOME menus. Edit Remove

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	smc (Ubuntu)	Triaged	Medium	Unassigned
Nominated for Lucid by Stevoisiak

Bug Description

Binary package hint: smc

I'm using Hardy Heron with Gnome desktop, amd64. I installed the game in Synaptic. I can start it by typing 'smc' in a terminal, but it doesn't have a menu entry in Gnome.
I saw a similar bug report, but it refers to gusty, Kubuntu, and it says a fix is already released. Apparently this problem still exists.

Tags:

Revision history for this message

Pietro Battiston (toobaz) wrote on 2008-08-31:

Patch to the "debian" folder, as explained in https://wiki.ubuntu.com/MOTU/Contributing Edit (875 bytes, text/plain)

Adding a patch resolving the issue: package already included a .desktop file, but it wasn't installed.

Notice there was a bug in the bug, since the .desktop file contained a wrong (local) path to the icon.

While I was at it, I also added a pair of translations of the "Comment" field and categorized better.

Changed in smc:
status:	New → Confirmed

Revision history for this message

Greg Grossmeier (greg.grossmeier) wrote on 2008-09-07:

Peter,

Please see bug 250887 and help by improving either your patch or Saivann's per Harald's instructions.

Thanks!

Changed in smc:
importance:	Undecided → Medium
status:	Confirmed → Triaged

Revision history for this message

Saivann Carignan (oxmosys) wrote on 2008-09-07:

Pietro Battiston : Thanks for your work. I reviewed your patch and I see that you changed the icon for a absolute path. While this solution works, I've seen that the GNOME icon cache is generally prefered to absolute icons path (probably for better performances and to be more standard, I guess). Thus, I would recommend to base your work on the patch that I attached on bug 250887 and which is already sent to debian.

Also, there are other changes included in the .desktop file as I see! Is there a specific reason for the new category? If not absolutely necessary, I would suggest these changes to be dropped to make sure that your patch gets accepted.

Also for the translations that you added, please forward your patch to debian, since we sync this package from debian. Fixing this problem in ubuntu is only a temporary solution.

Finally, your patch does not have a changelog entry. You should update the debian/changelog file and mention all changes you made into the package, and this into the description so the bug gets automatically closed : (LP: #250887) (You can look at my patch if you want a example).

Do you think that you can take that before september 25th ? Don't hesitate to ask me if you don't have time to complete the patch ;-) Thanks for the work you've done so far!