Please upgrade wxwidgets2.8 to 2.8.8.1 version.

Bug #251260 reported by Devid Antonio Filoni
8
Affects Status Importance Assigned to Milestone
wxwidgets2.8 (Ubuntu)
Won't Fix
Wishlist
Unassigned

Bug Description

Please upgrade wxwidgets2.8 to 2.8.8.1 version.

Revision history for this message
Devid Antonio Filoni (d.filoni) wrote :

I'm working on this.

Changed in wxwidgets2.8:
assignee: nobody → d.filoni
status: New → In Progress
Revision history for this message
Devid Antonio Filoni (d.filoni) wrote :

wxwidgets2.8 (2.8.8.1-0ubuntu1) intrepid; urgency=low

  * New upstream version, tarball generated by get-orig-source rule,
    LP: #251260.
  * Add debian/patches/fix_b_bashism.dpatch patch to fix a bashism.
  * debian/control.in: modify python-wxversion version to 2.8.8.0-0ubuntu1
    in python-wxgtk=V=U Depends field.
  * debian/rules: include some changes from Debian debian/rules.
  * Move all icons from debian to debian/icons.

 -- Devid Filoni <email address hidden> Wed, 23 Jul 2008 16:48:27 +0200

Changed in wxwidgets2.8:
assignee: d.filoni → nobody
status: In Progress → Confirmed
Changed in wxwidgets2.8:
importance: Undecided → Wishlist
Revision history for this message
Luca Falavigna (dktrkranz) wrote :

  * Move all icons from debian to debian/icons.

Is that really necessary?

Revision history for this message
Devid Antonio Filoni (d.filoni) wrote :

No, but it make possible to find a file in debian dir :)

Revision history for this message
Morten Kjeldgaard (mok0) wrote :

Please leave URL to version 2.8.8.1; I can only find 2.8.8

Changed in wxwidgets2.8:
assignee: nobody → mok0
status: Confirmed → In Progress
assignee: mok0 → nobody
status: In Progress → Confirmed
Revision history for this message
Devid Antonio Filoni (d.filoni) wrote :
Revision history for this message
Devid Antonio Filoni (d.filoni) wrote :
Revision history for this message
Emmet Hikory (persia) wrote :

Apologies, but the sponsors were unable to get to this request prior to feature freeze. It appears that this update will require a feature-freeze exception. If you are sure that this is not the case, please resubscribe the sponsors queue. If it is the case, please work with the MOTU Release team to get this update approved.

Revision history for this message
Devid Antonio Filoni (d.filoni) wrote :

IMHO this is a bug fix release only. Upstream changelog (from http://wxpython.org/recentchanges.php):

wx.richtext: Added wrappers for the RichTextPrinting and RichTextPrintout classes.
Make it easier to replace the check box images used in the CheckListCtrlMixin class.
Fixed bug in wx.ScrolledWindow when child focus events caused unneccessary or incorrect scrolling.
Fixed a bug in wx.GridBagSizer where hidden items were not ignored in part of the layout algorithm.
Several other bugs also fixed.

Changed in wxwidgets2.8:
status: Confirmed → New
Revision history for this message
Cesare Tirabassi (norsetto) wrote :

There are quite a lot of rdepends, so, I don't feel very comfortable in acking this. However, its still early in the cycle so I'm amenable to ack it provided that:

1. You have a sponsor that can check and upload with a matter of urgency
2. You can show us the diff between this and the previous version
3. You can show us a build log
4. Tell us if any of the rdepends needs rebuilding
5. Give us some evidence that there is no API/ABI change

Changed in wxwidgets2.8:
status: New → Incomplete
Revision history for this message
Devid Antonio Filoni (d.filoni) wrote :
Revision history for this message
StefanPotyra (sistpoty) wrote :

hm... just been skimming the diff:
* the API looks stable, so I doubt we'll have problems rebuilding rdepends
* there is a possible type change, meaning that the ABI might change. Can you give us a diff of the symbols of the shared objects to find out if the ABI is stable or does indeed change?

Thanks,
     Stefan.

Revision history for this message
Devid Antonio Filoni (d.filoni) wrote :

How can I generate it?

Revision history for this message
Devid Antonio Filoni (d.filoni) wrote :

Ok, I've found check-symbols, I will use it.

Revision history for this message
Devid Antonio Filoni (d.filoni) wrote :

The diff, I hope it's ok.

Revision history for this message
StefanPotyra (sistpoty) wrote :

hm... interesting, the type changes obviously don't change the ABI. However some d'tors have changed. Can you check if these are publically visible (which would mean that the public ABI has changed) or are only private to wx?

(use c++filt on the removed symbols to find out the class/methods, from there you can look up the visibility in the code).

thanks,
    Stefan.

Revision history for this message
Devid Antonio Filoni (d.filoni) wrote :

c++filt _ZN13wxArrayStringC1Ev
wxArrayString::wxArrayString()

c++filt _ZN14wxTreeTextCtrl6FinishEv
wxTreeTextCtrl::Finish()

_ZN13wxArrayStringC1Ev symbol seems also to be removed and after added in another .so.

Revision history for this message
StefanPotyra (sistpoty) wrote :

hm... that doesn't really explain visibility though.

After a bit of grepping:
wxArrayString is of public visibility and comes inlined from the header. Is this a weak symbol (which I assume)? If so, I assume very much that this is ABI safe (as to my best knowledge about c++, it would then get defined again as a weak symbol in any binary where it cannot get inlined).

I couldn't find any clues about wxTreeTextCtrl::Finish() though; I have the suspicion that this is built via some macros from somewhere. Visibility would still be highly interesting here, as this is in particular not a weak symbol. Having this changed, and publically visible would mean that nonetheless the ABI changed, and a SONAME bump together with rebuilding rdepends would be highly recommended.

Now, I'm entirely unsure, if we should go for a transition of wx2.8 depending packages or not. Can you attach a changelog of wx? (I've quickly grepped the diff, and could only find a changelog for parts of wx, which added some features, but I must admit I didn't relook too hard for a changelog right now).

Revision history for this message
Devid Antonio Filoni (d.filoni) wrote :

The only changelog available seems to be the following:
http://wxpython.org/recentchanges.php

Revision history for this message
Scott Kitterman (kitterman) wrote :

If we're going to have to rebuild the rdepends, then I so no, there are too many and it's too late.

Revision history for this message
Luca Falavigna (dktrkranz) wrote :

Changes seem not so critical to justify a rebuild of several rdepends, unless a strong rationale is found or it becomes clear this upgrade won't break binary compatibility. If you can demonstrate this shortly, we can discuss better but my feeling is this upload should wait for Jaunty.

Revision history for this message
Luca Falavigna (dktrkranz) wrote :

Better postpone it for Jaunty.

Changed in wxwidgets2.8:
status: Incomplete → Won't Fix
Revision history for this message
Michael Rooney (mrooney) wrote :

Is this the same as python-wxgtk2.8? It wouldn't SEEM like it is (it seems like this is wxwidgets not wxpython), but Devid linked the wxPython changelog, and I was going to file an upgrade request for python-wxgtk2.8 to 2.8.8.1 until I found this bug.

I wonder if it might be appropriate to do 2.8.8.1 as -updates since it does fix some definite bugs and regressions with the 2.8.8.0 release, especially some moderately bad mistakes made in img2py including a blatant keyword argument typo. Anyone using 2.8.8.0 is going to have to misspell a keyword argument ("functionCompatibile") to use a feature of img2py. If this is not the proper place for a wxPython (python-wxgtk2.8) upgrade request, please let me know, thanks!

Revision history for this message
Devid Antonio Filoni (d.filoni) wrote :

wxwidgets2.8 in Ubuntu is wxPython (that includes also wxwidgets). However as a member of motu-sru I think that is better to upload patches in hardy/intrepid (SRUs) instead of a new upstream version.

Revision history for this message
Scott Kitterman (kitterman) wrote : Re: [Bug 251260] Re: Please upgrade wxwidgets2.8 to 2.8.8.1 version.

Yes. The python extensions are built from the same package.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.