Merge xchat from Debian unstable -> 2.8.6-2

I'm not a big fan of explicit library depends/recommends, but you seem to have dropped the fix for http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=487693 (in 2.8.6-2).

@Dustin: .desktop file is not freedesktop compliant, mind adjusting it?

Thanks.

@dholbach: Fixed that, sorry.

@ember: Added your requested patch as debian/patches/50_xc286_smallfixes.dpatch

@emgent: I looked at the Freedesktop Specification [1, 2], of which I am unfamiliar, and I was not able to immediately identify the particular issues you speak of, with respect to xchat.desktop. Perhaps you can delineate the specific problems you see and perhaps provide a patch.

@all: I have uploaded an updated version for your review/sponsorship at:
 * http://people.ubuntu.com/~kirkland/xchat

[1] http://library.gnome.org/devel/hig-book/stable/index.html.en
[2] http://standards.freedesktop.org/desktop-entry-spec/latest/

:-Dustin

Thanks ember for pointing out:
 * desktop-file-validate xchat.desktop

I fixed the warnings that it reported.

Updated package for review at:
 * http://people.ubuntu.com/~kirkland/xchat

:-Dustin

Uploaded, Thanks for your work. :-)

This bug was fixed in the package xchat - 2.8.6-2ubuntu1

---------------
xchat (2.8.6-2ubuntu1) intrepid; urgency=low

  * Merge from debian unstable, remaining changes: (LP: #246330)
    + xchat.desktop: comply with freedesktop spec removing deprecated items:
      - extension on icon
      - Encoding
      - Application in categories
    + debian/control:
      - Update Maintainer field as per spec.
      - Build-depend on libgtk2.0-dev (>= 2.10.0).
      - Build-depend on liblaunchpad-integration-dev.
      - Conflict/Replace xchat-systray.
      - Recommend esound-clients | alsa-utils | libarts1c2
    + debian/patches/01_serverlist.dpatch:
      - Adjust it to use irc.ubuntu.com.
    + debian/patches/37_lpi.dpatch:
      - Add Launchpad integration.
    + debian/patches/38_autoconf.dpatch:
      - Add Launchpad integration autoconf changes.
    + debian/patches/45_ctcp_version_less_information.dpatch:
      - Make ctcp version show less information.
    + debian/patches/50_xc286_smallfixes.dpatch: a couple of minor fixes
      cherry picked from CVS (remove unused variable, use if/else for on/off
      printing, static/const a variable, return on empty list, resize some
      char[]'s)
    + debian/rules:
      - Make build independent of the python version.
      - Sets XCHATSHAREDIR correctly.

xchat (2.8.6-2) unstable; urgency=low

  * debian/patches/45_save_ignore.dpatch: Added. Closes: #463072.
  * debian/control: Recommends: libnotify1 | libnotify-bin. Closes: #487693.

 -- Dustin Kirkland <email address hidden> Thu, 10 Jul 2008 11:41:38 -0500