moonshot-ui: FTBFS: src/moonshot-futils.c:41:34: error: implicit declaration of function ‘getuid’; did you mean ‘getpwuid’? [-Werror=implicit-function-declaration]

Bug #2060872 reported by Nick Rosbrook
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
moonshot-ui (Debian)
New
Unknown
moonshot-ui (Ubuntu)
Fix Released
Undecided
Nick Rosbrook

Bug Description

Imported from Debian bug http://bugs.debian.org/1066616:

Source: moonshot-ui
Version: 1.1.0+libsecret~2
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: <email address hidden>
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> gcc -DHAVE_CONFIG_H -I. -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -pthread -I/usr/include/libmount -I/usr/include/blkid -include config.h -DLOCALEDIR=\""/usr/share/locale"\" -DMOONSHOT_FLATSTORE_USERS='"/etc/moonshot/flatstore-users"' -I./libmoonshot -I./libmoonshot -I/usr/include/libsecret-1 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gio-unix-2.0 -pthread -DMOONSHOT_DBUS_BUS_CONF='"/usr/share/moonshot-ui/dbus/org.janet.Moonshot.conf"' -DMOONSHOT_DBUS_DAEMON='"/usr/bin/dbus-daemon"' -Wdate-time -D_FORTIFY_SOURCE=2 -g -O0 -Wall -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o examples/client-client.o `test -f 'examples/client.c' || echo './'`examples/client.c
> src/moonshot-futils.c: In function ‘GetUserName’:
> src/moonshot-futils.c:41:34: error: implicit declaration of function ‘getuid’; did you mean ‘getpwuid’? [-Werror=implicit-function-declaration]
> 41 | struct passwd *pwd = getpwuid(getuid());
> | ^~~~~~
> | getpwuid
> examples/client.c:36:5: warning: second argument of ‘main’ should be ‘char **’ [-Wmain]
> 36 | int main (int argc,
> | ^~~~
> cc1: some warnings being treated as errors
> make[4]: *** [Makefile:1645: src/moonshot-moonshot-futils.o] Error 1

The full build log is available from:
http://qa-logs.debian.net/2024/03/13/moonshot-ui_1.1.0+libsecret~2_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;<email address hidden>
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&<email address hidden>&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.

Revision history for this message
Nick Rosbrook (enr0n) wrote :

Testing a fix in a PPA.

Changed in moonshot-ui (Ubuntu):
status: New → In Progress
assignee: nobody → Nick Rosbrook (enr0n)
Changed in moonshot-ui (Debian):
importance: Undecided → Unknown
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package moonshot-ui - 1.1.0+libsecret~2ubuntu1

---------------
moonshot-ui (1.1.0+libsecret~2ubuntu1) noble; urgency=medium

  * Fix implicit declarations (LP: #2060872)
    - add missing #include <gio/gio.h> for g_type_init()
    - add missing #include <unistd.h> for getuid()

 -- Nick Rosbrook <email address hidden> Thu, 11 Apr 2024 12:41:52 -0400

Changed in moonshot-ui (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.