Support Elan fp device [04F3:0C99]

Salsa MP: https://salsa.debian.org/ubuntu-dev-team/libfprint/-/merge_requests/9

A few things:

a) please include a test case with a non-Elan-0x0c99 fingerprint device, to test that it keeps working.

b) I don't see the 0x0c99 device being supported in lunar's libfprint. Looks like this requires a lunar upload as well, can you confirm? I see that mantic has it.

Attached is the debdiff for lunar. Please also review.

An upload of libfprint to jammy-proposed has been rejected from the upload queue for the following reason: "upload includes debian/patches not documented in changelog".

Hi Andreas,
I added a test case of other fingerprint device. Please help to check it, thanks.

Hello Yao, or anyone else affected,

Accepted libfprint into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libfprint/1:1.94.3+tod1-0ubuntu2~22.04.06 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hi, ODM has verify the proposed stream and it is working correctly. Thanks.

Find a laptop with fingerprint [04f3:0c82] and enable -proposed to install libfprint 1:1.94.3+tod1-0ubuntu2~22.04.06, followed the steps:

* Find a machine with other fingerprint device [04f3:0c82]

* Launch `settings` and enable `Fingerprint Login`

* Enroll finger and then logout on both DUTs.

* Login system with enrolled finger.

The fp device works fine.

Enable -proposed on a Dell laptop with Elan fp device [04F3:0C99] and install libfprint version 1:1.94.3+tod1-0ubuntu2~22.04.06. Followed the steps to verify on it.

[test]
* Find a machine with Elan fingerprint device [04F3:0C99]

* Launch `settings` and enable `Fingerprint Login`

* Enroll finger and then logout on DUTs.

* Login system with enrolled finger.

The fp device works fine.

Do you need sponsorship for the Lunar upload? The debdiff looks good to me. (SRU team member)

@raof: We need sponsor uploads, thanks

Sponsored libfprint for lunar (after setting the distribution in the changelog).

Hm, pending accepting this because we might need also lunar patches for https://bugs.launchpad.net/ubuntu/+source/libfprint/+bug/2034121 and https://bugs.launchpad.net/ubuntu/+source/libfprint/+bug/2034481

Sorry bdrung, I had forgotten about those two other libfprint bugs where I asked why a lunar update wasn't uploaded as well :/

The verification of the Stable Release Update for libfprint has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package libfprint - 1:1.94.3+tod1-0ubuntu2~22.04.06

---------------
libfprint (1:1.94.3+tod1-0ubuntu2~22.04.06) jammy; urgency=medium

  [ Dirk Su ]
  * d/p/goodixmoc-Add-PID-0x633C.patch (LP: #2034121)

  [ Andy Chi ]
  * d/p/synaptics-fix-enroll_identify-problem-after-user-reset-da.patch
    (LP: #2034481)

  [ Marco Trevisan (Treviño) ]
  * debian/patches: Refresh

libfprint (1:1.94.3+tod1-0ubuntu2~22.04.05) jammy; urgency=medium

  [ Yao Wei (魏銘廷) ]
  * d/p/elanmoc-add-PID-0x0c99.patch, d/p/elanmoc-enroll-time-update.patch:
    - Add support for PID 0c99 elan fingerprint device (LP: #2031872)

 -- Marco Trevisan (Treviño) <email address hidden> Thu, 07 Sep 2023 17:20:37 +0200

Re-upload the debdiff for lunar to include Bug #2034481 and Bug #2034121

Thank you, Andy.

The debdiff looks good and seems to include the relevant patches mentioned in the changelog. I would have liked to see DEP-3 headers added to each patch; if you're not familiar with it, take a look at https://dep-team.pages.debian.net/deps/dep3/. But since this is an upload for an interim Ubuntu release I'll go ahead and upload as is.

$ dput libfprint_1.94.5+tod1-0ubuntu2.1_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /home/sergio/work/libfprint/libfprint_1.94.5+tod1-0ubuntu2.1_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/libfprint/libfprint_1.94.5+tod1-0ubuntu2.1.dsc: Valid signature from 106DA1C8C3CBBF14
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading libfprint_1.94.5+tod1-0ubuntu2.1.dsc: done.
  Uploading libfprint_1.94.5+tod1-0ubuntu2.1.debian.tar.xz: done.
  Uploading libfprint_1.94.5+tod1-0ubuntu2.1_source.buildinfo: done.
  Uploading libfprint_1.94.5+tod1-0ubuntu2.1_source.changes: done.
Successfully uploaded packages.

I'm unsubscribing ubuntu-sponsors since this is now on the SRU team's court.

Hello Yao, or anyone else affected,

Accepted libfprint into lunar-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libfprint/1:1.94.5+tod1-0ubuntu2.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-lunar to verification-done-lunar. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-lunar. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Install lunar on a Dell laptop with Elan fp device [04F3:0C99]. Then enable -proposed channel and install libfprint version 1:1.94.5+tod1-0ubuntu2.1. Followed the steps to verify on it.

[test]
* Find a machine with Elan fingerprint device [04F3:0C99]

* Launch `settings` and enable `Fingerprint Login`

* Enroll finger and then logout on DUTs.

* Login system with enrolled finger.

The fp device works fine.

This bug was fixed in the package libfprint - 1:1.94.5+tod1-0ubuntu2.1

---------------
libfprint (1:1.94.5+tod1-0ubuntu2.1) lunar; urgency=medium

  * debian/patches/elanmoc-add-PID-0x0c99.patch:
    - Add support for PID 0c99 elan fingerprint device (LP: #2031872)

  * debian/patches/goodixmoc-Add-PID-0x633C.patch
    - Add support for PID 633c goodix fingerprint device (LP: #2034121)

  * debian/patches/synaptics-fix-enroll_identify-problem-after-user-res.patch
    - Fix re-enroll fail after reset fingerprint device from BIOS (HP laptop).
      (LP: #2034481)

 -- Yao Wei (魏銘廷) <email address hidden> Thu, 28 Sep 2023 18:58:56 +0200