support independent clock and LED GPIOs for Intel IPU6 platforms

Bug #1989046 reported by You-Sheng Yang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HWE Next
Fix Released
Undecided
Unassigned
linux (Ubuntu)
Fix Released
High
You-Sheng Yang
Jammy
Won't Fix
Undecided
Unassigned
Kinetic
Fix Released
High
You-Sheng Yang
linux-oem-5.17 (Ubuntu)
Invalid
Undecided
Unassigned
Jammy
Fix Released
High
You-Sheng Yang
Kinetic
Invalid
Undecided
Unassigned
linux-oem-6.0 (Ubuntu)
Invalid
Undecided
Unassigned
Jammy
Fix Released
High
You-Sheng Yang
Kinetic
Invalid
Undecided
Unassigned

Bug Description

[SRU Justification]

[Impact]

When migrated from power_ctrl_logic driver to int3472, two additional
independent CLK/LED GPIOs other than powerdown/reset must be probed
exceptionally.

[Fix]

Vendor provided patch in
https://github.com/intel/ipu6-drivers/blob/2b8a592dc63e117d8f5af5f32a10d7e0651832d2/patch/int3472-support-independent-clock-and-LED-gpios-5.17+.patch.

[Test Case]

Tested on both TGL/ADL platforms against nominated kernels.

[Where problems could occur]

This adds exceptional cases with fallbacks to the original function. No
one else is affected.

[Other Info]

This is an essential part for switching from power_ctrl_logic based GPIO
control mechanism to the generic, upstreamed int3472 driver. Affects all
IPU6 platforms that are to run new IPU6 driver dump in 202208.

========== original bug report ==========

Per https://github.com/intel/ipu6-drivers/commit/f771bd3cb9f324a393a75e068a039bd1f9611026 and https://github.com/intel/ipu6-drivers/commit/2b8a592dc63e117d8f5af5f32a10d7e0651832d2, additional fix for INT3472 is necessary to probe camera sensor GPIOs on Intel IPU6 platforms.

CVE References

You-Sheng Yang (vicamo)
Changed in linux-oem-5.17 (Ubuntu Kinetic):
status: New → Invalid
Changed in linux-oem-6.0 (Ubuntu Kinetic):
status: New → Invalid
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote : Missing required logs.

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1989046

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

Changed in linux (Ubuntu):
status: New → Incomplete
Changed in linux (Ubuntu Jammy):
status: New → Incomplete
Revision history for this message
You-Sheng Yang (vicamo) wrote :

Mark linux/jammy as WONTFIX for we embedded IPU6 drivers in Jammy 5.15 kernel and it uses power_ctrl_logic instead of int3472 to be fixed in this task.

Changed in linux (Ubuntu Jammy):
status: Incomplete → Won't Fix
Changed in linux (Ubuntu Kinetic):
status: Incomplete → Won't Fix
status: Won't Fix → In Progress
importance: Undecided → High
assignee: nobody → You-Sheng Yang (vicamo)
Changed in linux-oem-5.17 (Ubuntu Jammy):
status: New → In Progress
importance: Undecided → High
assignee: nobody → You-Sheng Yang (vicamo)
Changed in linux-oem-6.0 (Ubuntu Jammy):
status: New → In Progress
importance: Undecided → High
assignee: nobody → You-Sheng Yang (vicamo)
Revision history for this message
You-Sheng Yang (vicamo) wrote :
description: updated
You-Sheng Yang (vicamo)
Changed in linux (Ubuntu Kinetic):
status: Incomplete → In Progress
Timo Aaltonen (tjaalton)
Changed in linux-oem-6.0 (Ubuntu Jammy):
status: In Progress → Fix Committed
Changed in linux-oem-5.17 (Ubuntu Jammy):
status: In Progress → Fix Committed
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-oem-5.17/5.17.0-1019.20 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy' to 'verification-done-jammy'. If the problem still exists, change the tag 'verification-needed-jammy' to 'verification-failed-jammy'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (18.6 KiB)

This bug was fixed in the package linux - 5.19.0-18.18

---------------
linux (5.19.0-18.18) kinetic; urgency=medium

  * kinetic/linux: 5.19.0-18.18 -proposed tracker (LP: #1990366)

  * 5.19.0-17.17: kernel NULL pointer dereference, address: 0000000000000084
    (LP: #1990236)
    - Revert "UBUNTU: SAUCE: apparmor: Fix regression in stacking due to label
      flags"
    - Revert "UBUNTU: [Config] disable SECURITY_APPARMOR_RESTRICT_USERNS"
    - Revert "UBUNTU: SAUCE: Revert "hwrng: virtio - add an internal buffer""
    - Revert "UBUNTU: SAUCE: Revert "hwrng: virtio - don't wait on cleanup""
    - Revert "UBUNTU: SAUCE: Revert "hwrng: virtio - don't waste entropy""
    - Revert "UBUNTU: SAUCE: Revert "hwrng: virtio - always add a pending
      request""
    - Revert "UBUNTU: SAUCE: Revert "hwrng: virtio - unregister device before
      reset""
    - Revert "UBUNTU: SAUCE: Revert "virtio-rng: make device ready before making
      request""
    - Revert "UBUNTU: [Config] update configs after apply new apparmor patch set"
    - Revert "UBUNTU: SAUCE: apparmor: add user namespace creation mediation"
    - Revert "UBUNTU: SAUCE: selinux: Implement userns_create hook"
    - Revert "UBUNTU: SAUCE: bpf-lsm: Make bpf_lsm_userns_create() sleepable"
    - Revert "UBUNTU: SAUCE: security, lsm: Introduce security_create_user_ns()"
    - Revert "UBUNTU: SAUCE: lsm stacking v37: AppArmor: Remove the exclusive
      flag"
    - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM: Add /proc attr entry for full
      LSM context"
    - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM: Removed scaffolding function
      lsmcontext_init"
    - Revert "UBUNTU: SAUCE: lsm stacking v37: netlabel: Use a struct lsmblob in
      audit data"
    - Revert "UBUNTU: SAUCE: lsm stacking v37: Audit: Add record for multiple
      object contexts"
    - Revert "UBUNTU: SAUCE: lsm stacking v37: audit: multiple subject lsm values
      for netlabel"
    - Revert "UBUNTU: SAUCE: lsm stacking v37: Audit: Add record for multiple task
      security contexts"
    - Revert "UBUNTU: SAUCE: lsm stacking v37: Audit: Allow multiple records in an
      audit_buffer"
    - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM: Add a function to report
      multiple LSMs"
    - Revert "UBUNTU: SAUCE: lsm stacking v37: Audit: Create audit_stamp
      structure"
    - Revert "UBUNTU: SAUCE: lsm stacking v37: Audit: Keep multiple LSM data in
      audit_names"
    - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM: security_secid_to_secctx
      module selection"
    - Revert "UBUNTU: SAUCE: lsm stacking v37: binder: Pass LSM identifier for
      confirmation"
    - Revert "UBUNTU: SAUCE: lsm stacking v37: NET: Store LSM netlabel data in a
      lsmblob"
    - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM: security_secid_to_secctx in
      netlink netfilter"
    - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM: Use lsmcontext in
      security_dentry_init_security"
    - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM: Use lsmcontext in
      security_inode_getsecctx"
    - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM: Use lsmcontext in
      security_secid_to_secctx"
    - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM:...

Changed in linux (Ubuntu Kinetic):
status: In Progress → Fix Released
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-oem-6.0/6.0.0-1005.5 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy' to 'verification-done-jammy'. If the problem still exists, change the tag 'verification-needed-jammy' to 'verification-failed-jammy'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

Timo Aaltonen (tjaalton)
Changed in hwe-next:
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-oem-5.17 - 5.17.0-1019.20

---------------
linux-oem-5.17 (5.17.0-1019.20) jammy; urgency=medium

  * jammy/linux-oem-5.17: 5.17.0-1019.20 -proposed tracker (LP: #1989787)

  * Fix resume on AMD platforms when TBT monitor is plugged (LP: #1990920)
    - drm/amd/display: Detect dpcd_rev when hotplug mst monitor
    - drm/amd/display: Release remote dc_sink under mst scenario

  * pcieport 0000:00:1b.0: PCIe Bus Error: severity=Uncorrected (Non-Fatal),
    type=Transaction Layer, (Requester ID) (LP: #1988797)
    - SAUCE: PCI/PTM: Cache PTM Capability offset
    - SAUCE: PCI/PTM: Add pci_upstream_ptm() helper
    - SAUCE: PCI/PTM: Separate configuration and enable
    - SAUCE: PCI/PTM: Add pci_suspend_ptm() and pci_resume_ptm()
    - SAUCE: PCI/PTM: Move pci_ptm_info() body into its only caller
    - SAUCE: PCI/PTM: Preserve RsvdP bits in PTM Control register
    - SAUCE: PCI/PTM: Reorder functions in logical order
    - SAUCE: PCI/PTM: Consolidate PTM interface declarations
    - SAUCE: PCI/PM: Always disable PTM for all devices during suspend
    - SAUCE: PCI/PM: Simplify pci_pm_suspend_noirq()

  * Fix AMDGPU: No video output and system hangs with two monitor (dGPU: W6400)
    (LP: #1989647)
    - drm/amd/display: Ignore First MST Sideband Message Return Error

  * System hang during S3 test (LP: #1990330)
    - memcg: add per-memcg total kernel memory stat
    - mm/memcg: revert ("mm/memcg: optimize user context object stock access")
    - mm/memcg: disable threshold event handlers on PREEMPT_RT
    - mm/memcg: protect per-CPU counter by disabling preemption on PREEMPT_RT
      where needed.
    - mm/memcg: opencode the inner part of obj_cgroup_uncharge_pages() in
      drain_obj_stock()
    - mm/memcg: protect memcg_stock with a local_lock_t
    - mm/memcg: disable migration instead of preemption in drain_all_stock().
    - mm/memremap: avoid calling kasan_remove_zero_shadow() for device private
      memory

  * To support Intel Maple Ridge Thunderbolt [8086:1134] (LP: #1990240)
    - thunderbolt: Add support for Intel Maple Ridge single port controller

  * Intel graphic driver is not probing[8086:468b] (LP: #1990242)
    - drm/i915: Add new ADL-S pci id

  * support independent clock and LED GPIOs for Intel IPU6 platforms
    (LP: #1989046)
    - SAUCE: platform/x86: int3472: support independent clock and LED GPIOs

 -- Timo Aaltonen <email address hidden> Tue, 27 Sep 2022 15:12:42 +0300

Changed in linux-oem-5.17 (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

fixed in 6.0 1006

Changed in linux-oem-6.0 (Ubuntu Jammy):
status: Fix Committed → Fix Released
Changed in hwe-next:
status: Fix Committed → Fix Released
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-oem-6.1/6.1.0-1004.4 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy' to 'verification-done-jammy'. If the problem still exists, change the tag 'verification-needed-jammy' to 'verification-failed-jammy'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-jammy-linux-oem-6.1 verification-needed-jammy
tags: added: fixed-linux-oem-6.5
Revision history for this message
You-Sheng Yang (vicamo) wrote :

For v6.3-rc1 or above, mainline commit 5ae20a8050d08 ("platform/x86: int3472/discrete: Create a LED class device for the privacy LED") replaced that sauced patch.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.