Ubuntu
network-manager package

Please sync latest changes from 1.36.4-2

Bug #1967782 reported by Michael Biebl
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
network-manager (Ubuntu)
Fix Released
High
Unassigned

Bug Description

Please consider syncing the following changes from Debian
https://tracker.debian.org/news/1315963/accepted-network-manager-1364-2-source-into-unstable/

For more background see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1003907

Seeing that Ubuntu 22.04 will ship wpasupplicant 2.10 it would be good to have this patch.

When you sync the changes from Debian, a few remarks on the remaining diff to the Debian package:

- isc-dhcp-client Depends
NetworkManager defaults to its internal dhcp client (based on sd-network) since a while. Ubuntu doesn't override that default. So either it should explicitly override that default and specify dhclient as preferred dhcp client or it should drop this dependency as Debian does (or at least demote it).

- avahi-autoipd Suggests
NetworkManager doesn't use avahi-autoipd anymore. See the relevant commit from 2016!
https://salsa.debian.org/utopia-team/network-manager/-/commit/d701201bfd5b2d7a6bb1cc81660ae55fd4f4e36b

- lto
Enabling lto means significantly increased build times. Last time I checked the space savings were miniscule. That's why the Debian doesn't enable lto.

- restarting NM on upgrades
NM does *not* tear down Ethernet connections on restart. For WiFi connections the situation is different but keep in mind that wpasupplicant.postinst will restart its service anyway

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks for the report Michael!

Changed in network-manager (Ubuntu):
importance: Undecided → High
status: New → In Progress
status: In Progress → Fix Committed
Revision history for this message
Sebastien Bacher (seb128) wrote :

I've merged the changes and uploaded.

Thanks also for review the package delta, we will check those more in details and remove some of the delta but probably at the start of next cycle at this point.

About LTO it's part of our default toolchain now, https://wiki.ubuntu.com/ToolChain/LTO and I think our default position is that it should be enable unless there is a valid reason to not do it which doesn't seem to be the case there? Note that there is a proposal for Debian to do the same on https://wiki.debian.org/ToolChain/LTO but I don't know what's the status

Revision history for this message
Michael Biebl (mbiebl) wrote :

If it's enabled in the toolchain, is there still a need to explicitly enable it (like in this case via --enable-lto) in individual packages?

Revision history for this message
Michael Biebl (mbiebl) wrote :

thanks a lot for the quick upload.
Now that wpasupplicant 2.10 is more widely available, I've seen this issue popping up at several places. I'm not sure if it's only related to FRITZ!Boxes but those alone are extremely popular in Germany, so I would have hated if the next LTS potentially breaks WiFi for lots of users.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package network-manager - 1.36.4-2ubuntu1

---------------
network-manager (1.36.4-2ubuntu1) jammy; urgency=medium

  * Cherry pick WPA3 fixes from Debian, thanks Michael Biebl! (lp: #1967782)

 -- Sebastien Bacher <email address hidden> Tue, 05 Apr 2022 15:28:36 +0200

Changed in network-manager (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.