Ubuntu
ubiquity package

ubiquity 20.04.15.17 fails to build (test_timezone)

Bug #1951519 reported by Ark74
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
tzdata (Ubuntu)
Invalid
High
Unassigned
Focal
Invalid
High
Unassigned
Jammy
Invalid
High
Unassigned
ubiquity (Ubuntu)
Fix Released
High
Unassigned
Focal
Fix Released
High
Brian Murray
Ubuntu ubuntu-20.04.4
Jammy
Fix Released
High
Unassigned

Bug Description

Description: Ubuntu 20.04.3 LTS
Release: 20.04

When trying to build ubiquity from source,

sudo apt update
sudo apt -y dist-upgrade
sudo apt-get build-dep ubiquity
sudo apt install -y fakeroot
apt source ubiquity
cd ubiquity-*
dpkg-buildpackage -us -uc
[...]
test_has_battery (test_upower.UPowerTests) ... ok
test_check_hostname (test_usersetup.UserSetupTests) ... ok
test_check_username (test_usersetup.UserSetupTests) ... ok
test_default_username (test_usersetup.UserSetupTests) ... ok
test_default_username_strips_invalid_characters (test_usersetup.UserSetupTests) ... ok
test_hostname_check (test_usersetup.UserSetupTests) ... ok
test_hostname_check_bogus_dns (test_usersetup.UserSetupTests) ... ok
test_hostname_check_exists (test_usersetup.UserSetupTests) ... ok
test_unicode (test_usersetup.UserSetupTests) ... ok

======================================================================
FAIL: test_city_entry (test_timezone.TimezoneTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/mock/mock.py", line 1330, in patched
    return func(*args, **keywargs)
  File "/home/ark/ubiquity-20.04.15.17/tests/test_timezone.py", line 58, in test_city_entry
    self.assertEqual(set(results), set(expected))
AssertionError: Items in the first set but not the second:
('Eastern', 'Bahamas')
Items in the second set but not the first:
('Eastern', 'Canada')

----------------------------------------------------------------------
Ran 89 tests in 19.319s

FAILED (failures=1)
xauth/Xrdb output:
make: *** [debian/rules:228: tests] Error 1
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

It keeps failing regardless of release.

See original description
Ark74 (ark74)
description: updated
description: updated
Ark74 (ark74)
description: updated
Revision history for this message
Ark74 (ark74) wrote :

Seems like this is not the first time this happens,

https://answers.launchpad.net/ubuntu/+source/ubiquity/+question/246972

Ark74 (ark74)
summary: - ubiquity fails to build (test_timezone)
+ ubiquity 20.04.15.17 fails to build (test_timezone)
Revision history for this message
Ark74 (ark74) wrote :

this issue was because of the tzdata update, which broke the test case.

Editing that one will allow to build.
Thanks

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in ubiquity (Ubuntu):
status: New → Confirmed
Erich Eickmeyer (eeickmeyer)
Changed in tzdata (Ubuntu):
status: New → Confirmed
Revision history for this message
Erich Eickmeyer (eeickmeyer) wrote :

Confirmed this issue as attempt was made for an OEM and failed. See build log at https://launchpadlibrarian.net/574391158/buildlog_ubuntu-focal-amd64.ubiquity_20.04.15.17+kfocus2_BUILDING.txt.gz

Changed in ubiquity (Ubuntu Focal):
status: New → Confirmed
Changed in ubiquity (Ubuntu Jammy):
status: Confirmed → New
Changed in tzdata (Ubuntu Focal):
status: New → Confirmed
Changed in tzdata (Ubuntu Jammy):
status: Confirmed → New
tags: added: rls-ff-incoming rls-jj-incoming
Matthieu Clemenceau (mclemenceau)
tags: added: fr-1943
Brian Murray (brian-murray)
tags: removed: rls-ff-incoming rls-jj-incoming
Changed in tzdata (Ubuntu Focal):
importance: Undecided → High
Changed in tzdata (Ubuntu Jammy):
importance: Undecided → High
Changed in ubiquity (Ubuntu Focal):
importance: Undecided → High
Changed in ubiquity (Ubuntu Jammy):
importance: Undecided → High
Brian Murray (brian-murray)
Changed in tzdata (Ubuntu Jammy):
status: New → Invalid
Changed in ubiquity (Ubuntu Jammy):
status: New → Invalid
Revision history for this message
Brian Murray (brian-murray) wrote :

The tzdata update included a change to the Bahamas which has them following the US East Coast time zone for DST information.

Changed in tzdata (Ubuntu Focal):
status: Confirmed → Invalid
Changed in ubiquity (Ubuntu Focal):
status: Confirmed → In Progress
assignee: nobody → Brian Murray (brian-murray)
Revision history for this message
Brian Murray (brian-murray) wrote :

ubiquity (22.04.3) jammy; urgency=medium

  * tests/test_timezone.py:
    - update for changes in the new tzdata

 -- Sebastien Bacher <email address hidden> Tue, 23 Nov 2021 23:37:23 +0100

Changed in ubiquity (Ubuntu Jammy):
status: Invalid → Fix Released
Brian Murray (brian-murray)
Changed in ubiquity (Ubuntu Focal):
milestone: none → ubuntu-20.04.4
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Ark74, or anyone else affected,

Accepted ubiquity into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubiquity/20.04.15.18 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in ubiquity (Ubuntu Focal):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-focal
Revision history for this message
Brian Murray (brian-murray) wrote :

The package built fine so I'm setting this to verification done.

tags: added: verification-done verification-done-focal
removed: verification-needed verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubiquity - 20.04.15.18

---------------
ubiquity (20.04.15.18) focal; urgency=medium

  * ubi-partman.py: Do not display a restart button in the advanced
    partitioning screen when installing alongside Windows Boot Manager. Thanks
    to Sam van Kampen for the patch. (LP: #1942648)
  * tests/test_timezone.py: The Bahamas moved their DST rules to sync with the
    U.S. in 2007 but tzdata only recently incorporated this change.
    (LP: #1951519)
  * Automatic update of included source packages: shim-signed 1.40.7.

 -- Brian Murray <email address hidden> Mon, 10 Jan 2022 10:39:31 -0800

Changed in ubiquity (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for ubiquity has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.