Ubuntu
fityk package

Desktop file doesn't validate and uses wrong category

Bug #182839 reported by Phil Bull on 2008-01-14

Affects		Status	Importance	Assigned to	Milestone
	fityk (Ubuntu)	Fix Released	Wishlist	Andrea Colangelo

Bug Description

Binary package hint: fityk

The .desktop file installed by Fityk doesn't validate using desktop-file-validate. It also uses the "Office" category, which is inappropriate (it's a scientific data analysis package).

$ desktop-file-validate /usr/share/applications/fityk.desktop

/usr/share/applications/fityk.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated
/usr/share/applications/fityk.desktop: error: value "fityk.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path

$ cat /usr/share/applications/fityk.desktop | grep Categories
Categories=Science;Office;DataVisualization;GTK;

Version: fityk 0.8.2-1 (hardy)

Tags:

Related branches

lp:ubuntu/lucid/fityk

Revision history for this message

Phil Bull (philbull) wrote on 2008-01-14:

Updated desktop file Edit (239 bytes, text/plain)

Updated .desktop file:

* Validates
* Removes "Office" category
* Capitalises first letter of comment

Revision history for this message

Marcin Wojdyr (wojdyr) wrote on 2008-01-14:

Thanks, I updated it upstream, with exception of Categories.

According to: http://standards.freedesktop.org/menu-spec/latest/apa.html
"Additional Categories should always be used in combination with one of the Main Categories.",
and Science;DataVisualization;GTK; are "additional" categories. That's why I added Office.

Marco Rodrigues (gothicx) on 2008-01-14

Changed in fityk:
importance:	Undecided → Wishlist
status:	New → Confirmed

Revision history for this message

Phil Bull (philbull) wrote on 2008-01-14:

Thanks Marcin.

In GNOME, packages with the Science category tend to get put into the Education menu, so it might be better to use Education instead of Office in this case. Also, Science seems to be a sub-category of Education in the Freedesktop spec.

Revision history for this message

David Futcher (bobbo) wrote on 2008-08-06:

fityk_0.8.6-1ubuntu1.debdiff Edit (1.5 KiB, text/plain)

Debdiff to include Phil Bull's new .desktop file (thanks Phil!). Builds fine in an Intrepid chroot.

Andrea Colangelo (warp10) on 2008-08-07

Changed in fityk:
assignee:	nobody → warp10
status:	Confirmed → In Progress

Revision history for this message

Andrea Colangelo (warp10) wrote on 2008-08-07:

David, remember to wrap the changelog lines at 80 chars. Mind sending this patch to Debian too?
BTW, uploading now, thanks ;-)

Revision history for this message

Launchpad Janitor (janitor) wrote on 2008-08-07:

This bug was fixed in the package fityk - 0.8.6-1ubuntu1

---------------
fityk (0.8.6-1ubuntu1) intrepid; urgency=low

* debian/fityk.desktop: Fix validation errors (LP: #182839) (Thanks to Phil
Bull)

-- David Futcher <email address hidden> Fri, 02 May 2008 00:54:09 -0500

Changed in fityk:
status:	In Progress → Fix Released

Revision history for this message

Marcin Wojdyr (wojdyr) wrote on 2008-08-07:

FWIW: this was fixed upstream long time ago (a few hours after Phil filed this bug), so IMO the best fix would be to use fityk.desktop from the source tarball instead of debian/fityk.desktop.