Alltray fails to set window title with Compiz/Emerald and --no-alltray command line option.

To apply this patch, simply:

 $ apt-get source alltray
 $ cat path/to/patch | patch -p0

Would like review on this patch, as it is the first that I have written for Ubuntu or for any project other than web stuff. If this patch is acceptable, it should probably be released in Gutsy and definitely released in Hardy.

Here is a debdiff to update a source package from the Ubuntu repos to the testing version that I have created. The problem with my prior patch was that it triggered a CPU-hungry infinite loop for non-compiz WMs which was not desired, obviously. This fixes that, and thus the original issue reported here in a desirable fashion.

Is this still relevant in Hardy? If so, it'd be nice to update the debdiff and submit it for review (http://wiki.ubuntu.com/SponsorshipProcess)

On Mon, 2008-01-28 at 15:30 +0000, Daniel Holbach wrote:
> Is this still relevant in Hardy? If so, it'd be nice to update the
> debdiff and submit it for review
> (http://wiki.ubuntu.com/SponsorshipProcess)

I will check in Hardy within the next day or so and let you know. I
have to install Hardy onto my other partition before I can do that. :)

 --- Mike

--
Michael B. Trausch <email address hidden>
home: 404-592-5746, 1 www.trausch.us
cell: 678-522-7934 im: <email address hidden>, jabber
Ubuntu Unofficial Backports Project: http://backports.trausch.us/

Yes, this is still an issue in Hardy.

Am looking at the process to get the fix in now.

Daniel: ppaput seems broken in Hardy. Is this easily fixable so that I can follow the remainder of the instructions on https://wiki.ubuntu.com/SponsorshipProcess/ppaput ?

I think I managed to get this right without the ppaput utility. I am not 100% sure if I am understanding the processes right for this, though. I did confirm that this patch works using the instructions on https://wiki.ubuntu.com/MOTU/Sponsorship/SponsorsQueue under the section "Notes for Contributors". I have tested and built the resulting package with this debdiff and it is as I have been using it now for a while (since I found the original fix in Gutsy).

What I did was created a patch file in debian/patches and altered debian/rules to patch the source immediately before building. This package doesn't use CDBS, so I added a patch line manually. I am not sure if this was the correct thing to do, but I am under the understanding that changes that are specific to Ubuntu should be kept separate from the actual source itself—this was what seemed like the best way to do that without converting the entire thing to using CDBS, which I would not have the slightest clue how to do just yet anyway.

Setting to confirmed for pending review per https://wiki.ubuntu.com/MOTU/Sponsorship/SponsorsQueue

Attaching diff for just the source files which may be used by upstream

Ignore the last one; attached to wrong bug. :(

* Version must be 0.69-1ubuntu1
* You should adjust Maintainer field as described in https://wiki.ubuntu.com/DebianMaintainerField.
* Mind adopting a standard patch system to apply your patch? dpatch or quilt are good, see https://wiki.ubuntu.com/PackagingGuide/PatchSystems for further references.

Please resubscribe ubuntu-universe-sponsors when you have a new debdiff. Thanks!

Attaching the updated debdiff as requested:

alltray (0.69-1ubuntu1) hardy; urgency=low

  * Work around issues with Compiz window manager and display of
    window titles (LP: #178541)
  * Modify Maintainer value to match the DebianMaintainerField
    specification.
  * Add dpatch to build-depends in debian/control.
  * Modify debian/rules to use dpatch.
  * Modify alltray.desktop comment to be more descriptive and thus useful.

 -- Michael B. Trausch <email address hidden> Mon, 03 Mar 2008 22:17:28 -0500

Confirming bug and dropping assignment prior to re-subscribing ubuntu-universe-sponsors.

I know that time is running low on getting fixes into Hardy and everything, and there are probably far, far more important things to look at... but is there a chnace that this can be looked at so that I can re-submit changes if necessary?

This bug was fixed in the package alltray - 0.69-1ubuntu1

---------------
alltray (0.69-1ubuntu1) hardy; urgency=low

  [ Michael B. Trausch ]
  * Work around issues with Compiz window manager and display of
    window titles (LP: #178541)
  * Modify Maintainer value to match the DebianMaintainerField
    specification.
  * Add dpatch to build-depends in debian/control.
  * Modify debian/rules to use dpatch.
  * Modify alltray.desktop comment to be more descriptive and thus useful.

  [ Daniel Hahler ]
  * Fix "No windows hiding with compiz" (LP: #106583)
    - 02-fix-compiz-windows-select.dpatch, provided by "AZ"
    - There are still issues with compiz and alltray, but this patch makes it
      better
  * debian/control:
    - Standards-Version 3.7.3
    - Moved Homepage from desc to field
  * debian/rules:
    - Fix debian-rules-ignores-make-clean-error (lintian)

 -- Daniel Hahler <email address hidden> Sat, 22 Mar 2008 00:26:48 +0100