Trusty kexec-tools suffer from upstream code regression. Fix not included.

Bug #1705054 reported by Rafael David Tinoco
18
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kexec-tools (Ubuntu)
Fix Released
Medium
Unassigned
Trusty
Fix Released
Medium
Rafael David Tinoco

Bug Description

[Impact]

 * kdump doesn't work on non-efi systems
 * a kernel dump can't be generated

[Test Case]

 * install kdump-tools
 * configure kdump-tools (/etc/default/kdump-tools)
 * try to start kdump-tools service (kdump-config start)
 * while executing kexec, you will get:
   "efi memory descriptor version 0 is not supported!"

[Regression Potential]

 * in theory it could brake kdump for efi systems
 * in practice, its based on upstream regression fix (not included in Trusty)
 * it has also been tested in 3 different setups and it worked

[Other Info]

Based on upstream code commit explanation:

"""
On non-EFI systems, efi_info section of boot_params is zero filled resulting
in an erroneous message from kexec regarding "efi memory descriptor" version.

Caused by commit: e1ffc9e9a0769e1f54185003102e9bec428b84e8 "Passing efi related
data via setup_data"

# od -j 448 -N 32 -v -x /sys/kernel/boot_params/data
0000700 0000 0000 0000 0000 0000 0000 0000 0000
0000720 0000 0000 0000 0000 0000 0000 0000 0000
0000740

# kexec -l --reuse-cmdline --initrd=/boot/initrd-`uname -r` /boot/vmlinuz-`uname -r`
efi memory descriptor version 0 is not supported!
"""

It was brought to my attention to some of our users are facing this:

----
## TRUSTY with kernel 4.4.0-83-generic

# /usr/sbin/kdump-config load
efi memory descriptor version 0 is not supported!
* loaded kdump kernel

/var/log/syslog:

Jul 18 13:37:06 xxxx kdump-config: /sbin/kexec -p --command-line="BOOT_IMAGE=/boot/vmlinuz-4.4.0-83-generic root=UUID=xxxxxxxx-20e4-4325-ad92-7aef2af0beac ro KDUMP_CMDLINE_APPEND=irqpoll maxcpus=1 nousb irqpoll maxcpus=1 nousb" --initrd=/boot/initrd.img-4.4.0-83-generic /boot/vmlinuz-4.4.0-83-generic
Jul 18 13:37:06 xxxx kdump-config: loaded kdump kernel
----

Despite the message of kdump being loaded, it doesn't look that it is operational. Dump files could be generated using Xenial kdump-tools, but not Trusty's.

Changed in kexec-tools (Ubuntu):
importance: Undecided → Medium
status: New → Confirmed
assignee: nobody → Rafael David Tinoco (inaddy)
Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

I'm providing the following PPA;

https://launchpad.net/~inaddy/+archive/ubuntu/lp1705054

with a test package in order to verify if the patch fixes the issue.

tags: added: sts
Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "trusty_kexec-tools_2.0.6-0ubuntu2.3.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
description: updated
tags: added: sts-sponsor
removed: patch
Revision history for this message
Eric Desrochers (slashd) wrote :

Hi Rafael,

The Trusty debdiff has been uploaded in the Trusty upload queue[1], and now waiting for the SRU verification team to approve the upload for the package to start building in trusty-proposed.

[1] - https://launchpad.net/ubuntu/trusty/+queue?queue_state=1&queue_text=kexec-tools

Eric

Changed in kexec-tools (Ubuntu Trusty):
status: New → In Progress
assignee: nobody → Rafael David Tinoco (inaddy)
importance: Undecided → Medium
tags: added: sts-sponsor-done sts-sru-needed
removed: sts-sponsor
Eric Desrochers (slashd)
Changed in kexec-tools (Ubuntu):
status: Confirmed → Fix Released
assignee: Rafael David Tinoco (inaddy) → nobody
Revision history for this message
Dave Chiluk (chiluk) wrote :

@slashd beat me to the upload, but it looks good to me.

Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

Hey Dave, nice to read from you. User has tested and confirmed it worked. I'll wait for verification. Tks for reviewing it!

Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Rafael, or anyone else affected,

Accepted kexec-tools into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/kexec-tools/1:2.0.6-0ubuntu2.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-trusty to verification-done-trusty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-trusty. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in kexec-tools (Ubuntu Trusty):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-trusty
Revision history for this message
Eric Desrochers (slashd) wrote :

## VERIFICATION TRUSTY ###

I was easily able to reproduce the situation explained by Rafael above using Trusty with the "kexec-tools" package prior to version "2.0.6-0ubuntu2.3".

I confirm the situation is fix now with "2.0.6-0ubuntu2.3".

[Confirmation]

# release
root@ubuntu:~# cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=14.04
DISTRIB_CODENAME=trusty
DISTRIB_DESCRIPTION="Ubuntu 14.04.5 LTS"

# dpkg
ii kexec-tools 1:2.0.6-0ubuntu2.3 amd64 tools to support fast kexec reboots

# Reproducer output :
root@ubuntu:~# kexec -l --reuse-cmdline --initrd=/boot/initrd.img-`uname -r` /boot/vmlinuz-`uname -r`

root@ubuntu:~# /usr/sbin/kdump-config load
 * loaded kdump kernel

- Eric

tags: added: verification-done-trusty
removed: verification-needed-trusty
tags: removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package kexec-tools - 1:2.0.6-0ubuntu2.3

---------------
kexec-tools (1:2.0.6-0ubuntu2.3) trusty; urgency=medium

  * Fixes non-efi systems, upstream code regression not present (LP: #1705054)

 -- Rafael David Tinoco <email address hidden> Tue, 18 Jul 2017 15:11:24 +0000

Changed in kexec-tools (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for kexec-tools has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.