Comment 100 for bug 691380

(In reply to comment #95)
> a) I was wondering if we can just incude a "global search" toggle button
> on the horizontal bar, with the same behaviour as in the dropdown (all
> quickfilter options on criteria bar will be disabled in global mode),
> like this:
> +------------------------------------------------------------------------------+
> | Quick filter: ## ## ## ## ## | Sender Recipients Subject Body | Global
> search|
> +------------------------------------------------------------------------------+

Yes, that was exactly what I had imagined... but... if you select 'Global search', then the 'Quick filter' label to the left is inappropriate - that was my point.

> b) Another possibility: Make the global search button act like a command
> button instead of toggling modes.
> - normally you toggle filter buttons on bar to narrow down / expand scope
> - at any time, after entering your search words, you could press "global
> search" command button for immediate ultimate expansion of scope in a new tab

Actually, I think you're right and that would be best.

>> 3. Not sure what is meant by this:
>> "Important: Even without 'Global search' toggle element,

> c) Even if we do not include "Global Search Mode" as a toggle button

<snip> ok, understood, thanks for the clarification.

> d) I'd go for as few changes to current behaviour as possible, in our own
> interest.

Agreed...

>> Whew - I really didn't mean to complicate it that much... ;)

> g) It's very important that the UI / behaviour doesn't get too complex:
> - too much complexity / too many options can be confusing and counter-
> intuitive
> - we need an intuitive default behaviour (which should be the focus of this
> bug)
> - even justified complexity is harder to code, thus reduces our chances to
> actually get this implemented
>
> If we want any options in primary UI, they need to be completely transparent
> and intuitive. For anything more complex, consider a separate tab in the main
> application options: e.g. Tools > Options > Display > *Search & Filter*

Agreed again - but one last question... you said:

> - when there are no filter results, we keep the current functionality
> that pressing Enter a second time will automatically trigger a global
> search on the failed filter words (in 3.1 indicated by tooltip
> "Continue this search across all folders: Press Enter again to continue
> your search for <search terms>"). If the first Enter wasn't pressed
> very fast after typing filter, it will trigger the global search already.

While I grok the way this works, to me, what would be more intuitive is what I described earlier about additional visual feedback directly in the message list pane, that no one has commented on yet - specifically (I tweaked it a bit here):

*** ... have a "0 of the 5,348 messages in this folder match your current filter
criteria." - or something like it - directly in the message list pane to
eliminate any further room for confusion. You could even add 2 big 'Clear
Filters' and 'Perform Global Search' buttons in the message list pane.

Also - there could be an (optional?) highly contrasted 'filter results line' always displayed at the very top of/inside the message list pane, saying something like: "25 of the 5,348 messages in this folder match your current filter criteria.", whenever there is at least one result. ***

This way, there is never any question about whether or not a filter is being applied.

Just opened bug 583726 to formalize/track the above visual cue enhancements (also uploaded quick-n-dirty screenshot mock-ups)

>> Thanks again Thomas!

> h) My pleasure, and a lot of time. I'll have to cut down on this.
> Btw, I will *not* have the time to dig myself so deeply into TB
> internals that I could actually implement this. But the mockup code
> will certainly help to get this started. We should try and convince
> TB devs that this is needed as a fallback as explained in comment
> 49, last but one paragraph, so they might do it themselves. Otherwise,
> we'll have to find someone to code this.

I for one am *extremely* grateful to you for taking the time to do the mockups, as I think it will get the point across so much better than my lengthy/detailed description that some/most (all?) of the devs may not have taken the time to read/understand. I love the final result, and also hope someone with the skills and time will step up.