Comment 9 for bug 448095

Revision history for this message
Sander van Grieken (sander-vangrieken) wrote :

Hmm yeah I wasn't really clear in my prev post.

It definately obsoletes the old sysv init script, which should be removed.

The initialisation part is the most essential and moved to the upstart script. The other actions on the init script are really nothing more than calling (or not) 'update' on resolvconf, but as you can see from /sbin/resolvconf and /etc/init.d/resolvconf there is duplicated code there (and should all be moved to /sbin/resolvconf).

But you are right about the 'update -i', that should be added to the upstart script at initialisation.

You are also right about the difference in the old init script about boot-time start and service-restart later. A restart on the old initscript merely calls update. But since I know hardly any upstart specifics I don't know how to define the difference between init() and start() precisely.

The move to /lib/init/rw makes the difference less important though, since /lib/init/rw is clean after each boot, since it's not persistent. When using /etc/resolvconf/run you might encounter leftovers from previous boots, but with /lib/init/rw we could just create the resolvconf structure if it's not there yet, and have subsequent calls to stop/start/restart mimic the old initscript behaviour.

I can make a more complete upstart script if anyone's interested?