Comment 27 for bug 331369

Revision history for this message
David Barth (dbarth) wrote :

Freeze exception request.

Description of the proposed changes:

The change is about fixing a bug where the advanced multi-head configuration mode was not working.

Rationale for the exception:

What this mode should do is allow people with multiple monitors to (optionally) see notifications being displayed on the monitor that contains the active window, as opposed to seeing them always on the monitor that contains the top gnome-panel (this is the default behavior).

With this change, we would like to fix the last remaining high priority bug for notify-osd, and a potential regression vs notification-daemon at the same time.

We feel the change is safe in that:
 * it is a 1 line patch for fixing a bug
 * it does activate a code path with no error cases forks, nor any other object lifecycle issues (potential leaks)
 * it does not trigger any additional (potentially untested) queries to external sub-systems like gconf; that was already the case before the fix

Additional information:

The fix has been integrated in a new tarball (notify-osd-0.9.12) that contains this fix:

=== modified file 'src/defaults.c'
--- src/defaults.c 2009-04-03 22:00:34 +0000
+++ src/defaults.c 2009-04-10 09:54:05 +0000
@@ -2072,7 +2072,7 @@
          &error);
  if (mode_str != NULL)
  {
- if (g_strcmp0 (mode_str, "focus-follow"))
+ if (! g_strcmp0 (mode_str, "focus-follow"))
    mode = TRUE;
  } else if (error != NULL)
   g_warning ("error getting multihead mode: %s\n",