Comment 5 for bug 371402

Revision history for this message
Alexander Sack (asac) wrote :

this regression was introduced by commit 5d2b36b9c4b8da6532f2548e828e653f1c42a0f4

git diff 5d2b36b9c4b8da6532f2548e828e653f1c42a0f4^ 5d2b36b9c4b8da6532f2548e828e653f1c42a0f4
diff --git a/ChangeLog b/ChangeLog
index f8bc56e..b36b916 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2009-02-06 Dan Williams <email address hidden>
+
+ Patch from Russell Suter <email address hidden>
+
+ * properties/advanced-dialog.c
+ - (advanced_dialog_new_hash_from_dialog): fix saving MPPE values
+
 2008-12-13 Przemysław Grzegorczyk <email address hidden>

        * src/nm-pptp-pppd-plugin.c:
diff --git a/properties/advanced-dialog.c b/properties/advanced-dialog.c
index dfd43df..0e1368b 100644
--- a/properties/advanced-dialog.c
+++ b/properties/advanced-dialog.c
@@ -385,10 +385,11 @@ advanced_dialog_new_hash_from_dialog (GtkWidget *dialog, GError **error)
                        g_hash_table_insert (hash, g_strdup (NM_PPTP_KEY_REQUIRE_MPPE_40), g_strdup ("yes"));
                        break;
                default:
- g_hash_table_insert (hash, g_strdup (NM_PPTP_KEY_REQUIRE_MPPE), g_strdup ("yes"));
                        break;
                }

+ g_hash_table_insert (hash, g_strdup (NM_PPTP_KEY_REQUIRE_MPPE), g_strdup ("yes"));
+
                widget = glade_xml_get_widget (xml, "ppp_allow_stateful_mppe");
                if (gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (widget)))
                        g_hash_table_insert (hash, g_strdup (NM_PPTP_KEY_MPPE_STATEFUL), g_strdup ("yes"));

backing that out of network-manager-pptp would fix it for you. Have to check why that was accepted as a bugfix.