Comment 3 for bug 482753

Revision history for this message
Martin Eve (martineve) wrote :

Hi,

This patch doesn't actually change the input passed to scp, but rather alters the way that scp completes on the bash prompt.

For example, say on the remote server I have:

~/Hello Folder One
~/Hello Folder Two
~/Hello Different Three

Typing:

scp -r remote:~/Hell[TAB]

will result, with this patch with:

scp -r remote:~/Hello\\\

Now, in the old system if you then went:

scp -r remote:~/Hello\\\ F[TAB]

Nothing would happen. The \\\ was incorrectly handled when asking for a directory listing to then parse with sed.

With the patch, the prompt now reads:

scp -r remote:~/Hello\\\ Folder\\\

as would be expected, and you can continue.

Once the line is complete (scp -r remote:~/Hello\\\ Folder\\\ O[TAB] -> scp -r remote:~/Hello\\\ Folder\\\ One) you can press enter and the scp action will continue correctly (because the line still uses \\\)

tl;dr: the patch keeps \\\ on the command line, but just parses them correctly when it tries to get a remote directory listing