You say "overescapes", but scp is buggy at a protocol level and actually does require this double-escaping. Demonstration:
<cjwatson@riva ~>$ touch 'file with spaces'
<cjwatson@sarantium ~>$ scp riva:file\ with\ spaces .
scp: file: No such file or directory
scp: with: No such file or directory
scp: spaces: No such file or directory
<cjwatson@sarantium ~>$ scp riva:file\\\ with\\\ spaces .
file with spaces 100% 0 0.0KB/s 00:00
Are you quite sure that your patch is correct, in light of this?
You say "overescapes", but scp is buggy at a protocol level and actually does require this double-escaping. Demonstration:
<cjwatson@riva ~>$ touch 'file with spaces' sarantium ~>$ scp riva:file\ with\ spaces . sarantium ~>$ scp riva:file\\\ with\\\ spaces .
<cjwatson@
scp: file: No such file or directory
scp: with: No such file or directory
scp: spaces: No such file or directory
<cjwatson@
file with spaces 100% 0 0.0KB/s 00:00
Are you quite sure that your patch is correct, in light of this?