Memory leak in IndicatorObjectEntryProxyRemote::GetPixbuf

Bug #816632 reported by Chow Loong Jin
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Unity
Invalid
Undecided
Unassigned
unity (Ubuntu)
Invalid
Undecided
Unassigned
Natty
Fix Released
Undecided
Unassigned

Bug Description

In IndicatorObjectEntryProxyRemote::GetPixbuf(), a GMemoryInputStream is created and closed, but not properly g_object_unref()-ed.

I've only checked this with the Unity in natty-updates. I believe the oneiric one has done away with the affected code and is not affected by this bug.

Steps to reproduce:
1. Start up indicator-multiload
2. Set the indicator-multiload update interval to something really short, say 500 ms.
3. Wait 24h or so.
4. Check the memory usage of Compiz (~300-400M)

Related branches

Revision history for this message
Chow Loong Jin (hyperair) wrote :

Patch to fix this memory leak. Verified from local testing to work.

description: updated
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Fixed in unity trunk.

Changed in unity:
status: New → Invalid
Changed in unity (Ubuntu):
status: New → Invalid
status: Invalid → New
Changed in unity (Ubuntu):
status: New → Fix Committed
Revision history for this message
Omer Akram (om26er) wrote :

i have an sru branch for Natty already if you could propose this fix to lp:unity3.0 (I could do that too) we can get this SRU'ed soonish as well

Revision history for this message
Omer Akram (om26er) wrote :

(missed you already had Ubuntu SRU sponsered)

Revision history for this message
Dave Walker (davewalker) wrote :

Currently in the unapproved queue awaiting SRU processing, removing ubuntu-sponsors subscription.

Thanks.

Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Hi Omer! The upload looks good, *except* the addition of

--- unity-3.8.16.orig/.bzrignore.THIS
+++ unity-3.8.16/.bzrignore.THIS

Please re-upload without this extra file and we should be able to accept it into natty-proposed.

Changed in unity (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Also please add a basic SRU report to this bug, per

https://wiki.ubuntu.com/StableReleaseUpdates

Changed in unity (Ubuntu Natty):
status: New → Triaged
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Hello Chow, or anyone else affected,

Accepted unity into natty-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in unity (Ubuntu Natty):
status: Triaged → Fix Committed
tags: added: verification-needed
Revision history for this message
Simon Déziel (sdeziel) wrote :

I'm not 100% sure if it's related to this bug but since I upgraded to unity 3.8.16-0ubuntu1~natty3 I have trouble with my external LCD screen.

I can get to the login prompt but once authenticated, the screen goes black. When this occurs, I still can have my display back if I unplug my external monitor, my laptop's screen goes on and all work fine on this screen (except that some applets failed to load the first time).

Note that I normally only use my external monitor as my primary and my laptop's screen is turned off by default. This seems to trigger the bug. I was able to find workaround to have my external LCD working :

# Set my external LCD as primary
$ xrandr --output VGA1 --primary

# Turn off laptop's screen
$ xrandr --output LVDS1 --off

Revision history for this message
Chow Loong Jin (hyperair) wrote : Re: [Bug 816632] Re: Memory leak in IndicatorObjectEntryProxyRemote::GetPixbuf

On 13/10/2011 23:23, Simon Déziel wrote:
> I'm not 100% sure if it's related to this bug but since I upgraded to
> unity 3.8.16-0ubuntu1~natty3 I have trouble with my external LCD screen.
>
> I can get to the login prompt but once authenticated, the screen goes
> black. When this occurs, I still can have my display back if I unplug my
> external monitor, my laptop's screen goes on and all work fine on this
> screen (except that some applets failed to load the first time).
>
> Note that I normally only use my external monitor as my primary and my
> laptop's screen is turned off by default. This seems to trigger the bug.
> I was able to find workaround to have my external LCD working :
>
> # Set my external LCD as primary
> $ xrandr --output VGA1 --primary
>
> # Turn off laptop's screen
> $ xrandr --output LVDS1 --off
>

It's probably not this bug. The fix for this bug is a one-liner that has no
visual impact at all. You should try downgrading to 3.8.16-0ubuntu1~natty2 and
seeing if the issue still persists. natty3 fixes bug #761409 as well, but I
don't think your issue is related to that either.

--
Kind regards,
Loong Jin

Revision history for this message
Simon Déziel (sdeziel) wrote :

@Chow, you are right as downgrading to 3.8.16-0ubuntu1~natty2 didn't help. Thanks for your help.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity - 3.8.16-0ubuntu1~natty3

---------------
unity (3.8.16-0ubuntu1~natty3) natty-proposed; urgency=low

  * src/PanelTray.cpp:
  * src/PanelTray.h:
    - make systray behave nice when the whitelist is on (LP: #761409)
  * src/IndicatorObjectEntryProxyRemote.cpp:
    - Fix leak of GMemoryInputStream. (thx hyperair) (LP: #816632)
 -- Omer Akram <email address hidden> Tue, 06 Sep 2011 00:09:33 +0500

Changed in unity (Ubuntu Natty):
status: Fix Committed → Fix Released
Changed in unity (Ubuntu):
status: Fix Released → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.