dist-upgrader fails with "FstabEntry(*line.split()) TypeError: __init__() takes exactly 7 arguments (5 given)" if fs_freq and fs_passno fields not present in fstab entry

Bug #806065 reported by Per-Inge
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
update-manager (Ubuntu)
Fix Released
High
Canonical Foundations Team
Oneiric
Fix Released
High
Canonical Foundations Team

Bug Description

/var/log/dist-upgrade/apt.log
/var/log/dist-upgrade/main.log
/var/log/dist-upgrade/term.log

Tags: iso-testing
tags: added: iso-testing
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

Thanks for taking the time to report this bug and helping to make Ubuntu better. Could you please add the log files from '/var/log/dist-upgrade/' to this bug report as separate attachments? Thanks in advance.

Changed in update-manager (Ubuntu):
status: New → Incomplete
Revision history for this message
Per-Inge (per-inge-hallin) wrote :
Revision history for this message
Per-Inge (per-inge-hallin) wrote :
Revision history for this message
Per-Inge (per-inge-hallin) wrote :

term.log is empty

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

Thanks for the logs.

From the error
2011-07-05 18:20:31,204 ERROR IOError in cache.commit(): 'Failed to fetch http://se.archive.ubuntu.com/ubuntu/pool/universe/x/xserver-xorg-video-voodoo/xserver-xorg-video-voodoo_1.2.4-2_amd64.deb 403 Forbidden [IP: 130.239.18.173 80]
Failed to fetch http://se.archive.ubuntu.com/ubuntu/pool/universe/x/xserver-xorg-video-tseng/xserver-xorg-video-tseng_1.2.4-2_amd64.deb 403 Forbidden [IP: 130.239.18.173 80]
Failed to fetch http://se.archive.ubuntu.com/ubuntu/pool/universe/x/xserver-xorg-video-s3virge/xserver-xorg-video-s3virge_1.10.4-4_amd64.deb 403 Forbidden [IP: 130.239.18.173 80]
Failed to fetch http://se.archive.ubuntu.com/ubuntu/pool/universe/x/xserver-xorg-video-i128/xserver-xorg-video-i128_1.3.4-2_amd64.deb 403 Forbidden [IP: 130.239.18.173 80]
Failed to fetch http://se.archive.ubuntu.com/ubuntu/pool/universe/x/xserver-xorg-video-chips/xserver-xorg-video-chips_1.2.4-1_amd64.deb 403 Forbidden [IP: 130.239.18.173 80]
Failed to fetch http://se.archive.ubuntu.com/ubuntu/pool/universe/x/xserver-xorg-video-ark/xserver-xorg-video-ark_0.7.3-2_amd64.deb 403 Forbidden [IP: 130.239.18.173 80]
Failed to fetch http://se.archive.ubuntu.com/ubuntu/pool/universe/x/xserver-xorg-video-apm/xserver-xorg-video-apm_1.2.3-2_amd64.deb 403 Forbidden [IP: 130.239.18.173 80]

It looks like a problem with the mirror you're using. Could you please use another mirror and tell if it helps ?

summary: - UpdateManager failed to upgrade from Natty to Oneric
+ UpdateManager failed to upgrade from Natty to Oneric:
+ http://se.archive.ubuntu.com 403 Forbidden
Revision history for this message
Per-Inge (per-inge-hallin) wrote : Re: [Bug 806065] Re: UpdateManager failed to upgrade from Natty to Oneric

OK,

I normally use the main server, but in this case it was the mirror in
Sweden. Will try again with the Main server.

MVH/Per-Inge

On 07/05/2011 08:23 PM, Jean-Baptiste Lallement wrote:
> Thanks for the logs.
>
> > From the error
> 2011-07-05 18:20:31,204 ERROR IOError in cache.commit(): 'Failed to fetch http://se.archive.ubuntu.com/ubuntu/pool/universe/x/xserver-xorg-video-voodoo/xserver-xorg-video-voodoo_1.2.4-2_amd64.deb 403 Forbidden [IP: 130.239.18.173 80]
> Failed to fetch http://se.archive.ubuntu.com/ubuntu/pool/universe/x/xserver-xorg-video-tseng/xserver-xorg-video-tseng_1.2.4-2_amd64.deb 403 Forbidden [IP: 130.239.18.173 80]
> Failed to fetch http://se.archive.ubuntu.com/ubuntu/pool/universe/x/xserver-xorg-video-s3virge/xserver-xorg-video-s3virge_1.10.4-4_amd64.deb 403 Forbidden [IP: 130.239.18.173 80]
> Failed to fetch http://se.archive.ubuntu.com/ubuntu/pool/universe/x/xserver-xorg-video-i128/xserver-xorg-video-i128_1.3.4-2_amd64.deb 403 Forbidden [IP: 130.239.18.173 80]
> Failed to fetch http://se.archive.ubuntu.com/ubuntu/pool/universe/x/xserver-xorg-video-chips/xserver-xorg-video-chips_1.2.4-1_amd64.deb 403 Forbidden [IP: 130.239.18.173 80]
> Failed to fetch http://se.archive.ubuntu.com/ubuntu/pool/universe/x/xserver-xorg-video-ark/xserver-xorg-video-ark_0.7.3-2_amd64.deb 403 Forbidden [IP: 130.239.18.173 80]
> Failed to fetch http://se.archive.ubuntu.com/ubuntu/pool/universe/x/xserver-xorg-video-apm/xserver-xorg-video-apm_1.2.3-2_amd64.deb 403 Forbidden [IP: 130.239.18.173 80]
>
> It looks like a problem with the mirror you're using. Could you please
> use another mirror and tell if it helps ?
>
>
> ** Summary changed:
>
> - UpdateManager failed to upgrade from Natty to Oneric
> + UpdateManager failed to upgrade from Natty to Oneric: http://se.archive.ubuntu.com 403 Forbidden
>

Revision history for this message
Per-Inge (per-inge-hallin) wrote :

Didn't work with the main server either. In this case there was no error
message.
The logs from the try with the main server:

On 07/05/2011 08:36 PM, Per-Inge wrote:
> OK,
>
> I normally use the main server, but in this case it was the mirror in
> Sweden. Will try again with the Main server.
>
> MVH/Per-Inge
>
> On 07/05/2011 08:23 PM, Jean-Baptiste Lallement wrote:
>> Thanks for the logs.
>>
>>> From the error
>> 2011-07-05 18:20:31,204 ERROR IOError in cache.commit(): 'Failed to fetch http://se.archive.ubuntu.com/ubuntu/pool/universe/x/xserver-xorg-video-voodoo/xserver-xorg-video-voodoo_1.2.4-2_amd64.deb 403 Forbidden [IP: 130.239.18.173 80]
>> Failed to fetch http://se.archive.ubuntu.com/ubuntu/pool/universe/x/xserver-xorg-video-tseng/xserver-xorg-video-tseng_1.2.4-2_amd64.deb 403 Forbidden [IP: 130.239.18.173 80]
>> Failed to fetch http://se.archive.ubuntu.com/ubuntu/pool/universe/x/xserver-xorg-video-s3virge/xserver-xorg-video-s3virge_1.10.4-4_amd64.deb 403 Forbidden [IP: 130.239.18.173 80]
>> Failed to fetch http://se.archive.ubuntu.com/ubuntu/pool/universe/x/xserver-xorg-video-i128/xserver-xorg-video-i128_1.3.4-2_amd64.deb 403 Forbidden [IP: 130.239.18.173 80]
>> Failed to fetch http://se.archive.ubuntu.com/ubuntu/pool/universe/x/xserver-xorg-video-chips/xserver-xorg-video-chips_1.2.4-1_amd64.deb 403 Forbidden [IP: 130.239.18.173 80]
>> Failed to fetch http://se.archive.ubuntu.com/ubuntu/pool/universe/x/xserver-xorg-video-ark/xserver-xorg-video-ark_0.7.3-2_amd64.deb 403 Forbidden [IP: 130.239.18.173 80]
>> Failed to fetch http://se.archive.ubuntu.com/ubuntu/pool/universe/x/xserver-xorg-video-apm/xserver-xorg-video-apm_1.2.3-2_amd64.deb 403 Forbidden [IP: 130.239.18.173 80]
>>
>> It looks like a problem with the mirror you're using. Could you please
>> use another mirror and tell if it helps ?
>>
>>
>> ** Summary changed:
>>
>> - UpdateManager failed to upgrade from Natty to Oneric
>> + UpdateManager failed to upgrade from Natty to Oneric: http://se.archive.ubuntu.com 403 Forbidden
>>

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote : Re: UpdateManager failed to upgrade from Natty to Oneric: http://se.archive.ubuntu.com 403 Forbidden

Thanks for the logs.

This time the error is different
Traceback (most recent call last):

  File "/tmp/update-manager-G9GZGG/oneiric", line 7, in <module>
    sys.exit(main())

  File "/tmp/update-manager-G9GZGG/DistUpgradeMain.py", line 202, in main
    if app.run():

  File "/tmp/update-manager-G9GZGG/DistUpgradeController.py", line 1642, in run
    return self.fullUpgrade()

  File "/tmp/update-manager-G9GZGG/DistUpgradeController.py", line 1612, in fullUpgrade
    if not self.doDistUpgrade():

  File "/tmp/update-manager-G9GZGG/DistUpgradeController.py", line 1006, in doDistUpgrade
    self._maybe_create_apt_btrfs_snapshot()

  File "/tmp/update-manager-G9GZGG/DistUpgradeController.py", line 985, in _maybe_create_apt_btrfs_snapshot
    apt_btrfs = apt_btrfs_snapshot.AptBtrfsSnapshot()

  File "/tmp/update-manager-G9GZGG/apt_btrfs_snapshot.py", line 84, in __init__
    self.fstab = Fstab(fstab)

  File "/tmp/update-manager-G9GZGG/apt_btrfs_snapshot.py", line 52, in __init__
    entry = FstabEntry.from_line(line)

  File "/tmp/update-manager-G9GZGG/apt_btrfs_snapshot.py", line 30, in from_line
    return FstabEntry(*line.split())

TypeError: __init__() takes exactly 7 arguments (5 given)

Setting to confirmed.

Changed in update-manager (Ubuntu):
assignee: nobody → Canonical Foundations Team (canonical-foundations)
importance: Undecided → High
status: Incomplete → Confirmed
summary: - UpdateManager failed to upgrade from Natty to Oneric:
- http://se.archive.ubuntu.com 403 Forbidden
+ apt_btrfs_snapshot.py", line 30, in from_line return
+ FstabEntry(*line.split()) TypeError: __init__() takes exactly 7
+ arguments (5 given)
Revision history for this message
Michael Vogt (mvo) wrote : Re: apt_btrfs_snapshot.py", line 30, in from_line return FstabEntry(*line.split()) TypeError: __init__() takes exactly 7 arguments (5 given)

Could you please attach your /etc/fstab to this report?

Revision history for this message
Per-Inge (per-inge-hallin) wrote : Re: [Bug 806065] Re: apt_btrfs_snapshot.py", line 30, in from_line return FstabEntry(*line.split()) TypeError: __init__() takes exactly 7 arguments (5 given)
  • fstab Edit (1.0 KiB, text/plain; name="fstab")

OK,

Here is the fstab

On 07/06/2011 10:09 AM, Michael Vogt wrote:
> Could you please attach your /etc/fstab to this report?
>

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote : Re: apt_btrfs_snapshot.py", line 30, in from_line return FstabEntry(*line.split()) TypeError: __init__() takes exactly 7 arguments (5 given)

Thanks.

The problem is caused by missing (and optional) fs_freq and fs_passno for nfs entries. Setting to triage.

Changed in update-manager (Ubuntu Oneiric):
status: Confirmed → Triaged
summary: - apt_btrfs_snapshot.py", line 30, in from_line return
- FstabEntry(*line.split()) TypeError: __init__() takes exactly 7
- arguments (5 given)
+ dist-upgrader fails with "FstabEntry(*line.split()) TypeError:
+ __init__() takes exactly 7 arguments (5 given)" if fs_freq and fs_passno
+ fields no present in fstab entry
summary: dist-upgrader fails with "FstabEntry(*line.split()) TypeError:
__init__() takes exactly 7 arguments (5 given)" if fs_freq and fs_passno
- fields no present in fstab entry
+ fields not present in fstab entry
Michael Vogt (mvo)
Changed in update-manager (Ubuntu Oneiric):
status: Triaged → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package update-manager - 1:0.151.8

---------------
update-manager (1:0.151.8) oneiric; urgency=low

  * DistUpgrade/DistUpgradeViewGtk.py:
    - set DPKG_UNTRANSLATED_MESSAGES to force untranslated dpkg
      terminal messages for easier package failure duplication
      detection
  * DistUpgrade/DistUpgradeCache.py:
    - when calculating the size of the space required in /boot use
      the size of the currently running kernel as the base and add
      a small safety margin (LP: #798462).
  * import new apt-btrfs-snapshot to fix crash for certain fstab
    entries (LP: #806065)
 -- Michael Vogt <email address hidden> Wed, 06 Jul 2011 17:23:26 +0200

Changed in update-manager (Ubuntu Oneiric):
status: In Progress → Fix Released
Revision history for this message
Michun (gerhard-kulzer) wrote :

I have the same kind of problem, the error message is however:

   TypeError: __init__() takes at most 7 arguments (8 given)

My fstab entries look like this:
UUID=c3329969-5a64-4ce1-905f-b42ac9649a84 / btrfs defaults,subvol=@ 0 1 #/dev/sda2

I've put a comment line behind each entry, which is interpreted as the 8th argument. If I remove the comment, all goes fine.

Since a line-end comment is allowed in fstab, maybe the python script should allow for it too, for sake of compatibility.

Gerhard

Revision history for this message
Brian Murray (brian-murray) wrote :

Michun could you report a new bug about apt-btrfs-snapshot regarding that issue? Thanks in advance.

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks Brian and Michun! I reported #872145 and I'm working on it now.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.