Ubuntu
byobu package

disk_io doesn't work on LVM or dmraid devices

Bug #709224 reported by Philip Muškovac
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
byobu (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

Binary package hint: byobu

the disk_io script uses '/sys/block/$disk/stat' to get the device statistics, but for LVM and raid devices the mounts look like this:

$ mount | grep 'on / '
/dev/mapper/main-devel on / type ext4 (rw,relatime,discard,errors=remount-ro,commit=0)
$ ls -l /dev/mapper/main-devel
lrwxrwxrwx 1 root root 7 2011-01-28 12:57 /dev/mapper/main-devel -> ../dm-2
$ls -l /dev/dm-2
brw-rw---- 1 root disk 252, 2 2011-01-28 12:57 /dev/dm-2

$ ls /sys/block/
dm-0 dm-2 loop1 loop3 loop5 loop7 ram1 ram11 ram13 ram15 ram3 ram5 ram7 ram9 sdb
dm-1 loop0 loop2 loop4 loop6 ram0 ram10 ram12 ram14 ram2 ram4 ram6 ram8 sda

so if I get this right the sed command in line 33 will set disk too "" and you get no disk_io output unless setting MONITORED_DISK to /dev/dm-2

ProblemType: Bug
DistroRelease: Ubuntu 11.04
Package: byobu 3.26-0ubuntu1
ProcVersionSignature: Ubuntu 2.6.37-12.26-generic 2.6.37
Uname: Linux 2.6.37-12-generic i686
NonfreeKernelModules: eee
Architecture: i386
Date: Fri Jan 28 13:46:06 2011
InstallationMedia: Kubuntu 10.10 "Maverick Meerkat" - Release i386 (20101007)
PackageArchitecture: all
ProcEnviron:
 SHELL=/bin/bash
 PATH=(custom, user)
 LANG=en_US.UTF-8
 LANGUAGE=en_US.UTF-8
ScreenRC:

SourcePackage: byobu

Related branches

lp:byobu
lp:ubuntu/natty/byobu
Revision history for this message
Philip Muškovac (yofel) wrote :
Dustin Kirkland  (kirkland)
Changed in byobu (Ubuntu):
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Pretty easy to solve, just needed a readlink in there ;-)

Thanks for the report.

Changed in byobu (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package byobu - 3.29-0ubuntu1

---------------
byobu (3.29-0ubuntu1) natty; urgency=low

  [ Dustin Kirkland ]
  * usr/share/man/man1/byobu.1: document PS1 workaround, LP: #525552
  * usr/share/man/man1/byobu.1: fix minor manpage typo, add SERVICES example
  * usr/lib/byobu/wifi_quality, usr/share/man/man1/byobu.1: support overriding
    the default wireless interface, LP: #723260
  * usr/share/man/man1/byobu.1: document TERM=vt100 for Mac keyboard users,
    LP: #482623
  * usr/bin/byobu-janitor: use readlink, much more graceful
  * usr/lib/byobu/time_binary, usr/share/byobu/profiles/common,
    usr/share/man/man1/byobu.1: fixup a couple of minor issues with the binary
    clock commit
  * usr/bin/byobu-status: switch the interpreter from sh to bash; this is
    needed to support James' time_binary script, which is bash and cannot be
    simply sourced by byobu-status; if significant performance regressions
    occur, we will need to back this change out and approach it a different
    way

  [ James Hunt ]
  * etc/byobu/statusrc, usr/bin/byobu-config, usr/lib/byobu/time_binary,
    usr/share/byobu/profiles/common, usr/share/man/man1/byobu.1:
    - add support for the super-geeky-but-fun binary clock; requires
      UTF8 support in GNU Screen, LP: #705037

  [ Chow Loong Jin and Dustin Kirkland ]
  * usr/lib/byobu/disk_io: canonicalize symlinks so that disk_io works
    with raid, lvm, dm volumes, LP: #709224, #711373, #723187
 -- Dustin Kirkland <email address hidden> Wed, 23 Feb 2011 16:24:38 -0600

Changed in byobu (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.