[SRU] fsattr fails to run

Bug #2060740 reported by Sudip Mukherjee
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
fstransform (Debian)
New
Unknown
fstransform (Ubuntu)
Status tracked in Oracular
Focal
Confirmed
Undecided
Unassigned
Jammy
Confirmed
Undecided
Unassigned
Mantic
Confirmed
Undecided
Unassigned
Noble
Confirmed
Undecided
Unassigned
Oracular
Fix Released
Undecided
Unassigned

Bug Description

[ Impact ]

fsattr will crash immediately on execution with the error:

$ fsattr
ERROR: fsattr: this program is a NOT functional because it was compiled without -lext2fs -lcom_err

[ Test Plan ]

test with a loop device:

dd if=/dev/zero of=./test_disk bs=1K count=1000
sudo losetup -f test_disk

check which loop device has been used:
sudo losetup -l

In my test it was /dev/loop11
sudo mkfs.ext4 /dev/loop11

sudo fsattr --files=prealloc --fstype=ext4 /dev/loop11

If the package is not fixed it will result in the above error.
With the fixed package it will not fail.

Another testplan to confirm "fsremap" is still working after the change.

sudo dd if=/dev/zero of=./test_disk bs=1K count=100000
mkdir test_mnt
sudo mkfs.ext4 test_disk
sudo mount test_disk test_mnt -o loop

# create a ramdom test file
sudo dd if=/dev/random of=test_mnt/file1 bs=1K count=1

sudo dd if=/dev/zero of=test_mnt/loop
sudo mkfs.ext4 test_mnt/loop
mkdir test_mnt_loop
sudo mount test_mnt/loop test_mnt_loop -o loop

# create another random test file inside the loop file in the device
sudo dd if=/dev/random of=test_mnt_loop/file2 bs=1K count=1

sudo fsmove test_mnt test_mnt_loop --exclude test_mnt/loop
sudo umount test_mnt_loop
sudo dd if=/dev/zero of=test_mnt/zero bs=512
sudo mount -o ro,remount test_mnt
mkdir log
sudo fsremap -vv -t log /dev/loop11 test_mnt/loop test_mnt/zero
cat log/fstransform/fsremap.job.1/fsremap.log

Use the last command to check the log and confirm "fsremap" has worked.

Also, try the following:
sudo mount test_disk test_mnt -o loop
ls test_mnt

It will now have both the random test files.

[ Where problems could occur ]

There is no change in the code, it only changes a build dependency which will make fsattr functional.

[ Other Info ]

Since "fsattr" has never worked before, so there can be problems and new bugs reported for it.

[ Original Bug Description ]

fsattr fails to run with the error:

$ fsattr
ERROR: fsattr: this program is a NOT functional because it was compiled without -lext2fs -lcom_err

ProblemType: Bug
DistroRelease: Ubuntu 24.04
Package: fstransform 0.9.4-1build1
ProcVersionSignature: Ubuntu 6.8.0-22.22-generic 6.8.1
Uname: Linux 6.8.0-22-generic x86_64
ApportVersion: 2.28.0-0ubuntu1
Architecture: amd64
CasperMD5CheckResult: pass
CurrentDesktop: ubuntu:GNOME
Date: Tue Apr 9 22:12:33 2024
InstallationDate: Installed on 2024-04-08 (1 days ago)
InstallationMedia: Ubuntu 24.04 LTS "Noble Numbat" - Daily amd64 (20240408)
SourcePackage: fstransform
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Sudip Mukherjee (sudipmuk) wrote :
Revision history for this message
Sudip Mukherjee (sudipmuk) wrote :

debdiff attached for Noble.

Changed in fstransform (Ubuntu):
status: New → Confirmed
Changed in fstransform (Debian):
status: Unknown → New
Revision history for this message
Sudip Mukherjee (sudipmuk) wrote :

Updating the debdiff to target oracular. Please correct me if I am wrong but I think this change is not suitable for SRU.

Revision history for this message
Aaron Rainbolt (arraybolt3) wrote :

At least at first glance, I think this is SRU-able:

  2.2. Other safe cases
  ...
  Bugs which do not fit under above categories, but (1) have an obviously safe patch and (2) affect an application rather than critical infrastructure packages (like X.org or the kernel).
  ...

From https://wiki.ubuntu.com/StableReleaseUpdates

All that's being done is adding a couple of build dependencies, the program appears to be useless without them so it can't get much worse, and this isn't critical infrastructure, so I think it can be SRU'd.

Changed in fstransform (Ubuntu Noble):
status: New → Confirmed
Changed in fstransform (Ubuntu Focal):
status: New → In Progress
Changed in fstransform (Ubuntu Jammy):
status: New → In Progress
Changed in fstransform (Ubuntu Mantic):
status: New → In Progress
Changed in fstransform (Ubuntu Noble):
status: Confirmed → In Progress
assignee: nobody → Sudip Mukherjee (sudipmuk)
Changed in fstransform (Ubuntu Mantic):
assignee: nobody → Sudip Mukherjee (sudipmuk)
Changed in fstransform (Ubuntu Jammy):
assignee: nobody → Sudip Mukherjee (sudipmuk)
Changed in fstransform (Ubuntu Focal):
assignee: nobody → Sudip Mukherjee (sudipmuk)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package fstransform - 0.9.4-1ubuntu1

---------------
fstransform (0.9.4-1ubuntu1) oracular; urgency=medium

  * d/control: Update build-dependency to fix error with fsattr. (LP: #2060740)

 -- Sudip Mukherjee <email address hidden> Wed, 01 May 2024 20:59:02 +0100

Changed in fstransform (Ubuntu Oracular):
status: Confirmed → Fix Released
Revision history for this message
Sudip Mukherjee (sudipmuk) wrote :

debdiff for Noble.

summary: - fsattr fails to run
+ [SRU] fsattr fails to run
description: updated
Revision history for this message
Sudip Mukherjee (sudipmuk) wrote :

debdiff for Mantic

Revision history for this message
Sudip Mukherjee (sudipmuk) wrote :

debdiff for Jammy

Revision history for this message
Sudip Mukherjee (sudipmuk) wrote :

debdiff for Focal

Changed in fstransform (Ubuntu Focal):
status: In Progress → Confirmed
Changed in fstransform (Ubuntu Jammy):
status: In Progress → Confirmed
Changed in fstransform (Ubuntu Mantic):
status: In Progress → Confirmed
Changed in fstransform (Ubuntu Noble):
status: In Progress → Confirmed
Changed in fstransform (Ubuntu Focal):
assignee: Sudip Mukherjee (sudipmuk) → nobody
Changed in fstransform (Ubuntu Jammy):
assignee: Sudip Mukherjee (sudipmuk) → nobody
Changed in fstransform (Ubuntu Mantic):
assignee: Sudip Mukherjee (sudipmuk) → nobody
Changed in fstransform (Ubuntu Noble):
assignee: Sudip Mukherjee (sudipmuk) → nobody
Revision history for this message
Dan Bungert (dbungert) wrote :

Hi Sudip, thanks for the work here.

> [ Where problems could occur ]
> There is no change in the code, it only changes a build dependency
> which will make fsattr functional.

Mostly this looks ok, but with some diffoscope analysis I note that
some binaries are indifferent to this change (fsmount_kernel and
fsmove change only NT_GNU_BUILD_ID) but others do notice this builddep
change (fsattr as expected, but also fsremap looks different.)
Do you mind investigating a little on fsremap? I think we want a bit
of a regression test there to try to ensure that making fsattr better
doesn't make fsremap worse. WDYT?

Changed in fstransform (Ubuntu Focal):
status: Confirmed → In Progress
Changed in fstransform (Ubuntu Jammy):
status: Confirmed → In Progress
Changed in fstransform (Ubuntu Mantic):
status: Confirmed → In Progress
Changed in fstransform (Ubuntu Noble):
status: Confirmed → In Progress
Changed in fstransform (Ubuntu Focal):
assignee: nobody → Sudip Mukherjee (sudipmuk)
Changed in fstransform (Ubuntu Jammy):
assignee: nobody → Sudip Mukherjee (sudipmuk)
Changed in fstransform (Ubuntu Mantic):
assignee: nobody → Sudip Mukherjee (sudipmuk)
Changed in fstransform (Ubuntu Noble):
assignee: nobody → Sudip Mukherjee (sudipmuk)
Revision history for this message
Sudip Mukherjee (sudipmuk) wrote :

I had a look at why fsremap changed and the build of fsremap is checking for LIBEXT2FS and is linking with ext2fs if its available.

I have updated the testplan with a test for fsremap.

description: updated
Changed in fstransform (Ubuntu Focal):
assignee: Sudip Mukherjee (sudipmuk) → nobody
Changed in fstransform (Ubuntu Jammy):
assignee: Sudip Mukherjee (sudipmuk) → nobody
Changed in fstransform (Ubuntu Mantic):
assignee: Sudip Mukherjee (sudipmuk) → nobody
Changed in fstransform (Ubuntu Noble):
assignee: Sudip Mukherjee (sudipmuk) → nobody
Changed in fstransform (Ubuntu Focal):
status: In Progress → Confirmed
Changed in fstransform (Ubuntu Jammy):
status: In Progress → Confirmed
Changed in fstransform (Ubuntu Mantic):
status: In Progress → Confirmed
Changed in fstransform (Ubuntu Noble):
status: In Progress → Confirmed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.