Ubuntu Software Center

Merge lp:~mvo/software-center/lp856559 into lp:software-center

  1. lp856559
  2. Merge into trunk
Proposed by Michael Vogt
Status: Merged
Merged at revision: 2868
Proposed branch: lp:~mvo/software-center/lp856559
Merge into: lp:software-center
Diff against target: 12 lines (+2/-0)
1 file modified
softwarecenter/ui/gtk3/panes/availablepane.py (+2/-0)
To merge this branch: bzr merge lp:~mvo/software-center/lp856559
Reviewer Review Type Date Requested Status
Gary Lasker (community) Approve
Review via email: mp+97833@code.launchpad.net

Description of the change

This branch fixes a ui issue with the "reinstall-previous-purchase" menu item. To reproduce:
1. open software-center
2. type foo
3. click on "reinstall-previous-purchases"
4. the list if there and looks good, but the "foo" text is still in the search entry

Item (4) is fixed with this branch. The problem was that the search_term was still part of
the "self.state" data structure.

To post a comment you must log in.
Revision history for this message
Gary Lasker (gary-lasker) wrote :

Oh, weird! My initial fix always cleared the entry for me. Must be some state where it did not, I suppose due to the asyn nature of the returned results from Reinstall Previous Purchases. Thanks for finding this and thanks for the fix!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'softwarecenter/ui/gtk3/panes/availablepane.py'
2--- softwarecenter/ui/gtk3/panes/availablepane.py 2012-03-15 00:52:10 +0000
3+++ softwarecenter/ui/gtk3/panes/availablepane.py 2012-03-16 10:40:24 +0000
4@@ -656,6 +656,8 @@
5 self.nonapps_visible = NonAppVisibility.ALWAYS_VISIBLE
6 self.app_view.set_header_labels(_("Previous Purchases"), None)
7 self.notebook.set_current_page(AvailablePane.Pages.LIST)
8+ # clear any search terms
9+ self._clear_search()
10 # do not emit app-list-changed here, this is done async when
11 # the new model is ready
12 self.refresh_apps(query=self.previous_purchases_query)

Subscribers

People subscribed via source and target branches