Merge lp:~mbp/kanban/720563-privacy into lp:kanban
Status: | Merged |
---|---|
Approved by: | Jamu Kakar |
Approved revision: | 26 |
Merged at revision: | 26 |
Proposed branch: | lp:~mbp/kanban/720563-privacy |
Merge into: | lp:kanban |
To merge this branch: | bzr merge lp:~mbp/kanban/720563-privacy |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jamu Kakar | Approve | ||
Review via email: mp+53386@code.launchpad.net |
Description of the change
This makes sure that when a kanban is generated by an unprivileged user, public bugs with private branches attached will still show up. (It should also handle the case of being logged in but not able to see a particular bug.)
This has a workaround for lp bug 735346 which means if any one of the linked branches is private, you can't see any of them at all. Eventually Launchpad should just omit branches we can't see from the list, and the try/except should never fire, but will be harmless.
I've removed the higher-level catchall except blocks; if there are any other private things with similar problems we could add this back in.
This should also mean that if other HTTP errors show up, such as a 503, they'll propagate to the user. (bug 735317)
[1]
+ merge_proposal_url = ("https:/ /code.launchpad .net/~" proposal. self).split( "~")[-1] )
+ + str(merge_
Please format this as:
[2]
+ break
+ break
Please remove one of these.
[3]
+ # Due to <http:// pad.lv735346>, at the moment bugs with
+ # any private linked branches hide all of them and raise an error.
The URL here needs a trailing slash after pad.lv, please.
[4]
+ if is_forbidden(e) or is_unauthorized(e):
+ pass
It might be worth calling trace("Skipping forbidden or unauthorized
bug.") here...? Though, I'm not really sure what a user will do about
it, so maybe it's just noise. Anyway, just a thought.
Nice work, +1!