Merge lp:~mbp/kanban/718564-edge into lp:kanban
Proposed by
Martin Pool
Status: | Merged |
---|---|
Approved by: | Jamu Kakar |
Approved revision: | 23 |
Merged at revision: | 22 |
Proposed branch: | lp:~mbp/kanban/718564-edge |
Merge into: | lp:kanban |
Diff against target: |
44 lines (+6/-7) 2 files modified
kanban/commands.py (+4/-3) kanban/launchpad.py (+2/-4) |
To merge this branch: | bzr merge lp:~mbp/kanban/718564-edge |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jamu Kakar | Approve | ||
Review via email: mp+49910@code.launchpad.net |
Description of the change
It turns out my previous branch didn't catch the other occurrence, and the way it did the first part was over-complicated. Take 2.
To post a comment you must log in.
[1]
- get_person_ assigned_ bugs) assigned_ bugs,
+ get_person_
+ SERVICE_ROOT)
Would you mind putting the new import on the same line as assigned_ bugs to match the existing formatting convention,
get_person_
please?
[2]
from launchpadlib. launchpad import Launchpad, EDGE_SERVICE_ROOT
The existing EDGE_SERVICE_ROOT import is no longer used. Can you
please remove it?
When you merge, can you please write a merge commit message using the
following format. You can see examples of it in the log for trunk.
"""
Merged $branch-name [r=$reviewer] [f=$bug-number]
$changeset- description
"""
Thanks for cleaning this up, +1!