Ubuntu Software Center

Merge lp:~evfool/software-center/sfix672229 into lp:software-center

  1. sfix672229
  2. Merge into trunk
Proposed by Robert Roth
Status: Merged
Merged at revision: 1655
Proposed branch: lp:~evfool/software-center/sfix672229
Merge into: lp:software-center
Diff against target: 13 lines (+2/-1)
1 file modified
softwarecenter/view/historypane.py (+2/-1)
To merge this branch: bzr merge lp:~evfool/software-center/sfix672229
Reviewer Review Type Date Requested Status
Michael Vogt Approve
Review via email: mp+55658@code.launchpad.net

Description of the change

Time format displayed in history made translatable and omitting seconds by default, as requested by the wiki specification of the Software center.

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

Looks great, many thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'softwarecenter/view/historypane.py'
2--- softwarecenter/view/historypane.py 2011-01-20 05:04:46 +0000
3+++ softwarecenter/view/historypane.py 2011-03-31 01:02:26 +0000
4@@ -310,7 +310,8 @@
5 if isinstance(when, datetime.datetime):
6 action = store.get_value(iter, self.COL_ACTION)
7 pkg = store.get_value(iter, self.COL_PKG)
8- subs = {'pkgname': pkg, 'time': when.time().strftime('%X')}
9+ # Translators : time displayed in history, display hours (0-12), minutes and AM/PM. %H should be used instead of %I to display hours 0-24
10+ subs = {'pkgname': pkg, 'time': when.time().strftime(_('%I:%M %p'))}
11 if action == self.INSTALLED:
12 text = _('%(pkgname)s installed %(time)s') % subs
13 elif action == self.REMOVED: