Subunit output formatter doesn't handle layer setup errors

Bug #560259 reported by Jonathan Lange
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
zope.testing
Fix Released
Undecided
Sidnei da Silva

Bug Description

The subunit output formatter that was added recently currently raises NotImplementedError when it's given a generic "error". The error() method on formatters is used to communicate user error (e.g. when the user selects incompatible options), internal framework errors (afaict, only when there's a subprocess read error) and layer setUp errors.

Masking layer setUp errors is pretty bad. The subunit output formatter should report them somehow.

Related branches

Tres Seaver (tseaver)
Changed in zope.testing:
assignee: nobody → Tres Seaver (tseaver)
Revision history for this message
Tres Seaver (tseaver) wrote :

I'm afraid I don't grok the code being patched at all -- I will let the guy who checked in the original subunit support for you merge your fix.

Changed in zope.testing:
assignee: Tres Seaver (tseaver) → Sidnei da Silva (sidnei)
Jonathan Lange (jml)
Changed in zope.testing:
status: New → In Progress
Revision history for this message
Jonathan Lange (jml) wrote :

Patch attached, I'm afraid of a stacking snafu.

Sidnei da Silva (sidnei)
Changed in zope.testing:
status: In Progress → Fix Committed
Sidnei da Silva (sidnei)
Changed in zope.testing:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.