[FFe] Accept new python-based Wubi for 9.04

More from Agostino:

Yesterday I took care of #5 and #6. While I was on the code I remembered
that when dealing with a CD (as opposed to an ISO), at the moment I copy
the files instead of extracting the ISO. This was an old workaround for
#207137, but that approach is blocked by #243105. At the time I assumed
#243105 would be fixed and I am not sure of the current status of that.
I haven't tested yet the new Wubi with a real CD, but I would expect it
to fail because of that. If fixing #243105 is not viable I will have to
implement ISO extraction in python, which should not bee too difficult,
but is another item on the list.

It is possible to perform ISO extraction from a mounted CD in Windows using high level python file IO functions. So I can reuse existing code almost as is. It is already in my local branch, I need to do a bit more testing and will commit shortly, so that should also be out of the way.

ISO extraction is now in the tree (rev74) together with support for windows theming (rev75). So what is left out is #1 and #2.

#1 and #2 are mostly done too, there are still some glitches and bugs to iron out, but I have dealt with all the points of the above list except for full bittorrent testing (which requires a torrent in the metalink on the server).

Outstanding bugs I am aware of:

* Uninstaller does not work when the uninstaller itself is in the directory to be deleted
* The temporary directory does not get deleted when wubi exits
* The wrong string is used in title of progress page (tasklist name as opposed to tasklist description)
* Resuming download from a previous partial download does not work
* The window is resized differently with XP themes, in particular the vertical image is too high and goes beyond the horizontal line
* Groupbox label should have opaque background
* The checkbox for ISO backup in the uninstallation page has a black background
* Make sure a single instance of wubi is running
* Check admin rights

Sorry for the delay in getting the bittorrent into the metalink files - the code is committed now, so the next metalinks should have this.

I'm happy to let this in as an FFe, subject to a couple concerns:

- what's the disk footprint for the new version of Wubi, compared to what we currently have on the ISO?
- it's important that we have this new Wubi in before alpha5 (next week), since Wubi doesn't get very wide user testing outside of milestone images - and even then the coverage is less than ideal.

before alpha6, I mean. Sorry, typing malfunction. :)

Steve, the new code is about 1.6-1.7MB compared to about 1.3MB of Wubi + Umenu for the old version. Having python + GUI + download manager + bittorrent + gpg signature verification + ISO extraction in 1.6M is probably already a record... I might be able to shave a few K off in the coming days by playing with compression options (7z has quite an array of flags...) and recoding some dependencies (the main non-python piece of code at the moment, is an embedded version of 7z used for extracting files from ISOs which weights ~100K compressed). I plan to spend some time further optimizing the size after the main remaining bugs are sorted.

To give a definitive number I need to go through the list of dependencies. In practice I create the packaged exe by resolving the python dependencies at compilation time which get bundled, 7zipped and appended to a self-extracting executable which knows how to launch the bundled python code. But given that dependencies are resolved automatically, I need to make sure that nothing is missing, which might be needed in set-ups different from my own (particularly codecs). That goes the other way too, I might also be able to remove some other dependency (https/ssl?). Cannot check that right now, will let you know tonight or in the coming days.

Save the above list, wubi-python has been working for quite some time in terms of core functionality using ISOs and I think that the current version could already be used and tested, so I do not think that alpha6 would be a problem.

Thanks for the torrent by the way and for the FFE.

Here's a proposed patch to cdimage to support the new python-based Wubi. I'll apply this when Steve says his concerns about the FFe have been adequately addressed.

yes, we can accomodate a 300KB growth in Wubi.

The cdimage change is r725. I've also put in place a new Wubi build (r88). Building a new daily-live now. I'll mark this bug fixed once I verify that it everything is working properly.

Thanks!

Steve, I have eliminated SSL support and now the size is at 1.4MB. Can probably squeeze out something more via optimization, but from now on the effort involved will probably not be worth the gain. So I would say that 1.4MB is a good estimate at this stage.