xulrunner includes no longer have nspr headers; explicit link against nspr is required.

Bug #427638 reported by Robert Ancell
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
xiphos (Ubuntu)
Fix Released
High
Unassigned
xulrunner-1.9.1 (Ubuntu)
Fix Released
Critical
Alexander Sack
yelp (Ubuntu)
Fix Released
High
Unassigned

Bug Description

Binary package hint: xulrunner-1.9.1

Fails to build
https://edge.launchpad.net/ubuntu/+source/yelp/2.27.5-0ubuntu1/+build/1237910

Changed in xulrunner-1.9.1 (Ubuntu):
assignee: nobody → Alexander Sack (asac)
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Similar errors are happening with xiphos as well =)

(Well the modified Yelper.cpp is used in xiphos codebase so no surprise I'm getting similar build failures)

Changed in xiphos (Ubuntu):
status: New → Confirmed
summary: - yelp fails to build against xulrunner 1.9.1, cannot find nspr headers
+ yelp & xiphos fails to build against xulrunner 1.9.1.3, cannot find nspr
+ headers
Revision history for this message
Matthew Talbert (ransom1982) wrote : Re: yelp & xiphos fails to build against xulrunner 1.9.1.3, cannot find nspr headers

The problem is easy enough to diagnose. In previous versions of xulrunner, these headers were shipped as part of xulrunner-dev, so they were in /include/xulrunner-[version]/stable. Now, for whatever reason, these headers are not included in this package. Unless this is a mistake, it looks like these two programs will have to add include flags for package nspr-dev in addition to xulrunner-dev.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

In the code m4/gecko.m4 it is marked that it is not checker whether nspr headers are provided within $gecko flags.

It looks like Yelp & Xiphos both require nspr headers =) cause this is the first time when nspr headers are not provided by $gecko.

So just a quick question to xulrunner devs.

Was it intentional to move those headers out of libxul?
Is it upstream decision which will be present in other distros?

If yes to above two questions the fixes will need to be forwarded to Yelp.

summary: - yelp & xiphos fails to build against xulrunner 1.9.1.3, cannot find nspr
- headers
+ xulrunner includes no longer have nspr headers; explicit link against
+ nspr is required.
Revision history for this message
Alexander Sack (asac) wrote : Re: [Bug 427638] Re: yelp & xiphos fails to build against xulrunner 1.9.1.3, cannot find nspr headers

On Sat, Sep 12, 2009 at 10:15:57PM -0000, Matthew Talbert wrote:
> The problem is easy enough to diagnose. In previous versions of
> xulrunner, these headers were shipped as part of xulrunner-dev, so they
> were in /include/xulrunner-[version]/stable. Now, for whatever reason,
> these headers are not included in this package. Unless this is a
> mistake, it looks like these two programs will have to add include flags
> for package nspr-dev in addition to xulrunner-dev.
>
yes. I reorganized how the nspr headers are shipped. previously they
were properly referenced by mozilla-nspr.pc ... but thats gone now
(and no: except for builds that dont use system-nspr, we didnt ship
those headers in /usr/include/xulrunner...

 - Alexander

Alexander Sack (asac)
Changed in xulrunner-1.9.1 (Ubuntu):
status: New → In Progress
importance: Undecided → High
Changed in yelp (Ubuntu):
status: New → Triaged
Changed in xulrunner-1.9.1 (Ubuntu):
importance: High → Critical
Changed in yelp (Ubuntu):
importance: Undecided → High
Changed in xiphos (Ubuntu):
status: Confirmed → Triaged
importance: Undecided → High
Alexander Sack (asac)
Changed in xulrunner-1.9.1 (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xulrunner-1.9.1 - 1.9.1.3+build1+nobinonly-0ubuntu2

---------------
xulrunner-1.9.1 (1.9.1.3+build1+nobinonly-0ubuntu2) karmic; urgency=low

  [ Fabien Tassin <email address hidden> ]
  * Bump requirement for system sqlite to >= 3.6.16 (bmo 508104)
    - update debian/rules

  [ Alexander Sack <email address hidden> ]
  * fix LP: #423610 - daily build failures after landing of mozilla-nss.pc
    droppage (bug 422829); ensure that nspr-config is properly available in
    sdk regardless of using system or in-source nspr; also ensure that the
    xulrunner nspr/ include directory points to the system one in system-nspr
    case.
    - update debian/rules
  * fix LP: #427638 - xulrunner includes no longer have nspr headers; explicit
    link against nspr is required; we append /usr/include/xulrunner-*/stable/nspr/
    to all .pc Cflags:
    - update debian/rules

 -- Alexander Sack <email address hidden> Tue, 15 Sep 2009 13:42:31 +0200

Changed in xulrunner-1.9.1 (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Alexander Sack (asac) wrote :

i retried yelp. Marking fixed.

Changed in yelp (Ubuntu):
status: Triaged → Fix Released
Changed in xiphos (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

tag: PPA (don't seem to have rights to set tags)

Hope this is appropriate place but the same nspr headers are no longer included in the 1.9.2 dailies in the pkgconfig files.

Is this intentional or accidental? Cause I'm trying to port xiphos to 1.9.2 using ubuntu-mozilla-daily ppa and I'm getting build errors where xulrunner-embedding.pc shipped headers try to include headers from nspr. =/

Changed in xulrunner-1.9.1 (Ubuntu):
status: Fix Released → New
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Here is a trimmed diff between 1.9.1 and 1.9.2 of affected pkgconfig files.

Revision history for this message
Onkar Shinde (onkarshinde) wrote :

Dmitrijs,

If the bug is in xulrunner-1.9.2 packages why did you change the status for 1.9.1 package? Please file a new bug.

Changed in xulrunner-1.9.1 (Ubuntu):
status: New → Fix Released
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Oncar,

Because xulrunner-1.9.2 is not yet published in Lucid, but expected to. And Mozilla team which maintains these packages on one of the pages I was reading in the morning said it is acceptible to file bugs against archive package with tag ppa.

Even though launchpad knows that xulrunner-1.9.2 exists it doesn't let me assign bug reports towards it within ubuntu project.

I will contact the team directly again to ask for their preference and discuss this issue.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.