Kayboard 105 with Slovenian diagraphs is no QWERTZ

Forwarding this bug report from a Ubuntu reporter:
https://bugs.edge.launchpad.net/ubuntu/+source/xkeyboard-config/+bug/162462

[Problem]
Several variants are given for Slovenian keyboards, but most appear to be unneeded and perhaps should be removed.

[Discussion]
The following variants are available:

    name[Group1]="Slovenia";
    name[Group1]= "Slovenia - US keyboard with Slovenian letters";
    name[Group1]= "Slovenia - Use guillemets for quotes";
    name[Group1]= "Slovenia - Use Slovenian digraphs";
    name[Group1]= "Slovenia - US keyboard with Slovenian digraphs";

This appears to mirror the ba variants, so it is thought perhaps this was a cut-and-paste error when deriving this file.

[Original Report]
Keyboard layout: international 105, "Slovenian with diagraphs"
The keyboard gives wrong characters:
TYPE GET
q lj
w nj
y ž
x dž

When I change the setting from "Slovenian with diagraphs" to "Slovenian", it works ok - Slovenian QWERTZ keyboard.
I do not understand the actual meaning of "Slovenian with diagraphs". Maybe it does not need to exists at all.

8.10 alpha6 livecd:
- Setting to default Slovenian language during installation: ok
- Changing the Preferences->Keyboard: Country:Slovenia/variants:Slovenia: ok

However, the last three variants in the menu Preferences->Keyboard->Variants (...diagraphs, ....diagraphs, ....letters) are unneeded and a surplus. They seem to be a result from cut&paste from other language (e.g. Croatian,Serbian). Note that letters like 'lj' or 'nj' are treated as a single letter, but this is not the case not in Slovenian language.

it is only a default configuration issue: I am offered too many
possibilites. Some of the mentioned options are wrong and if I by mistake
select the "Slovenian with diagraphs", I cannot use the Slovenian keyboard
correctly. This is the only problem - there are no diagraphs on any
Slovenian keyboard (diagraph = Two letters that represent one speech
sound).
Kind regards, B.

First of all, it's 'digraph', not 'diagraph'.

Secondly, each of those layouts are different. You can view visually the differences when you go through the preview window in GNOME.

The 'digraph' layouts produce the correct Unicode characters for characters such as lj Lj nj Nj dž Dž. Some users may use 'lj', etc, though technically this is not the correct form per Unicode.

I would consider this report as INVALID.

Hello,
why is it so difficult to understand:
- there is no keyboard like "Slovenian with digraphs" (check on Google)
- in Slovenian language there are no single letter characters lj Lj nj Nj dž Dž.
- generally it is true that "Some users may use 'lj', etc, ", but there are many many other letters someone could want to use. But we still do not have Slovenian with German umlauts, or Slovenian with Spanish accents and tildas, etc.

Simon, isn't there a policy to consult a specialist for a specific language before making such decisions that are not related to known standars? Or at least consult wikipedia, e.g.
http://en.wikipedia.org/wiki/Keyboard_layout#Bosnian.2C_Croatian.2C_Serbian_.28Latin.29_and_Slovene

If the user selects the wrong (kbd) option, he cannot use the keyboard properly any more. I made this installation error (as a Slovenian not knowing what a digraph is!) and this is why I reported the problem. I feel I am spending too much time on this issue.

Regards, B.

I also haven't seen or heard of any such keyboards. Switching to the unicode or unicodeus variant pretty much cripples a user on a standard keyboard.

Looking at the git log, I see no mention why these two were added when the previous rules were rewritten. So I agree it is likely a copy/paste issue.

So, should I just drop it? Any other fixes?

Created an attachment (id=22937)
removed unicode and unicodeus variants

Short version: drop unicode and unicodeus.

Long version:
I'd just drop the two unicode variants, but I'm not sure about the alternatequotes one. If you are a grammar nazi, the proper quotes in slovenian are indeed the guillemets »« and not „“ (both are currently bound to the third level of s and d respectivelly). The layout picture in wikipedia includes the current quotes, so I guess it is fine.
But since the alternatequotes layout just swaps the quotes, I see no really compelling reason for not keeping it. Translators like to use the guillemets and on the current layout they're hiding on the fourth level (x,y,s,d). So maybe alternatequotes is useful for someone.

Lovely! Done!

I don't see it in git yet (forgot to push?), but I realised I forgot to remove them from rules/base.xml.in.

Could you please check?

Created an attachment (id=22955)
base.xml.in fix

Here it is, I see you didn't notice it.

You, right. Well, at some point later I'd catch it anyway - but thanks for the quick patch.