Feature-freeze exception for taglib and taglib-extras

Bug #431968 reported by Jeff Mitchell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
taglib (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

TagLib 1.6 was just released with a very significant number of fixes, including critical fixes that prevent tags or audio data from being corrupted in user files. A partial changelog is here -- keep in mind that this changelog was only started when a new maintainer stepped up to finish the 1.6 release, and does not contain the many other fixes since 1.5:

TagLib 1.6
==========

1.6:

 * New CMake option to build a static version - ENABLE_STATIC.
 * Added support for disabling dllimport/dllexport on Windows using the
   TAGLIB_STATIC macro.
 * Support for parsing the obsolete 'gnre' MP4 atom.
 * New cpp macros TAGLIB_WITH_MP4 and TAGLIB_WITH_ASF to determin if
   TagLib was built with MP4/ASF support.

1.6 RC1:

 * Split Ogg packets larger than 64k into multiple pages. (BUG:171957)
 * TagLib can now use FLAC padding block. (BUG:107659)
 * ID3v2.2 frames are now not incorrectly saved. (BUG:176373)
 * Support for ID3v2.2 PIC frames. (BUG:167786)
 * Fixed a bug in ByteVectorList::split().
 * XiphComment::year() now falls back to YEAR if DATE doesn't exist
   and XiphComment::year() falls back to TRACKNUM if TRACKNUMBER doesn't
   exist. (BUG:144396)
 * Improved ID3v2.3 genre parsing. (BUG:188578)
 * Better checking of corrupted ID3v2 APIC data. (BUG:168382)
 * Bitrate calculating using the Xing header now uses floating point
   numbers. (BUG:172556)
 * New TagLib::String method rfind().
 * Added support for MP4 file format with iTunes-style metadata [optional].
 * Added support for ASF (WMA) file format [optional].
 * Fixed crash when saving a Locator APEv2 tag. (BUG:169810)
 * Fixed a possible crash in the non-const version of String::operator[]
   and in String::operator+=. (BUG:169389)
 * Added support for PRIV ID3v2 frames.
 * Empty ID3v2 genres are no longer treated as numeric ID3v1 genres.
 * Added support for the POPM (rating/playcount) ID3v2 frame.
 * Generic RIFF file format support:
   * Support for AIFF files with ID3v2 tags.
   * Support for WAV files with ID3v2 tags.
 * Fixed crash on handling unsupported ID3v2 frames, e.g. on encrypted
   frames. (BUG:161721)
 * Fixed overflow while calculating bitrate of FLAC files with a very
   high bitrate.

In addition to the significant number of bug fixes, this version includes support for MP4 and ASF files. This is the same exact code that has lived in taglib-extras prior to the TagLib 1.6 release, so it is not untested code. Although it is disabled by default, this is purely because some distributions asked for this in the past (many have changed their minds; Fedora Legal for instance decided that the formats posed no patent problems); since Ubuntu has included taglib-extras already, there is no reason not to build this code.

Including TagLib 1.6 will also require including an update to taglib-extras-1.0, removing the redundant code to avoid namespace conflicts. The change in taglib-extras is API/ABI incompatible; however, the only package using it is Amarok (which has been granted an exception and which I will fix). JuK has an Ubuntu-specific patch using taglib-extras, however I can either fix the patch or it can simply be dropped.

It is *highly* recommended that these changes make it into Karmic; otherwise, not only does it keep users' data at risk from severe TagLib bugs, but it will become much harder to package any future packages (including Amarok) that want to use the new taglib formats and taglib-extras API/ABI.

Revision history for this message
Jonathan Riddell (jr) wrote :

Yes we want this to fix bugs in the existing versions and to fix bug 424328 (Amarok FFe). There is minimal impact of regressions because the code is just being moved about (from taglib-extras to taglib) and is otherwise bug fixes. Juk will needs its taglib extras patch updated. We will upload the new taglib alongside Amarok RC. Packages in ~jr PPA currently.

Changed in taglib (Ubuntu):
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package taglib - 1.6-2ubuntu1

---------------
taglib (1.6-2ubuntu1) karmic; urgency=low

  * Ubuntu build, remove .symbol files
  * Closes LP: #431968

taglib (1.6-2) experimental; urgency=low

  * Build with ASF (-DWITH_ASF=ON) and MP4 (-DWITH_MP4=ON). Update symbols
    file and libtag1c2a shlibs accordingly.
  * This release breaks libtaglib-extras0. Add Breaks: to libtag1c2a and
    libtag1-* packages.

taglib (1.6-1) unstable; urgency=low

  * New upstream release.
  * Bump Standards-Version to 3.8.3 (no changes needed).
  * Drop general/recognize_oga_files_fix.diff patch, merged upstream.
  * Refresh other patches.
  * Refresh rusxmms patch.
  * Update install files.
  * Update symbols file.
  * Bump shlibs of libtag1-* to 1.6.

 -- Jonathan Riddell <email address hidden> Mon, 21 Sep 2009 11:14:26 +0100

Changed in taglib (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.