Ubuntu
qemu-kvm package

[patch] `kvm -name TITLE` option does not set gnome-panel name correctly

Bug #423076 reported by Dominic Evans
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
qemu-kvm (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Binary package hint: qemu-kvm

# Abstract

Launching a vm with the '-name string' cmdline option to set the name of the guest to a particular string correctly sets the window decoration title but not the title used in 'window list' gnome-panel (only its tooltip).

# Description

If I specify 'kvm -name RHEL.5.1', I correctly see 'QEMU (RHEL.5.1)' in the window decoration title, but the 'window list' gnome-panel down the bottom merely displays 'QEMU' still. It is only if I hover over the entry down the bottom that I am shown the full 'QEMU (RHEL.5.1)' title. Ideally this should be always used so that multiple qemu windows can be quick switched between (especially when they have been grouped).

---

qemu-kvm:
  Installed: 0.11.0~rc1-0ubuntu11
  Candidate: 0.11.0~rc1-0ubuntu11
  Version table:
 *** 0.11.0~rc1-0ubuntu11 0
        500 http://gb.archive.ubuntu.com karmic/main Packages
        100 /var/lib/dpkg/status

Related branches

lp:ubuntu/karmic/qemu-kvm
Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Thanks for the report.

I'm not a Gnome developer, and I have no idea how to solve this.

Do you?

:-Dustin

Changed in qemu-kvm (Ubuntu):
importance: Undecided → Wishlist
Dustin Kirkland  (kirkland)
Changed in qemu-kvm (Ubuntu):
status: New → Won't Fix
Revision history for this message
Anthony Liguori (anthony-codemonkey) wrote :

This is an SDL issue not a QEMU issue.

Dominic Evans (oldmanuk)
Changed in qemu-kvm (Ubuntu):
status: Won't Fix → Confirmed
Revision history for this message
Dominic Evans (oldmanuk) wrote :

Re-opening this bug as it took me a minute of googling to find what code change were needed in qemu-kvm. Will attach a patch shortly.

Revision history for this message
Dominic Evans (oldmanuk) wrote :

Fixed by passing the 'QEMU (NAME)' as the icon_title value to SDL_WM_SetCaption.

debdiff attached, standalone patch for debian/patches to follow

summary: - `kvm -name TITLE` option does not set gnome-panel name correctly
+ [patch] `kvm -name TITLE` option does not set gnome-panel name correctly
Revision history for this message
Dominic Evans (oldmanuk) wrote :

debian/patches/06_improve-qemu-sdl-title.patch

Revision history for this message
Dominic Evans (oldmanuk) wrote :

built and installed the pkg locally and found to be working as desired

have also uploaded to my ppa

Dustin Kirkland  (kirkland)
Changed in qemu-kvm (Ubuntu):
status: Confirmed → Triaged
assignee: nobody → Dustin Kirkland (kirkland)
Revision history for this message
Dominic Evans (oldmanuk) wrote :

fwiw, have also submitted the patch upstream

http://lists.gnu.org/archive/html/qemu-devel/2009-09/msg01162.html

Dustin Kirkland  (kirkland)
Changed in qemu-kvm (Ubuntu):
status: Triaged → In Progress
Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Dominic-

Hi, I tested your patch. It looks okay when qemu-kvm is called from the command line. However, it breaks libvirt applications like virt-manager.

Can you take a look at that? It might well be a bug in libvirt. But we can't include this patch until we get that sorted out. I'll be glad to sponsor patches to both libvirt and qemu-kvm, if necessary.

Thanks,
:-Dustin

Changed in qemu-kvm (Ubuntu):
status: In Progress → Incomplete
assignee: Dustin Kirkland (kirkland) → nobody
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package qemu-kvm - 0.11.0~rc2-0ubuntu5

---------------
qemu-kvm (0.11.0~rc2-0ubuntu5) karmic; urgency=low

  * debian/patches/06_set_sdl_title.patch: set the sdl title properly
    when using -name, LP: #423076
  * debian/patches/07_right_ctrl_grab.patch: support right-ctrl grab
    for improved accessibility, LP: #237635
  * debian/08_fix_qemu-ifup.patch: fix positional argument problem in
    qemu-ifup script, LP: #237635
  * debian/install, debian/links: install qemu-ifup and qemu-ifdown to
    /usr/bin, and symlink them to the (somewhat silly) location where
    qemu expects to find an executable script, update the ifdown script
    to use the same logic in determining the bridge interface, LP: #430655

 -- Dustin Kirkland <email address hidden> Fri, 18 Sep 2009 10:59:44 -0500

Changed in qemu-kvm (Ubuntu):
status: Incomplete → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.