random file corruptions in ntfs-3g < 1.2506

An SRU is fine provided that the relevant fixes are backported. Simply dropping in the new upstream version won't be acceptable.

This should be the correct patch (down to the smallest possible delta), I can only test for regressions though, since I am not sure how to reproduce the bug myself.

diff -u ntfs-3g-1.2216/debian/changelog ntfs-3g-1.2216/debian/changelog
--- ntfs-3g-1.2216/debian/changelog
+++ ntfs-3g-1.2216/debian/changelog
@@ -1,3 +1,10 @@
+ntfs-3g (1:1.2216-1ubuntu2) hardy; urgency=low
+
+ * Backported fix in 1.2506 that addresses random file corruptions (LP:
+ #229000)
+
+ -- Agostino Russo <email address hidden> Wed, 28 May 2008 21:19:15 +0100
+
 ntfs-3g (1:1.2216-1ubuntu1) hardy; urgency=low

   * New upstream bug fix release. (LP: #199161)
only in patch2:
unchanged:
--- ntfs-3g-1.2216.orig/libntfs-3g/lcnalloc.c
+++ ntfs-3g-1.2216/libntfs-3g/lcnalloc.c
@@ -278,7 +278,7 @@
   bmp_pos &= ~7;
   writeback = 0;

- while (1) {
+ while (lcn < buf_size) {
    byte = buf + (lcn >> 3);
    bit = 1 << (lcn & 7);
    if (has_guess) {

Taking.

This bug was fixed in the package ntfs-3g - 1:1.2310-1ubuntu2

---------------
ntfs-3g (1:1.2310-1ubuntu2) intrepid; urgency=low

  * libntfs-3g/lcnalloc.c: Fix potential data corruption: Multi-block
    allocation could allocate or free used blocks in certain rare
    circumstances. Patch taken from upstream CVS:
    http://ntfs-3g.cvs.sourceforge.net/ntfs-3g/ntfs-3g/libntfs-3g/lcnalloc.c?r1=1.13&r2=1.14
    (LP: #229000)

 -- Martin Pitt <email address hidden> Fri, 30 May 2008 16:49:55 +0200

I appplied the patch (thanks Agostino!) and tested it extensively:

- I used the fairly comprehensive POSIX test suite from http://www.ntfs-3g.org/pjd-fstest.html before and afterwards. Output was identical.
- Lots of random writes, unmount, mount, read, and check with diff that files are identical
- fill the device up to the last block and compare that everythign was written correctly

Accepted into hardy-proposed. Please test and give feedback here.

not sure how to trigger the issue but accessing a ntfs drive using nautilus and the command line, browsing the directories, copying, moving things between directories, renaming, unmount and mounting again works correctly using the current version

Copied to hardy-updates.

Hi,

I cannot find 1:1.2310-1ubuntu2 in hardy-updates. It still shows 1:1.2216-1ubuntu2 in http://packages.ubuntu.com/hardy-updates/ntfs-3g and in the repositories. Please let me know how to get this update. Thanks a lot.

You have the up to date version with that file system corruption bug fixed. We didn't put the entire new upstream version into hardy, I just backported that particular fix.